Changeset 91139 in vbox

Timestamp:

Sep 7, 2021 12:37:53 PM (3 years ago)

Author:

vboxsync

Message:

Audio/Validation Kit: Some more diagnostics to find out why some testbox guests refuse to play any test tones. ​bugref:10008

File:

• trunk/src/VBox/ValidationKit/utils/audio/vkatCommon.cpp (modified) (4 diffs)

trunk/src/VBox/ValidationKit/utils/audio/vkatCommon.cpp

@@ -265 +265 @@
         uint32_t cbToPlayTotal  = PDMAudioPropsMilliToBytes(&pStream->Cfg.Props, pParms->msDuration);
         AssertStmt(cbToPlayTotal, rc = VERR_INVALID_PARAMETER);
+        uint32_t cbPlayedTotal  = 0;
 
         RTTestPrintf(g_hTest, RTTESTLVL_DEBUG, "Playing %RU32 bytes total\n", cbToPlayTotal);
@@ -286 +287 @@
 
         uint64_t        offStream          = 0;
-        uint64_t        tsStartMs          = RTTimeMilliTS();
-        RTMSINTERVAL    uTimeoutMs         = pParms->msDuration * 4; /* Four times the time playback should roughly take */
+        uint64_t        uTimeoutNs         = (pParms->msDuration * 4) * RT_NS_1MS; /* Four times the time playback should roughly take */
 
         while (cbToPlayTotal)
@@ -322 +322 @@
                         {
                             offStream += cbPlayed;
+
+                            if (cbPlayed != cbToPlay)
+                                RTTestFailed(g_hTest, "Only played %RU32/%RU32 bytes", cbPlayed, cbToPlay);
                         }
                     }
@@ -334 +337 @@
                 AssertFailedBreakStmt(rc = VERR_AUDIO_STREAM_NOT_READY);
 
-            Assert(cbToPlayTotal >= cbPlayed);
-            cbToPlayTotal -= cbPlayed;
+            cbPlayedTotal += cbPlayed;
+            AssertBreakStmt(cbPlayedTotal <= cbToPlayTotal, VERR_BUFFER_OVERFLOW);
 
             /* Fail-safe in case something screwed up while playing back. */
-            if (RTTimeMilliTS() - tsStartMs > uTimeoutMs)
+            if (RTTimeNanoTS() - nsStarted > uTimeoutNs)
             {
-                RTTestFailed(g_hTest, "Playback took too long (%RU32ms exceeded), aborting\n", uTimeoutMs);
+                RTTestFailed(g_hTest, "Playback took too long (%RU32ms exceeded), aborting\n", uTimeoutNs / RT_NS_1MS);
                 rc = VERR_TIMEOUT;
+            }
+
+            if (RT_FAILURE(rc))
                 break;
-            }
-        }
-
-        if (cbToPlayTotal != 0)
-            RTTestFailed(g_hTest, "Playback ended unexpectedly (%RU32 bytes left)\n", cbToPlayTotal);
+        }
+
+        if (cbPlayedTotal != cbToPlayTotal)
+            RTTestFailed(g_hTest, "Playback ended unexpectedly (%RU32/%RU32 played)\n", cbPlayedTotal, cbToPlayTotal);
 
         if (RT_SUCCESS(rc))