Changeset 91365 in vbox

Timestamp:

Sep 24, 2021 2:42:48 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

147035

Message:

FE/Qt: bugref:9340. Selecting the current medium as medium selector starts.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UICommon.cpp (modified) (3 diffs)
• globals/UICommon.h (modified) (1 diff)
• medium/UIMediumSelector.cpp (modified) (4 diffs)
• medium/UIMediumSelector.h (modified) (1 diff)
• settings/machine/UIMachineSettingsStorage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp

@@ -1850 +1850 @@
 }
 
-int UICommon::openMediumSelectorDialog(QWidget *pParent, UIMediumDeviceType  enmMediumType, QUuid &outUuid,
+int UICommon::openMediumSelectorDialog(QWidget *pParent, UIMediumDeviceType  enmMediumType, QUuid &inOutUuid,
                                        const QString &strMachineFolder, const QString &strMachineName,
                                        const QString &strMachineGuestOSTypeId, bool fEnableCreate, const QUuid &uMachineID /* = QUuid() */)
@@ -1857 +1857 @@
 
     QWidget *pDialogParent = windowManager().realParentWindow(pParent);
-    QPointer<UIMediumSelector> pSelector = new UIMediumSelector(enmMediumType, strMachineName,
+    QPointer<UIMediumSelector> pSelector = new UIMediumSelector(inOutUuid, enmMediumType, strMachineName,
                                                                 strMachineFolder, strMachineGuestOSTypeId,
                                                                 uMachineOrGlobalId, pDialogParent);
@@ -1883 +1883 @@
         else
         {
-            outUuid = selectedMediumIds[0];
-            updateRecentlyUsedMediumListAndFolder(enmMediumType, medium(outUuid).location());
+            inOutUuid = selectedMediumIds[0];
+            updateRecentlyUsedMediumListAndFolder(enmMediumType, medium(inOutUuid).location());
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h

@@ -407 +407 @@
           * @param  parent                   Passes the parent of the dialog,
           * @param  enmMediumType            Passes the medium type.
+          * @param  inOutUuid                Passes the currently selected medium id if there is one.
+          * @param  strMachineFolder         Passes the machine folder,
           * @param  strMachineName           Passes the name of the machine,
-          * @param  strMachineFolder         Passes the machine folder,
           * @param  strMachineGuestOSTypeId  Passes the type ID of machine's guest os,
           * @param  fEnableCreate            Passes whether to show/enable create action in the medium selector dialog,
           * @param  uMachineID               Passes the machine UUID,
           * returns the return code of the UIMediumSelector::ReturnCode as int. In case of a medium selection
-          *         UUID of the selected medium is stored in @param outUuid.*/
-        int openMediumSelectorDialog(QWidget *pParent, UIMediumDeviceType  enmMediumType, QUuid &outUuid,
+          *         UUID of the selected medium is stored in @param inOutUuid.*/
+        int openMediumSelectorDialog(QWidget *pParent, UIMediumDeviceType  enmMediumType, QUuid &inOutUuid,
                                      const QString &strMachineFolder, const QString &strMachineName,
                                      const QString &strMachineGuestOSTypeId, bool fEnableCreate, const QUuid &uMachineID = QUuid());

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.cpp

@@ -53 +53 @@
 
 
-UIMediumSelector::UIMediumSelector(UIMediumDeviceType enmMediumType, const QString &machineName,
+UIMediumSelector::UIMediumSelector(const QUuid &uCurrentMediumId, UIMediumDeviceType enmMediumType, const QString &machineName,
                                    const QString &machineSettingsFilePath, const QString &strMachineGuestOSTypeId,
                                    const QUuid &uMachineID, QWidget *pParent)
@@ -85 +85 @@
     configure();
     finalize();
+    selectMedium(uCurrentMediumId);
 }
 
@@ -554 +555 @@
 void UIMediumSelector::selectMedium(const QUuid &uMediumID)
 {
-    if (!m_pTreeWidget)
+    if (!m_pTreeWidget || uMediumID.isNull())
         return;
     UIMediumItem *pMediumItem = searchItem(0, uMediumID);
@@ -618 +619 @@
     if (m_pParent)
         UIDesktopWidgetWatchdog::centerWidget(this, m_pParent, false);
+
+    if (m_pTreeWidget)
+        m_pTreeWidget->setFocus();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumSelector.h

@@ -51 +51 @@
 public:
 
-    UIMediumSelector(UIMediumDeviceType enmMediumType, const QString &machineName,
+    UIMediumSelector(const QUuid &uCurrentMediumId, UIMediumDeviceType enmMediumType, const QString &machineName,
                      const QString &machineSettingsFilePath, const QString &strMachineGuestOSTypeId,
                      const QUuid &uMachineID, QWidget *pParent);

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -4003 +4003 @@
 
     QUuid uMediumId;
-    int iResult = uiCommon().openMediumSelectorDialog(this, m_pMediumIdHolder->type(), uMediumId,
+    if (m_pMediumIdHolder)
+        uMediumId = m_pMediumIdHolder->id();
+
+    int iResult = uiCommon().openMediumSelectorDialog(this, m_pMediumIdHolder->type(), uMediumId /* in/out parameter */,
                                                       strMachineFolder, m_strMachineName,
                                                       m_strMachineGuestOSTypeId,