Changeset 91392 in vbox for trunk/src/VBox/Main/include

Timestamp:

Sep 27, 2021 12:33:40 PM (3 years ago)

Author:

vboxsync

Message:

Main/NLS: VirtualBoxTranslator::i_translate should not safe the passed in source string as there is no guarantee that it is immutable. So, make the translator return a safe source string copy iff it returns a translated string. bugref:1909

File:

• trunk/src/VBox/Main/include/QMTranslator.h (modified) (1 diff)

trunk/src/VBox/Main/include/QMTranslator.h

@@ -33 +33 @@
      * Gets translation from loaded QM file
      *
-     * @param   pszContext  QM context to look for translation
-     * @param   pszSource   Source string in one-byte encoding
-     * @param   pszDisamb   Disambiguationg comment, empty by default
-     * @param   iNum        Plural form indicator.
+     * @param   pszContext      QM context to look for translation
+     * @param   pszSource       Source string in one-byte encoding
+     * @param   ppszSafeSource  Where to return pointer to a safe copy of @a
+     *                          pszSource for the purpose of reverse translation.
+     *                          Will be set to NULL if @a pszSource is returned.
+     * @param   pszDisamb       Disambiguationg comment, empty by default
+     * @param   iNum            Plural form indicator.
      *
      * @returns Pointer to a translation (UTF-8 encoding), source string on failure.
      */
-    const char *translate(const char *pszContext, const char *pszSource,
+    const char *translate(const char *pszContext, const char *pszSource, const char **ppszSafeSource,
                           const char *pszDisamb = NULL, const int iNum = -1) const RT_NOEXCEPT;