Changeset 91428 in vbox for trunk/src/VBox

Timestamp:

Sep 28, 2021 9:23:40 AM (3 years ago)

Author:

vboxsync

Message:

Audio/Validation Kit: When executing host binaries, send output directly to stdout instead of piping (and waiting for) it. ​bugref:10008

File:

• trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py

@@ -39 +39 @@
 import signal
 import subprocess
-import time
 
 # Only the main script needs to modify the path.
@@ -271 +270 @@
             oProcess = utils.sudoProcessPopen(asArgs,
                                               env = asEnvTmp,
-                                              stdout = subprocess.PIPE, stderr = subprocess.PIPE, shell = False,
+                                              stdout = sys.stdout, stderr = sys.stdout,
                                               close_fds = False);
         else:
             oProcess = utils.processPopenSafe(asArgs,
                                               env = asEnvTmp,
-                                              stdout = subprocess.PIPE, stderr = subprocess.PIPE);
+                                              stdout = sys.stdout, stderr = sys.stdout);
         if oProcess:
-            for line in iter(oProcess.stdout.readline, b''):
-                reporter.log('[' + sWhat + '] ' + line.decode('utf-8'));
-                self.processPendingEvents();
-                time.sleep(0.01); # Don't hog the CPU too much.
-            oProcess.communicate();
-            if oProcess.returncode == 0:
+            self.pidFileAdd(oProcess.pid, sWhat, fSudo = fAsAdmin);
+            iRc = oProcess.wait();
+            self.pidFileRemove(oProcess.pid);
+
+            if iRc == 0:
+                reporter.log('*** %s: exit code %d' % (sWhat, iRc));
                 fRc = True;
             else:
-                reporter.log2('Executing \"%s\" on host returned exit code error %d' % (sWhat, oProcess.returncode));
+                reporter.log('!*! %s: exit code %d' % (sWhat, iRc));
 
         return fRc;
@@ -302 +301 @@
 
         reporter.testStart(sWhat);
+
+        try:    sys.stdout.flush();
+        except: pass;
+        try:    sys.stderr.flush();
+        except: pass;
 
         fRc = self.executeHstLoop(sWhat, asArgs, asEnv);