Changeset 91435 in vbox for trunk/src

Timestamp:

Sep 28, 2021 1:10:21 PM (3 years ago)

Author:

vboxsync

Message:

Shared Clipboard: prevent guest clipboard reset when clipboard sharing is disabled, bugref:10110, ticketref:20487.

This commit prevents host service from notifying guest about new data appearance
in host clipboard buffer when clipboard sharing is disabled. When such notification
was sent in such situation, it triggered guest to ask host for a clipboard content.
Such request was rejected on a host side what, in turn, resulted in guest clipboard
content loss.

File:

• trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc.cpp

@@ -1407 +1407 @@
 int ShClSvcHostReportFormats(PSHCLCLIENT pClient, SHCLFORMATS fFormats)
 {
+    /*
+     * Check if the service mode allows this operation and whether the guest is
+     * supposed to be reading from the host. Otherwise, silently ignore reporting
+     * formats and return VINF_SUCCESS in order to do not trigger client
+     * termination in svcConnect().
+     */
+    uint32_t uMode = ShClSvcGetMode();
+    if (   uMode == VBOX_SHCL_MODE_BIDIRECTIONAL
+        || uMode == VBOX_SHCL_MODE_HOST_TO_GUEST)
+    { /* likely */ }
+    else
+        return VINF_SUCCESS;
+
     AssertPtrReturn(pClient, VERR_INVALID_POINTER);