Changeset 91501 in vbox for trunk

Timestamp:

Sep 30, 2021 7:17:39 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Notification-center: Crash fix; Progress object can be instantly killed on append due to latest changes in progress-handling policy.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationCenter.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationCenter.cpp

@@ -175 +175 @@
 QUuid UINotificationCenter::append(UINotificationObject *pObject)
 {
+    /* Sanity check: */
     AssertPtrReturn(m_pModel, QUuid());
+    AssertPtrReturn(pObject, QUuid());
+
+    /* Is object critical? */
+    const bool fCritical = pObject->isCritical();
+    /* Is object progress? */
+    const bool fProgress = pObject->inherits("UINotificationProgress");
+
+    /* Handle object. Be aware it can be deleted during handling! */
     const QUuid uId = m_pModel->appendObject(pObject);
 
     /* If object is critical and center isn't opened yet: */
-    if (!m_pOpenButton->isChecked() && pObject->isCritical())
+    if (!m_pOpenButton->isChecked() && fCritical)
     {
         /* We should delay progresses for a bit: */
-        const int iDelay = pObject->inherits("UINotificationProgress") ? 2000 : 0;
+        const int iDelay = fProgress ? 2000 : 0;
         /* We should issue an open request: */
         AssertPtrReturn(m_pTimerOpen, uId);