Changeset 91624 in vbox for trunk/src/VBox/HostServices/SharedClipboard

Timestamp:

Oct 7, 2021 9:14:43 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

147349

Message:

SharedClipboard/X11: ShClX11RequestFromX11CompleteCallback must free payload if we fail to signal the event for some reason (that's what the others are doing). bugref:9437

File:

• trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-x11.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc-x11.cpp

@@ -326 +326 @@
         if (RT_SUCCESS(rc2))
         {
-            ShClEventSignal(&pCtx->pClient->EventSrc, pReq->idEvent, pPayload);
-            /* Note: Skip checking if signalling the event is successful, as it could be gone already by now. */
+            rc2 = ShClEventSignal(&pCtx->pClient->EventSrc, pReq->idEvent, pPayload);
             RTCritSectLeave(&pCtx->pClient->CritSect);
-        }
+            if (RT_SUCCESS(rc2))
+                pPayload = NULL;
+        }
+
+        if (pPayload)
+            ShClPayloadFree(pPayload);
     }