Changeset 91630 in vbox

Timestamp:

Oct 7, 2021 9:28:39 PM (3 years ago)

Author:

vboxsync

Message:

SharedClipboard/common: ShClEventSignal must clear pEvent->pPayload if RTSemEventMultiSignal fails, otherwise it the payload could be freed twice. Don't leak semaphores in ShClEventIdGenerateAndRegister failure path. Three longish r=bird comments on the insanity of the event interface. [scm fix] bugref:9437

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp (modified) (2 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp

@@ -326 +326 @@
  * @returns VBox status code.
  * @param   pSource             Event source to unregister event for.
- * @param   uID                 Event ID to unregister. 
- *  
+ * @param   uID                 Event ID to unregister.
+ *
  * @todo    r=bird: The caller must enter crit sect protecting the event source
  *          here, must it?  See explanation in ShClEventWait.
@@ -374 +374 @@
  *          and shclEventPayloadDetachInternal w/o holding the critical section
  *          protecting that list, otherwise wtf is the point of the locking.
- * 
+ *
  *          More to the point, ShClEventSignal is called on the HGCM service
  *          thread and would be racing the host clipboard worker thread/whomever