Changeset 91696 in vbox for trunk/src

Timestamp:

Oct 12, 2021 5:19:44 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: Runtime UI: Machine-view: Get rid of redundant size hints spammed as a part of guest auto-resize feature while previous hint still being handled.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• UIMachineView.cpp (modified) (2 diffs)
• UIMachineView.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.cpp

@@ -348 +348 @@
     else
     {
+        /* Should we send a hint? */
+        bool fSendHint = true;
         /* Do not send a hint if nothing has changed to prevent the guest being notified about its own changes: */
-        if ((int)frameBuffer()->width() != size.width() || (int)frameBuffer()->height() != size.height())
+        if (fSendHint && (int)frameBuffer()->width() == size.width() && (int)frameBuffer()->height() == size.height())
+            fSendHint = false;
+        /* Do not send a hint if GA supports graphics and we have sent that hint already: */
+        if (fSendHint && uisession()->isGuestSupportsGraphics() && m_lastSizeHint == size)
+            fSendHint = false;
+        if (fSendHint)
         {
             LogRel(("GUI: UIMachineView::sltPerformGuestResize: Sending guest size-hint to screen %d as %dx%d\n",
@@ -362 +369 @@
                                        0 /* bits per pixel */,
                                        true /* notify? */);
+            m_lastSizeHint = size;
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.h

@@ -373 +373 @@
     QSize m_sizeHintOverride;
 
+    /** Last size hint sent as a part of guest auto-resize feature.
+      * @note Useful to avoid spamming CDisplay with same hint before
+      *       frame-buffer finally resized to requested size. */
+    QSize  m_lastSizeHint;
+
     /** Holds current host-screen number. */
     int m_iHostScreenNumber;