Changeset 91916 in vbox for trunk/src/VBox/NetworkServices/NAT

Timestamp:

Oct 21, 2021 12:26:53 AM (3 years ago)

Author:

vboxsync

Message:

NAT/Net: Convert assertion about RTNetStrToIPv4Cidr returning a valid
prefix into an explicit test and return an error message.
bugref:9330, bugref:9929.

File:

• trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp (modified) (2 diffs)

trunk/src/VBox/NetworkServices/NAT/VBoxNetLwipNAT.cpp

@@ -609 +609 @@
     }
 
-    if (iPrefixLength > 30)
-    {
-        reportError("IPv4 prefix length %d is too narrow\n", iPrefixLength);
+    if (iPrefixLength > 30 || 0 >= iPrefixLength)
+    {
+        reportError("Invalid IPv4 prefix length %d\n", iPrefixLength);
         return VERR_INVALID_PARAMETER;
     }
@@ -617 +617 @@
     rc = RTNetPrefixToMaskIPv4(iPrefixLength, &Mask4);
     AssertRCReturn(rc, rc);
-    AssertReturn(iPrefixLength > 0, VERR_INVALID_PARAMETER);
+
+    /** @todo r=uwe Check the address is unicast, not a loopback, etc. */
 
     RTNETADDRIPV4 Addr4;