Changeset 92029 in vbox

Timestamp:

Oct 25, 2021 12:05:29 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

147838

Message:

FE/Qt: bugref:9996: UIChooserModel: When new VM is registered, we should try to preserve selection while updating the tree cause new VM isn't guaranteed to be present in the tree.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -433 +433 @@
 
     /* If global item is currently chosen, selection should be invalidated: */
-    if (firstSelectedItem()->type() == UIChooserNodeType_Global)
+    if (firstSelectedItem() && firstSelectedItem()->type() == UIChooserNodeType_Global)
         emit sigSelectionInvalidated();
 }
@@ -1153 +1153 @@
         {
             /* Rebuild tree for main root: */
-            buildTreeForMainRoot(false /* preserve selection */);
-            /* Select newly added item: */
-            setSelectedItem(root()->searchForItem(uMachineId.toString(),
-                                                  UIChooserItemSearchFlag_Machine |
-                                                  UIChooserItemSearchFlag_ExactId));
+            buildTreeForMainRoot(true /* preserve selection */);
+            /* Search for newly added item: */
+            UIChooserItem *pNewItem = root()->searchForItem(uMachineId.toString(),
+                                                            UIChooserItemSearchFlag_Machine |
+                                                            UIChooserItemSearchFlag_ExactId);
+            /* Select newly added item if any: */
+            if (pNewItem)
+                setSelectedItem(pNewItem);
         }
     }