Changeset 92038 in vbox for trunk/src

Timestamp:

Oct 25, 2021 2:22:18 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: Tiny optimization in UIWizardNewVMNameOSTypeCommon::guessOSTypeFromName.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMNameOSTypePage.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMNameOSTypePage.cpp

@@ -176 +176 @@
 bool UIWizardNewVMNameOSTypeCommon::guessOSTypeFromName(UINameAndSystemEditor *pNameAndSystemEditor, QString strNewName)
 {
-    CHost host = uiCommon().host();
-    bool fSupportsHWVirtEx = host.GetProcessorFeature(KProcessorFeature_HWVirtEx);
-    bool fSupportsLongMode = host.GetProcessorFeature(KProcessorFeature_LongMode);
-
     /* Append default architecture bit-count (64/32) if not already in the name: */
     if (!strNewName.contains("32") && !strNewName.contains("64"))
+    {
+        /** @todo cache this result, no need to re-query it for each keystroke... */
+        CHost host = uiCommon().host();
+        bool fSupportsHWVirtEx = host.GetProcessorFeature(KProcessorFeature_HWVirtEx);
+        bool fSupportsLongMode = host.GetProcessorFeature(KProcessorFeature_LongMode);
         strNewName += ARCH_BITS == 64 && fSupportsHWVirtEx && fSupportsLongMode ? "64" : "32";
+    }
 
     /* Search for a matching OS type based on the string the user typed already. */