Changeset 92206 in vbox

Timestamp:

Nov 4, 2021 8:10:15 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

148037

Message:

Audio/Validation Kit: Do the test state checking / warning in drvHostValKitCleanup() to have it all in one place. bugref:10008

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioValidationKit.cpp

@@ -333 +333 @@
     RTListForEachSafe(&pThis->lstTestsRec, pTst, pTstNext, VALKITTESTDATA, Node)
     {
+        if (pTst->enmState != VALKITTESTSTATE_DONE)
+            LogRel(("ValKit: \tWarning: Test #%RU32 (recording) not done yet (state is '%s')\n",
+                    pTst->idxTest, drvHostValKitTestStatusToStr(pTst->enmState)));
+
         size_t const cbOutstanding = pTst->t.TestTone.u.Rec.cbToWrite - pTst->t.TestTone.u.Rec.cbWritten;
         if (cbOutstanding)
-            LogRel(("ValKit: \tRecording test #%RU32 has %RU64 bytes (%RU32ms) outstanding (%RU8%% left)\n",
+            LogRel(("ValKit: \tWarning: Recording test #%RU32 has %RU64 bytes (%RU32ms) outstanding (%RU8%% left)\n",
                     pTst->idxTest, cbOutstanding, PDMAudioPropsBytesToMilli(&pTst->t.TestTone.Parms.Props, (uint32_t)cbOutstanding),
                     100 - (pTst->t.TestTone.u.Rec.cbWritten * 100) / RT_MAX(pTst->t.TestTone.u.Rec.cbToWrite, 1)));
@@ -346 +350 @@
     RTListForEachSafe(&pThis->lstTestsPlay, pTst, pTstNext, VALKITTESTDATA, Node)
     {
+        if (pTst->enmState != VALKITTESTSTATE_DONE)
+            LogRel(("ValKit: \tWarning: Test #%RU32 (playback) not done yet (state is '%s')\n",
+                    pTst->idxTest, drvHostValKitTestStatusToStr(pTst->enmState)));
+
         size_t const cbOutstanding = pTst->t.TestTone.u.Play.cbToRead - pTst->t.TestTone.u.Play.cbRead;
         if (cbOutstanding)
-            LogRel(("ValKit: \tPlayback test #%RU32 has %RU64 bytes (%RU32ms) outstanding (%RU8%% left)\n",
+            LogRel(("ValKit: \tWarning: Playback test #%RU32 has %RU64 bytes (%RU32ms) outstanding (%RU8%% left)\n",
                     pTst->idxTest, cbOutstanding, PDMAudioPropsBytesToMilli(&pTst->t.TestTone.Parms.Props, (uint32_t)cbOutstanding),
                     100 - (pTst->t.TestTone.u.Play.cbRead * 100) / RT_MAX(pTst->t.TestTone.u.Play.cbToRead, 1)));
@@ -431 +439 @@
         LogRel(("ValKit: %RU32 tests still registered total (%RU32 play, %RU32 record)\n",
                 pThis->cTestsTotal, pThis->cTestsPlay, pThis->cTestsRec));
-
-        PVALKITTESTDATA pTst;
-        RTListForEach(&pThis->lstTestsRec, pTst, VALKITTESTDATA, Node)
-        {
-            if (pTst->enmState != VALKITTESTSTATE_DONE)
-                LogRel(("ValKit: Warning: Test #%RU32 not done yet (state is '%s')\n",
-                        pTst->idxTest, drvHostValKitTestStatusToStr(pTst->enmState)));
-        }
 
         if (   AudioTestSetIsRunning(pSet)