Changeset 92343 in vbox for trunk/src

Timestamp:

Nov 11, 2021 12:41:46 AM (3 years ago)

Author:

vboxsync

Message:

VMM/GMM: Put the chunk ID allocation under a separate spinlock so we can get one early in gmmR0RegisterChunk and reduce the amount of work done while owning the giant mutex a tiny bit. [build fix] bugref:10093

File:

• trunk/src/VBox/VMM/VMMR0/GMMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -2028 +2028 @@
         {
             idChunk = ASMBitNextClear(&pGMM->bmChunkId[0], GMM_CHUNKID_LAST + 1, idChunk);
-            if (idChunk > NIL_GMM_CHUNKID)
+            if (   idChunk > NIL_GMM_CHUNKID
+                && (uint32_t)idChunk <= GMM_CHUNKID_LAST)
             {
                 AssertMsgReturnStmt(!ASMAtomicBitTestAndSet(&pGMM->bmChunkId[0], idChunk), ("%#x\n", idChunk),
@@ -2045 +2046 @@
      */
     idChunk = ASMBitFirstClear(&pGMM->bmChunkId[0], GMM_CHUNKID_LAST + 1);
-    AssertMsgReturnStmt(idChunk > NIL_GMM_CHUNKID && idChunk <= GMM_CHUNKID_LAST, ("%#x\n", idChunk),
+    AssertMsgReturnStmt(idChunk > NIL_GMM_CHUNKID && (uint32_t)idChunk <= GMM_CHUNKID_LAST, ("%#x\n", idChunk),
                         RTSpinlockRelease(pGMM->hSpinLockChunkId), NIL_GVM_HANDLE);
     AssertMsgReturnStmt(!ASMAtomicBitTestAndSet(&pGMM->bmChunkId[0], idChunk), ("%#x\n", idChunk),