Changeset 92496 in vbox

Timestamp:

Nov 18, 2021 2:28:56 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

148357

Message:

FE/Qt: A small refactoring in UIExtraDataManager to increase code reuse.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/extradata

Files:

• UIExtraDataManager.cpp (modified) (11 diffs)
• UIExtraDataManager.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.cpp ¶

@@ -2732 +2732 @@
 bool UIExtraDataManager::visoCreatorDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_VISOCreator_DialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_VISOCreator_DialogGeometry);
 }
 
@@ -2746 +2742 @@
 bool UIExtraDataManager::selectorWindowShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_LastSelectorWindowPosition);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_LastSelectorWindowPosition);
 }
 
@@ -4199 +4191 @@
 bool UIExtraDataManager::sessionInformationDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_SessionInformationDialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_SessionInformationDialogGeometry);
 }
 
@@ -4253 +4241 @@
 bool UIExtraDataManager::fileManagerDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_GuestControl_FileManagerDialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_GuestControl_FileManagerDialogGeometry);
 }
 
@@ -4287 +4271 @@
 bool UIExtraDataManager::softKeyboardDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_SoftKeyboard_DialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_SoftKeyboard_DialogGeometry);
 }
 
@@ -4426 +4406 @@
 bool UIExtraDataManager::guestProcessControlDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_GuestControl_ProcessControlDialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_GuestControl_ProcessControlDialogGeometry);
 }
 
@@ -4494 +4470 @@
 bool UIExtraDataManager::extraDataManagerShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_ExtraDataManager_Geometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_ExtraDataManager_Geometry);
 }
 
@@ -4569 +4541 @@
 bool UIExtraDataManager::logWindowShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_LogWindowGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_LogWindowGeometry);
 }
 
@@ -4704 +4672 @@
 bool UIExtraDataManager::helpBrowserDialogShouldBeMaximized()
 {
-    /* Get corresponding extra-data: */
-    const QStringList data = extraDataStringList(GUI_HelpBrowser_DialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_HelpBrowser_DialogGeometry);
 }
 
@@ -4753 +4717 @@
 bool UIExtraDataManager::mediumSelectorDialogShouldBeMaximized()
 {
-    const QStringList data = extraDataStringList(GUI_MediumSelector_DialogGeometry);
-
-    /* Make sure 5th item has required value: */
-    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+    return dialogShouldBeMaximized(GUI_MediumSelector_DialogGeometry);
 }
 
@@ -5108 +5069 @@
 }
 
+bool UIExtraDataManager::dialogShouldBeMaximized(const QString &strKey)
+{
+    /* Get corresponding extra-data: */
+    const QStringList data = extraDataStringList(strKey);
+
+    /* Make sure 5th item has required value: */
+    return data.size() == 5 && data[4] == GUI_Geometry_State_Max;
+}
+
 /* static */
 QString UIExtraDataManager::extraDataKeyPerScreen(const QString &strBase, ulong uScreenIndex, bool fSameRuleForPrimary /* = false */)

trunk/src/VBox/Frontends/VirtualBox/src/extradata/UIExtraDataManager.h ¶

@@ -914 +914 @@
       *                          calculate resulting geometry if saved was not found. */
     QRect dialogGeometry(const QString &strKey, QWidget *pWidget, QWidget *pParentWidget = 0, const QRect &defaultGeometry = QRect());
+    /** Returns true if the dialog should be maximized.
+      * @param  strKey           Brings geometry extra-data key of particular dialog. */
+    bool dialogShouldBeMaximized(const QString &strKey);
 
     /** Returns string consisting of @a strBase appended with @a uScreenIndex for the *non-primary* screen-index.