Changeset 92547 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Nov 22, 2021 12:14:41 PM (3 years ago)

Author:

vboxsync

Message:

VMM: Nested VMX: bugref:10092 When CR3 is updated (PGMFlushTLB or PGMUpdateCR3) we need to translate it to a guest-physical address if it's a nested-guest physical address when EPT paging is enabled.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAll.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAll.cpp

@@ -1858 +1858 @@
                               PPGMPTWALKGST pGstWalk)
 {
+    AssertPtr(pWalk);
+    AssertPtr(pGstWalk);
     switch (enmSlatMode)
     {
@@ -2400 +2402 @@
      * Remap the CR3 content and adjust the monitoring if CR3 was actually changed.
      */
+    RTGCPHYS const GCPhysOldCR3 = pVCpu->pgm.s.GCPhysCR3;
+    RTGCPHYS       GCPhysCR3    = pgmGetGuestMaskedCr3(pVCpu, cr3);
+#ifdef VBOX_WITH_NESTED_HWVIRT_VMX_EPT
+    if (   !fPdpesMapped
+        && CPUMIsGuestVmxEptPagingEnabled(pVCpu))
+    {
+        PGMPTWALK    Walk;
+        PGMPTWALKGST GstWalk;
+        int const rc = pgmGstSlatWalkPhys(pVCpu, PGMSLAT_EPT, GCPhysCR3, &Walk, &GstWalk);
+        if (RT_SUCCESS(rc))
+            GCPhysCR3 = Walk.GCPhys;
+        else
+        {
+            AssertMsgFailed(("Failed to load CR3 at %#RX64. rc=%Rrc\n", GCPhysCR3, rc));
+            return rc;
+        }
+    }
+#endif
     int rc = VINF_SUCCESS;
-    RTGCPHYS const GCPhysOldCR3 = pVCpu->pgm.s.GCPhysCR3;
-    RTGCPHYS const GCPhysCR3    = pgmGetGuestMaskedCr3(pVCpu, cr3);
     if (GCPhysOldCR3 != GCPhysCR3)
     {
@@ -2484 +2502 @@
      * Remap the CR3 content and adjust the monitoring if CR3 was actually changed.
      */
+    RTGCPHYS GCPhysCR3 = pgmGetGuestMaskedCr3(pVCpu, cr3);
+#ifdef VBOX_WITH_NESTED_HWVIRT_VMX_EPT
+    if (   !fPdpesMapped
+        && CPUMIsGuestVmxEptPagingEnabled(pVCpu))
+    {
+        PGMPTWALK    Walk;
+        PGMPTWALKGST GstWalk;
+        int const rc = pgmGstSlatWalkPhys(pVCpu, PGMSLAT_EPT, GCPhysCR3, &Walk, &GstWalk);
+        if (RT_SUCCESS(rc))
+            GCPhysCR3 = Walk.GCPhys;
+        else
+        {
+            AssertMsgFailed(("Failed to load CR3 at %#RX64. rc=%Rrc\n", GCPhysCR3, rc));
+            return VERR_PGM_PAE_PDPE_RSVD;
+        }
+    }
+#endif
     int rc = VINF_SUCCESS;
-    RTGCPHYS const GCPhysCR3 = pgmGetGuestMaskedCr3(pVCpu, cr3);
     if (pVCpu->pgm.s.GCPhysCR3 != GCPhysCR3)
     {
@@ -2723 +2757 @@
         else
         {
-            /** @todo Raise EPT violation VM-exit. */
-            return VERR_NOT_IMPLEMENTED;
+            AssertMsgFailed(("Failed to load CR3 at %#RX64. rc=%Rrc\n", GCPhysCR3, rc));
+            return rc;
         }
     }