Changeset 92624 in vbox for trunk/src/VBox/Frontends

Timestamp:

Nov 29, 2021 12:01:38 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

148516

Message:

FE/Qt: bugref:10067: UICloudNetworkingStuff: Fixing regression crash in r148020; Parent should present for stuff handling progress synchronously.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UICloudNetworkingStuff.cpp (modified) (8 diffs)
• globals/UICloudNetworkingStuff.h (modified) (4 diffs)
• manager/details/UIDetailsElement.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICloudNetworkingStuff.cpp

@@ -336 +336 @@
                                              CStringArray &comNames,
                                              CStringArray &comIDs,
-                                             UINotificationCenter *pParent /* = 0 */)
+                                             UINotificationCenter *pParent)
 {
     /* Currently we are interested in Available images only: */
@@ -365 +365 @@
                                                         CStringArray &comNames,
                                                         CStringArray &comIDs,
-                                                        UINotificationCenter *pParent /* = 0 */)
+                                                        UINotificationCenter *pParent)
 {
     /* List cloud source boot volumes: */
@@ -390 +390 @@
                                                 CStringArray &comNames,
                                                 CStringArray &comIDs,
-                                                UINotificationCenter *pParent /* = 0 */)
+                                                UINotificationCenter *pParent)
 {
     /* List cloud instances: */
@@ -415 +415 @@
                                                       CStringArray &comNames,
                                                       CStringArray &comIDs,
-                                                      UINotificationCenter *pParent /* = 0 */)
+                                                      UINotificationCenter *pParent)
 {
     /* List cloud source instances: */
@@ -440 +440 @@
                                                    const CVirtualSystemDescription &comDescription,
                                                    CVirtualSystemDescriptionForm &comResult,
-                                                   UINotificationCenter *pParent /* = 0 */)
+                                                   UINotificationCenter *pParent)
 {
     /* Prepare export VSD form: */
@@ -461 +461 @@
                                                    const CVirtualSystemDescription &comDescription,
                                                    CVirtualSystemDescriptionForm &comResult,
-                                                   UINotificationCenter *pParent /* = 0 */)
+                                                   UINotificationCenter *pParent)
 {
     /* Prepare import VSD form: */
@@ -526 +526 @@
 bool UICloudNetworkingStuff::cloudMachineSettingsForm(const CCloudMachine &comCloudMachine,
                                                       CForm &comResult,
-                                                      UINotificationCenter *pParent /* = 0 */)
+                                                      UINotificationCenter *pParent)
 {
     /* Acquire machine name first: */
@@ -581 +581 @@
 bool UICloudNetworkingStuff::applyCloudMachineSettingsForm(const CCloudMachine &comCloudMachine,
                                                            const CForm &comForm,
-                                                           UINotificationCenter *pParent /* = 0 */)
+                                                           UINotificationCenter *pParent)
 {
     /* Acquire machine name first: */

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICloudNetworkingStuff.h

@@ -118 +118 @@
                                               CStringArray &comNames,
                                               CStringArray &comIDs,
-                                              UINotificationCenter *pParent = 0);
+                                              UINotificationCenter *pParent);
     /** Acquires cloud source boot volumes of certain @a comCloudClient, using @a pParent to show messages according to. */
     SHARED_LIBRARY_STUFF bool listCloudSourceBootVolumes(const CCloudClient &comCloudClient,
                                                          CStringArray &comNames,
                                                          CStringArray &comIDs,
-                                                         UINotificationCenter *pParent = 0);
+                                                         UINotificationCenter *pParent);
     /** Acquires cloud instances of certain @a comCloudClient, using @a pParent to show messages according to. */
     SHARED_LIBRARY_STUFF bool listCloudInstances(const CCloudClient &comCloudClient,
                                                  CStringArray &comNames,
                                                  CStringArray &comIDs,
-                                                 UINotificationCenter *pParent = 0);
+                                                 UINotificationCenter *pParent);
     /** Acquires cloud source instances of certain @a comCloudClient, using @a pParent to show messages according to. */
     SHARED_LIBRARY_STUFF bool listCloudSourceInstances(const CCloudClient &comCloudClient,
                                                        CStringArray &comNames,
                                                        CStringArray &comIDs,
-                                                       UINotificationCenter *pParent = 0);
+                                                       UINotificationCenter *pParent);
 
     /** Acquires @a comCloudClient export description form as a @a comResult, using @a pParent to show messages according to. */
@@ -139 +139 @@
                                                     const CVirtualSystemDescription &comDescription,
                                                     CVirtualSystemDescriptionForm &comResult,
-                                                    UINotificationCenter *pParent = 0);
+                                                    UINotificationCenter *pParent);
     /** Acquires @a comCloudClient import description form as a @a comResult, using @a pParent to show messages according to. */
     SHARED_LIBRARY_STUFF bool importDescriptionForm(const CCloudClient &comCloudClient,
                                                     const CVirtualSystemDescription &comDescription,
                                                     CVirtualSystemDescriptionForm &comResult,
-                                                    UINotificationCenter *pParent = 0);
+                                                    UINotificationCenter *pParent);
 
     /** Acquires @a comCloudMachine ID as a @a uResult, using @a pParent to show messages according to. */
@@ -163 +163 @@
     SHARED_LIBRARY_STUFF bool cloudMachineSettingsForm(const CCloudMachine &comCloudMachine,
                                                        CForm &comResult,
-                                                       UINotificationCenter *pParent = 0);
+                                                       UINotificationCenter *pParent);
     /** Acquires @a comCloudMachine settings form as a @a comResult, using @a strErrorMessage to store messages to.
       * @note  Be aware, this is a blocking function, it will hang for a time of progress being executed. */
@@ -173 +173 @@
     SHARED_LIBRARY_STUFF bool applyCloudMachineSettingsForm(const CCloudMachine &comCloudMachine,
                                                             const CForm &comForm,
-                                                            UINotificationCenter *pParent = 0);
+                                                            UINotificationCenter *pParent);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsElement.cpp

@@ -666 +666 @@
             /* Apply form: */
             CForm comForm = pEditor->form();
-            applyCloudMachineSettingsForm(comCloudMachine, comForm);
+            applyCloudMachineSettingsForm(comCloudMachine, comForm, gpNotificationCenter);
         }