Changeset 92805 in vbox

Timestamp:

Dec 8, 2021 8:58:32 AM (3 years ago)

Author:

vboxsync

Message:

Disasm: Pack DISOPCODE in DIS_CORE_ONLY mode on x86 and amd64 to save a little space (~8KB).

Location:

trunk

Files:

• include/VBox/dis.h (modified) (2 diffs)
• src/VBox/Disassembler/DisasmInternal.h (modified) (1 diff)

trunk/include/VBox/dis.h

@@ -488 +488 @@
  * Opcode descriptor.
  */
+#if (defined(RT_ARCH_X86) || defined(RT_ARCH_AMD64)) && defined(DIS_CORE_ONLY)
+# pragma pack(1)
+#endif
 typedef struct DISOPCODE
 {
@@ -512 +515 @@
     /** Parameter \#4 info, @see grp_dis_opparam. */
     uint16_t    fParam4;
+#if (!defined(RT_ARCH_X86) && !defined(RT_ARCH_AMD64)) || !defined(DIS_CORE_ONLY)
     /** padding unused */
     uint16_t    uPadding;
+#endif
     /** Operand type flags, DISOPTYPE_XXX. */
     uint32_t    fOpType;
 } DISOPCODE;
+#if (defined(RT_ARCH_X86) || defined(RT_ARCH_AMD64)) && defined(DIS_CORE_ONLY)
+# pragma pack()
+#endif
 /** Pointer to const opcode. */
 typedef const struct DISOPCODE *PCDISOPCODE;

trunk/src/VBox/Disassembler/DisasmInternal.h

@@ -199 +199 @@
 # define OPVEX(pszOpcode, idxParse1, idxParse2, idxParse3, idxParse4, opcode, param1, param2, param3, param4, optype) \
     { pszOpcode, idxParse1, idxParse2, idxParse3, idxParse4, opcode, param1, param2, param3, param4, 0, optype | DISOPTYPE_SSE }
+#elif defined(RT_ARCH_X86) || defined(RT_ARCH_AMD64)
+# define OP(pszOpcode, idxParse1, idxParse2, idxParse3, opcode, param1, param2, param3, optype) \
+    { idxParse1, idxParse2, idxParse3, 0, opcode, param1, param2, param3, 0, optype }
+# define OPVEX(pszOpcode, idxParse1, idxParse2, idxParse3, idxParse4, opcode, param1, param2, param3, param4, optype) \
+    { idxParse1, idxParse2, idxParse3, idxParse4, opcode, param1, param2, param3, param4, optype | DISOPTYPE_SSE}
 #else
 # define OP(pszOpcode, idxParse1, idxParse2, idxParse3, opcode, param1, param2, param3, optype) \