Changeset 92876 in vbox for trunk/src/VBox/Main/include

Timestamp:

Dec 12, 2021 3:00:02 AM (3 years ago)

Author:

vboxsync

Message:

Main/GuestSessionImpl: Comment update, two todos. bugref:9320

File:

• trunk/src/VBox/Main/include/GuestSessionImpl.h (modified) (3 diffs)

trunk/src/VBox/Main/include/GuestSessionImpl.h

@@ -242 +242 @@
     enum SESSIONOBJECTTYPE
     {
+        /** @todo r=bird: The tradition is to start at = 1, leaving 0 for invalid or
+         * unused to catch uninitialized data.  You do not number the other enum values.
+         * The 32BIT_HACK is only needed for externally visible stuff that might be used
+         * by with different compiler options.
+         *
+         * As noted elsewhere already, SESSIONOBJECTTYPE_ANONYMOUS isn't used
+         * anywhere can be removed till such time as it is needed.  Try to not think
+         * too far ahead but if you do, please leave some more useful clues that
+         * "Anonymous object" about the intent. */
         /** Anonymous object. */
         SESSIONOBJECTTYPE_ANONYMOUS  = 0,
@@ -263 +272 @@
         /** The object type. */
         SESSIONOBJECTTYPE enmType;
-        /** Weak pointer to the object itself. */
+        /** Weak pointer to the object itself.
+         * Is NULL for SESSIONOBJECTTYPE_SESSION because GuestSession doesn't
+         * inherit from GuestObject. */
         GuestObject      *pObject;
     };
@@ -269 +280 @@
     /** Map containing all objects bound to a guest session.
      *  The key specifies the (global) context ID. */
-    typedef std::map <uint32_t, SessionObject> SessionObjects;
+    typedef std::map<uint32_t, SessionObject> SessionObjects;
 
 public: