Changeset 92981 in vbox for trunk

Timestamp:

Dec 16, 2021 1:40:00 PM (3 years ago)

Author:

vboxsync

Message:

Validation Kit/Guest Control: Do the TxS version check right before enabling verbose VBoxService logging to have an effective veto not enabling logging due to buggy (too old) TxS versions.

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -1639 +1639 @@
 
         # Query the TestExecService (TXS) version first to find out on what we run.
-        sTxsVer = self.oTstDrv.txsVer(oSession, oTxsSession, 30 * 100, fIgnoreErrors = True);
+        fGotTxsVer = self.oTstDrv.txsVer(oSession, oTxsSession, 30 * 100, fIgnoreErrors = True);
 
         # Whether to enable verbose logging for VBoxService.
         fEnableVerboseLogging = False;
-
-        # Old TXS versions had a bug which caused an infinite loop when executing stuff containing "$xxx",
-        # so check the version here first and skip enabling verbose logging if needed.
-        if sTxsVer:
-            fEnableVerboseLogging = True;
 
         # On Windows guests we always can enable verbose logging.
@@ -1656 +1651 @@
         if not self.oDebug.sImgPath:
             fEnableVerboseLogging = True;
+
+        # Old TxS versions had a bug which caused an infinite loop when executing stuff containing "$xxx",
+        # so check if we got the version here first and skip enabling verbose logging nonetheless if needed.
+        if not fGotTxsVer:
+            fEnableVerboseLogging = False;
 
         #
@@ -1703 +1703 @@
                 if not fRc:
                     return False;
+        else:
+            reporter.log('Skipping VBoxService enabling verbose logging (too old TxS service running)')
 
         #