Changeset 93026 in vbox for trunk/src

Timestamp:

Dec 19, 2021 10:50:51 AM (3 years ago)

Author:

vboxsync

Message:

IPRT/LocalIpc/posix: Fixed incorrect handle and state validation. Sigh^{2 bugref:10134}

File:

• trunk/src/VBox/Runtime/r3/posix/localipc-posix.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/posix/localipc-posix.cpp

@@ -277 +277 @@
 {
     PRTLOCALIPCSERVERINT pThis = (PRTLOCALIPCSERVERINT)hServer;
-    AssertReturn(pThis,                VERR_INVALID_PARAMETER);
-    AssertReturn(pThis->Name.sun_path, VERR_INVALID_PARAMETER);
+    AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
+    AssertReturn(pThis->u32Magic == RTLOCALIPCSERVER_MAGIC, VERR_INVALID_HANDLE);
+    AssertReturn(pThis->Name.sun_path[0] != '\0', VERR_INVALID_STATE);
 
     if (chown(pThis->Name.sun_path, -1, gid) == 0)
@@ -284 +285 @@
         if (chmod(pThis->Name.sun_path, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP) == 0)
         {
-            Log2Rel(("RTLocalIpcServerGrantGroupAccess: IPC socket %s access has been granted to group %RTgid\n",
+            LogRel2(("RTLocalIpcServerGrantGroupAccess: IPC socket %s access has been granted to group %RTgid\n",
                      pThis->Name.sun_path, gid));
             return VINF_SUCCESS;