Changeset 93135 in vbox for trunk/src/VBox

Timestamp:

Jan 6, 2022 10:02:15 PM (3 years ago)

Author:

vboxsync

Message:

iprt/strncmp.cpp: We try avoid comparing pointers because of signedness issues. Don't read pszStr1 twice, unless the compiler wants to. Fixed horrible style. (Hope it still works.)

File:

• trunk/src/VBox/Runtime/common/string/strncmp.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/strncmp.cpp

@@ -39 +39 @@
 #endif
 {
-    const char* fini = pszStr1+cb;
-    while (pszStr1 < fini)
+    while (cb-- > 0)
     {
-        int res=*pszStr1-*pszStr2;
-        if (res)
-            return res;
-        if (!*pszStr1)
-            return 0;
-        ++pszStr1; ++pszStr2;
+        char const ch1   = *pszStr1++;
+        int  const iDiff = ch1 - *pszStr2++;
+        if (iDiff)
+            return iDiff;
+        if (!ch1)
+            break;
     }
     return 0;