Changeset 93189 in vbox for trunk

Timestamp:

Jan 11, 2022 9:50:56 PM (3 years ago)

Author:

vboxsync

Message:

Main/Unattended: Move mStrProxy to the right group and added @todos about severly insufficient setter implementation. bugref:9469

Location:

trunk/src/VBox/Main

Files:

• include/UnattendedImpl.h (modified) (2 diffs)
• src-server/UnattendedImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/include/UnattendedImpl.h

@@ -122 +122 @@
     Utf8Str         mStrPostInstallCommand;
     Utf8Str         mStrExtraInstallKernelParameters;
+    Utf8Str         mStrProxy;
 
     bool            mfDoneDetectIsoOS;         /**< Set by detectIsoOS(), cleared by setIsoPath(). */
@@ -129 +130 @@
     RTCList<RTCString, RTCString *> mDetectedOSLanguages; /**< (only relevant for windows at the moment) */
     Utf8Str         mStrDetectedOSHints;
-    Utf8Str         mStrProxy;
     /** @} */
 

trunk/src/VBox/Main/src-server/UnattendedImpl.cpp

@@ -38 +38 @@
 #include <iprt/locale.h>
 #include <iprt/path.h>
+#include <iprt/vfs.h>
 
 using namespace std;
@@ -2582 +2583 @@
     {
         /* set default proxy */
+        /** @todo BUGBUG! implement this */
     }
     else if (aProxy.equalsIgnoreCase("none"))
     {
         /* clear proxy config */
-        mStrProxy = "";
+        mStrProxy.setNull();
     }
     else
     {
         /** @todo Parse and set proxy config into a schema map or something along those lines. */
+        /** @todo BUGBUG! implement this */
         // return E_NOTIMPL;
         mStrProxy = aProxy;
@@ -3048 +3051 @@
 }
 
-Utf8Str const & Unattended::i_getDetectedOSVersion()
+Utf8Str const &Unattended::i_getDetectedOSVersion()
 {
     Assert(isReadLockedOnCurrentThread());