VBox

Timestamp:

Jan 19, 2022 12:26:59 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10067: Make sure paused VM contents is updated on notification-center sliding animation.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationCenter.cpp

-              r93196
+              r93342
     m_iAnimatedValue = iValue;
     adjustGeometry();
+    emit sigAnimationStep();
+}
 …
     /* We do include open-button mask only if center is opened or animated to be: */
     QRegion region;
     if (!m_iAnimatedValue)
+    if (!animatedValue())
         region += QRect(m_pButtonOpen->mapToParent(QPoint(0, 0)), m_pButtonOpen->size());
     setMask(region);

r93115	r93342
55	55	/** Requests sliding state-machine to close overlay. */
56	56	void sigClose();
	57	/** Notifies listeners about animation step. */
	58	void sigAnimationStep();
57	59
58	60	public:

r93115	r93342
247	247	{
248	248	return frameBuffer() ? (double)(frameBuffer()->width()) / frameBuffer()->height() : 0;
	249	}
	250
	251	void UIMachineView::updateView()
	252	{
	253	viewport()->update();
249	254	}
250	255

-              r93115
+              r93342
     double aspectRatio() const;
+    /** Updates machine-view's viewport.
+      * @remarks Used to update in case of notification-center animation. */
+    void updateView();
     /** Updates console's display viewport.
       * @remarks Used to update 3D-service overlay viewport as well. */

-              r93115
+              r93342
     /* Update window-title: */
     updateAppearanceOf(UIVisualElement_WindowTitle);
+}
+void UIMachineWindow::sltHandleNotificationCenterAnimationStep()
+{
+    /* For certain machine states: */
+    const KMachineState enmState = uisession()->machineState();
+    switch (enmState)
+    {
+        /* Like those related to paused VM: */
+        case KMachineState_Paused:
+        case KMachineState_TeleportingPausedVM:
+        {
+            /* Update view's viewport, cause we have pause screenshot
+             * distorted with animation artifacts. */
+            machineView()->updateView();
+            break;
+        }
+        default:
+            break;
+    }
+}

-              r93115
+              r93342
     virtual void sltMachineStateChanged();
+    /** Handles notification-center animation steps. */
+    void sltHandleNotificationCenterAnimationStep();
 protected:

-              r93115
+              r93342
+{
     if (gpNotificationCenter && (m_uScreenId == 0))
+    {
         gpNotificationCenter->setParent(centralWidget());
+        disconnect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep, 0, 0);
+        connect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep,
+                this, &UIMachineWindowFullscreen::sltHandleNotificationCenterAnimationStep);
+    }
+}

-              r93115
+              r93342
+{
     if (gpNotificationCenter && (m_uScreenId == 0))
+    {
         gpNotificationCenter->setParent(centralWidget());
+        disconnect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep, 0, 0);
+        connect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep,
+                this, &UIMachineWindowNormal::sltHandleNotificationCenterAnimationStep);
+    }
+}

-              r93115
+              r93342
+{
     if (gpNotificationCenter && (m_uScreenId == 0))
+    {
         gpNotificationCenter->setParent(centralWidget());
+        disconnect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep, 0, 0);
+        connect(gpNotificationCenter, &UINotificationCenter::sigAnimationStep,
+                this, &UIMachineWindowScale::sltHandleNotificationCenterAnimationStep);
+    }
+}

Note: See TracChangeset for help on using the changeset viewer.