Changeset 93367 in vbox for trunk/src/VBox

Timestamp:

Jan 20, 2022 5:18:22 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: Runtime UI / Machine-view: Fix for pause screenshot painting event, clipping should be used instead of manual rectangle calculation; This should also fix repainting artifacts for the notification-center being animated over the pause screenshot.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineView.cpp

@@ -1697 +1697 @@
     if (!pausePixmap().isNull())
     {
-        /* We have a snapshot for the paused state: */
-        QRect rect = pPaintEvent->rect().intersected(viewport()->rect());
+        /* Create viewport painter: */
         QPainter painter(viewport());
+        /* Avoid painting more than necessary: */
+        painter.setClipRect(pPaintEvent->rect());
+        /* Can be NULL when the event arrive during COM cleanup: */
+        UIFrameBuffer *pFramebuffer = frameBuffer(); 
         /* Take the scale-factor into account: */
-        UIFrameBuffer * const pFramebuffer = frameBuffer(); /* Can be NULL when the event arrive during COM cleanup. */
         if (  pFramebuffer
             ? pFramebuffer->scaleFactor() == 1.0 && !pFramebuffer->scaledSize().isValid()
             : pausePixmapScaled().isNull())
-            painter.drawPixmap(rect.topLeft(), pausePixmap());
+            painter.drawPixmap(viewport()->rect().topLeft(), pausePixmap());
         else
-            painter.drawPixmap(rect.topLeft(), pausePixmapScaled());
+            painter.drawPixmap(viewport()->rect().topLeft(), pausePixmapScaled());
 #ifdef VBOX_WS_MAC
         /* Update the dock icon: */