Changeset 93392 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Jan 21, 2022 11:07:13 AM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

149488

Message:

VMM/CFGM: Must thoroughly wipe password memory before freeing it. bugref:9469

File:

• trunk/src/VBox/VMM/VMMR3/CFGM.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/CFGM.cpp

@@ -2115 +2115 @@
                 break;
 
+            case CFGMVALUETYPE_PASSWORD:
+                RTMemWipeThoroughly(pLeaf->Value.String.psz, pLeaf->Value.String.cb, 10);
+                RT_FALL_THROUGH();
             case CFGMVALUETYPE_STRING:
-            case CFGMVALUETYPE_PASSWORD:
                 cfgmR3StrFree(pVM, pLeaf->Value.String.psz);
                 pLeaf->Value.String.psz = NULL;
@@ -2414 +2416 @@
             }
             else
+            {
+                RTMemWipeThoroughly(pszStringCopy, cchString, 10);
                 cfgmR3StrFree(pNode->pVM, pszStringCopy);
+            }
         }
         else