Changeset 93400 in vbox for trunk

Timestamp:

Jan 21, 2022 4:19:23 PM (3 years ago)

Author:

vboxsync

Message:

Additions: Linux: DRM: forgotten bits for display-helper-generic, bugref:10134.

Fixed code checker warning, updated logging (no need to specify log
prefix anymore), coding style.

File:

• trunk/src/VBox/Additions/x11/VBoxClient/display-helper-generic.cpp (modified) (13 diffs)

trunk/src/VBox/Additions/x11/VBoxClient/display-helper-generic.cpp

@@ -40 +40 @@
 #include <X11/Xlibint.h>
 
-/* A log prefix which is specific for this source file. */
-#define VBCL_HLP_LOG_PREFIX         "display-helper-generic "
-
 /** Name of Display Change Monitor thread. */
 #define VBCL_HLP_DCM_THREAD_NAME    "dcm-task"
 
 /** Display Change Monitor thread. */
-static RTTHREAD vbclHlpGenericDcmThread = NIL_RTTHREAD;
+static RTTHREAD g_vbclHlpGenericDcmThread = NIL_RTTHREAD;
 
 /** Global flag which is triggered when service requested to shutdown. */
@@ -166 +163 @@
 static void vbcl_hlp_generic_process_display_change_event(Display *pDisplay)
 {
-    int iCount, idxDisplay = 0;
+    int iCount;
+    uint32_t idxDisplay = 0;
     XRRMonitorInfo *pMonitorsInfo = XRRGetMonitors(pDisplay, DefaultRootWindow(pDisplay), true, &iCount);
-    if (pMonitorsInfo && iCount && iCount < VBOX_DRMIPC_MONITORS_MAX)
+    if (pMonitorsInfo && iCount > 0 && iCount < VBOX_DRMIPC_MONITORS_MAX)
     {
         int rc;
@@ -182 +180 @@
             if (RT_FAILURE(rc))
             {
-                VBClLogError(VBCL_HLP_LOG_PREFIX "unable to fill monitors info list, rc=%Rrc\n", rc);
+                VBClLogError("unable to fill monitors info list, rc=%Rrc\n", rc);
                 break;
             }
@@ -192 +190 @@
             char *pszMonitorName = XGetAtomName(pDisplay, pIter->pMonitorInfo->name);
 
-            VBClLogVerbose(1, VBCL_HLP_LOG_PREFIX "reporting monitor %s offset: (%d, %d)\n",
+            VBClLogVerbose(1, "reporting monitor %s offset: (%d, %d)\n",
                         pszMonitorName, pIter->pMonitorInfo->x, pIter->pMonitorInfo->y);
 
@@ -208 +206 @@
         if (g_pfnDisplayOffsetChangeCb)
         {
-            rc = g_pfnDisplayOffsetChangeCb(iCount, aDisplayOffsets);
+            rc = g_pfnDisplayOffsetChangeCb(idxDisplay, aDisplayOffsets);
             if (RT_FAILURE(rc))
-                VBClLogError(VBCL_HLP_LOG_PREFIX "unable to notify subscriber about monitors info change, rc=%Rrc\n", rc);
+                VBClLogError("unable to notify subscriber about monitors info change, rc=%Rrc\n", rc);
         }
     }
     else
-        VBClLogError(VBCL_HLP_LOG_PREFIX "cannot get monitors info\n");
+        VBClLogError("cannot get monitors info\n");
 }
 
@@ -269 +267 @@
         else
         {
-            VBClLogError(VBCL_HLP_LOG_PREFIX "dcm monitor cannot find XRandr 1.3+ extension\n");
+            VBClLogError("dcm monitor cannot find XRandr 1.3+ extension\n");
             rc = VERR_NOT_AVAILABLE;
         }
@@ -277 +275 @@
     else
     {
-        VBClLogError(VBCL_HLP_LOG_PREFIX "dcm monitor cannot open X Display\n");
+        VBClLogError("dcm monitor cannot open X Display\n");
         rc = VERR_NOT_AVAILABLE;
     }
@@ -286 +284 @@
 }
 
-RTDECL(int) vbcl_hlp_generic_start_display_change_monitor()
+static void vbcl_hlp_generic_start_display_change_monitor()
 {
     int rc;
@@ -294 +292 @@
     {
         /* Start thread which will monitor display change events. */
-        rc = RTThreadCreate(&vbclHlpGenericDcmThread, vbcl_hlp_generic_display_change_event_monitor_worker, (void *)NULL, 0,
+        rc = RTThreadCreate(&g_vbclHlpGenericDcmThread, vbcl_hlp_generic_display_change_event_monitor_worker, (void *)NULL, 0,
                             RTTHREADTYPE_DEFAULT, RTTHREADFLAGS_WAITABLE, VBCL_HLP_DCM_THREAD_NAME);
         if (RT_SUCCESS(rc))
         {
-            rc = RTThreadUserWait(vbclHlpGenericDcmThread, RT_MS_5SEC);
+            rc = RTThreadUserWait(g_vbclHlpGenericDcmThread, RT_MS_5SEC);
         }
         else
-            vbclHlpGenericDcmThread = NIL_RTTHREAD;
-
-        VBClLogInfo(VBCL_HLP_LOG_PREFIX "attempt to start display change monitor thread, rc=%Rrc\n", rc);
+            g_vbclHlpGenericDcmThread = NIL_RTTHREAD;
+
+        VBClLogInfo("attempt to start display change monitor thread, rc=%Rrc\n", rc);
 
     }
     else
-        VBClLogInfo(VBCL_HLP_LOG_PREFIX "libXrandr not available, will not monitor display change events, rc=%Rrc\n", rc);
-
-    return rc;
+        VBClLogInfo("libXrandr not available, will not monitor display change events, rc=%Rrc\n", rc);
 }
 
@@ -331 +327 @@
             {
                 XRRSetOutputPrimary(pDisplay, DefaultRootWindow(pDisplay), pScreenResources->outputs[idDisplay]);
-                VBClLogInfo(VBCL_HLP_LOG_PREFIX "display %u has been set as primary\n", idDisplay);
+                VBClLogInfo("display %u has been set as primary\n", idDisplay);
                 rc = VINF_SUCCESS;
             }
             else
-                VBClLogError(VBCL_HLP_LOG_PREFIX "cannot set display %u as primary: index out of range\n", idDisplay);
+                VBClLogError("cannot set display %u as primary: index out of range\n", idDisplay);
 
             XRRFreeScreenResources(pScreenResources);
         }
         else
-            VBClLogError(VBCL_HLP_LOG_PREFIX "cannot set display %u as primary: libXrandr can not get screen resources\n", idDisplay);
+            VBClLogError("cannot set display %u as primary: libXrandr can not get screen resources\n", idDisplay);
 
         XCloseDisplay(pDisplay);
     }
     else
-        VBClLogError(VBCL_HLP_LOG_PREFIX "cannot set display %u as primary: cannot connect to X11\n", idDisplay);
+        VBClLogError("cannot set display %u as primary: cannot connect to X11\n", idDisplay);
 
     return rc;
@@ -368 +364 @@
     ASMAtomicWriteBool(&g_fShutdown, false);
 
-    /* Attempt to start display change events monitor. Ignore rc,
-     * error will be printed inside function anyway. */
-    (void)vbcl_hlp_generic_start_display_change_monitor();
+    /* Attempt to start display change events monitor. */
+    vbcl_hlp_generic_start_display_change_monitor();
 
     /* Always return positive status for generic (fallback, last resort) helper. */
@@ -383 +378 @@
     int rc = VINF_SUCCESS;
 
-    if (vbclHlpGenericDcmThread != NIL_RTTHREAD)
+    if (g_vbclHlpGenericDcmThread != NIL_RTTHREAD)
     {
         /* Signal thread we are going to shutdown. */
@@ -389 +384 @@
 
         /* Wait for thread to terminate gracefully. */
-        rc = RTThreadWait(vbclHlpGenericDcmThread, RT_MS_5SEC, NULL);
+        rc = RTThreadWait(g_vbclHlpGenericDcmThread, RT_MS_5SEC, NULL);
     }