Changeset 93479 in vbox for trunk/src

Timestamp:

Jan 28, 2022 3:04:07 PM (3 years ago)

Author:

vboxsync

Message:

VBoxNetAdpCtl: (bugref:8093) Added unicast and loopback checks

File:

• trunk/src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp (modified) (3 diffs)

trunk/src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp

@@ -333 +333 @@
 void AddressIPv4::deriveBroadcast(PCRTNETADDRIPV4 pcAddress, int iPrefix)
 {
-    /* Note: the address is big-endian. */
     RTNETADDRIPV4 mask, broadcast;
     int rc = RTNetPrefixToMaskIPv4(iPrefix, &mask);
@@ -773 +772 @@
         virtual const char *defaultNetwork() { return "192.168.56.1/21"; }; /* Matches defaults in VBox/Main/include/netif.h, see @bugref{10077}. */
 
+    protected:
+        bool isValidUnicastAddress(PCRTNETADDRIPV4 address);
+
     private:
         RTNETADDRIPV4 m_address;
@@ -794 +796 @@
         rc = RTNetStrToIPv4Cidr(pcszIpAddress, &m_address, &m_prefix);
 #endif
-    m_fValid = RT_SUCCESS(rc);
+    m_fValid = RT_SUCCESS(rc) && isValidUnicastAddress(&m_address);
+}
+
+bool NetworkAddressIPv4::isValidUnicastAddress(PCRTNETADDRIPV4 address)
+{
+    /* Multicast addresses are not allowed. */
+    if ((address->au8[0] & 0xF0) == 0xE0)
+        return false;
+
+    /* Broadcast address is not allowed. */
+    if (address->au32[0] == 0xFFFFFFFF) /* Endianess does not matter in this particual case. */
+        return false;
+
+    /* Loopback addresses are not allowed. */
+    if ((address->au8[0] & 0xFF) == 0x7F)
+        return false;
+
+    return true;
 }