Changeset 93557 in vbox for trunk/src/VBox

Timestamp:

Feb 2, 2022 11:15:11 PM (3 years ago)

Author:

vboxsync

Message:

VMM: Enabled checks for ASMMemIsZeroPage and ASMMemZeroPage, addressing 4 instances.

Location:

trunk/src/VBox/VMM

Files:

• .scm-settings (modified) (1 diff)
• VMMR0/HMR0.cpp (modified) (2 diffs)
• VMMR0/HMSVMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/.scm-settings

@@ -43 +43 @@
 /testcase/tstVMStructSize.cpp:     --no-page-restrictions
 
+# Forbit ASMMemIsZeroPage and ASMMemZeroPage.
+/*.cpp: --no-ASMMemPage-use
+/*.h:   --no-ASMMemPage-use
+# Except in the pool where more care/work is needed.
+/VMMR3/PGMPool.cpp:     --unrestricted-ASMMemPage-use
+/VMMAll/PGMAllPool.cpp: --unrestricted-ASMMemPage-use
+

trunk/src/VBox/VMM/VMMR0/HMR0.cpp

@@ -419 +419 @@
             void          *pvScatchPage      = RTR0MemObjAddress(hScatchMemObj);
             RTHCPHYS const HCPhysScratchPage = RTR0MemObjGetPagePhysAddr(hScatchMemObj, 0);
-            ASMMemZeroPage(pvScatchPage);
+            RT_BZERO(pvScatchPage, HOST_PAGE_SIZE);
 
             /* Set revision dword at the beginning of the VMXON structure. */
@@ -914 +914 @@
                 g_aHmCpuInfo[i].pvMemObj     = RTR0MemObjAddress(g_aHmCpuInfo[i].hMemObj);
                 AssertPtr(g_aHmCpuInfo[i].pvMemObj);
-                ASMMemZeroPage(g_aHmCpuInfo[i].pvMemObj);
+                RT_BZERO(g_aHmCpuInfo[i].pvMemObj, HOST_PAGE_SIZE);
 
 #ifdef VBOX_WITH_NESTED_HWVIRT_SVM

trunk/src/VBox/VMM/VMMR0/HMSVMR0.cpp

@@ -808 +808 @@
         pVCpu->hmr0.s.svm.HCPhysVmcbHost    = RTR0MemObjGetPagePhysAddr(pVCpu->hmr0.s.svm.hMemObjVmcbHost, 0 /* iPage */);
         Assert(pVCpu->hmr0.s.svm.HCPhysVmcbHost < _4G);
-        ASMMemZeroPage(pvVmcbHost);
+        RT_BZERO(pvVmcbHost, HOST_PAGE_SIZE);
 
         /*
@@ -821 +821 @@
         pVCpu->hmr0.s.svm.HCPhysVmcb        = RTR0MemObjGetPagePhysAddr(pVCpu->hmr0.s.svm.hMemObjVmcb, 0 /* iPage */);
         Assert(pVCpu->hmr0.s.svm.HCPhysVmcb < _4G);
-        ASMMemZeroPage(pVCpu->hmr0.s.svm.pVmcb);
+        RT_BZERO(pVCpu->hmr0.s.svm.pVmcb, HOST_PAGE_SIZE);
 
         /*