Changeset 93667 in vbox

Timestamp:

Feb 9, 2022 2:33:25 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

149831

Message:

VMM/PGM: Made PGMR3HandlerPhysicalTypeRegister a bit clearer on hType use. bugref:10094

File:

• trunk/src/VBox/VMM/VMMR3/PGMHandler.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/PGMHandler.cpp

@@ -107 +107 @@
      * Do the allocating.
      */
-    PGMPHYSHANDLERTYPE hType = pVM->pgm.s.cPhysHandlerTypes;
-    AssertLogRelReturn(hType < RT_ELEMENTS(pVM->pgm.s.aPhysHandlerTypes), VERR_OUT_OF_RESOURCES);
-    PPGMPHYSHANDLERTYPEINTR3 const pType = &pVM->pgm.s.aPhysHandlerTypes[hType];
+    uint32_t const idxType = pVM->pgm.s.cPhysHandlerTypes;
+    AssertLogRelReturn(idxType < RT_ELEMENTS(pVM->pgm.s.aPhysHandlerTypes), VERR_OUT_OF_RESOURCES);
+    PPGMPHYSHANDLERTYPEINTR3 const pType = &pVM->pgm.s.aPhysHandlerTypes[idxType];
     AssertReturn(pType->enmKind == PGMPHYSHANDLERKIND_INVALID, VERR_PGM_HANDLER_IPE_1);
-    pVM->pgm.s.cPhysHandlerTypes++;
+    pVM->pgm.s.cPhysHandlerTypes = idxType + 1;
 
     pType->enmKind          = enmKind;
@@ -122 +122 @@
 
     *phType = pType->hType;
-    LogFlow(("PGMR3HandlerPhysicalTypeRegisterEx: hType=%#x: enmKind=%d fFlags=%#x pfnHandler=%p pszDesc=%s\n",
-             hType, enmKind, fFlags, pfnHandler, pszDesc));
+    LogFlow(("PGMR3HandlerPhysicalTypeRegisterEx: hType=%#RX64/%#x: enmKind=%d fFlags=%#x pfnHandler=%p pszDesc=%s\n",
+             pType->hType, idxType, enmKind, fFlags, pfnHandler, pszDesc));
     return VINF_SUCCESS;
 }