Changeset 93731 in vbox for trunk/src/VBox

Timestamp:

Feb 14, 2022 3:11:57 PM (3 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10165. Disabling the guest control tab of the 'session information' dialog when the vm is paused.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information

Files:

• UIVMInformationDialog.cpp (modified) (9 diffs)
• UIVMInformationDialog.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIVMInformationDialog.cpp

@@ -38 +38 @@
 #include "UIVMActivityMonitor.h"
 #include "UISession.h"
+#include "UIVirtualBoxEventHandler.h"
 #include "UIVMInformationDialog.h"
 #include "VBoxUtils.h"
@@ -64 +65 @@
     , m_iGeometrySaveTimerId(-1)
 {
+    if (m_pMachineWindow && !m_pMachineWindow->console().isNull())
+    {
+        CMachine comMachine = m_pMachineWindow->console().GetMachine();
+        m_uMachineId = comMachine.GetId();
+    }
     /* Prepare: */
     prepare();
+    connect(gVBoxEvents, &UIVirtualBoxEventHandler::sigMachineStateChange,
+            this, &UIVMInformationDialog::sltMachineStateChange);
 }
 
@@ -83 +91 @@
 
     /* Translate tabs: */
-    m_pTabWidget->setTabText(0, tr("Configuration &Details"));
-    m_pTabWidget->setTabText(1, tr("&Runtime Information"));
-    m_pTabWidget->setTabText(2, tr("VM &Activity"));
+    m_pTabWidget->setTabText(Tabs_ConfigurationDetails, tr("Configuration &Details"));
+    m_pTabWidget->setTabText(Tabs_RuntimeInformation, tr("&Runtime Information"));
+    m_pTabWidget->setTabText(Tabs_ActivityMonitor, tr("VM &Activity"));
     m_pTabWidget->setTabText(3, tr("&Guest Control"));
 
@@ -147 +155 @@
 }
 
+void UIVMInformationDialog::sltMachineStateChange(const QUuid &uMachineId, const KMachineState state)
+{
+    if (m_uMachineId != uMachineId)
+        return;
+    QWidget *pWidget = m_tabs.value(Tabs_GuestControl);
+    if (!pWidget)
+        return;
+    pWidget->setEnabled(state == KMachineState_Running);
+}
+
 void UIVMInformationDialog::saveDialogGeometry()
 {
@@ -205 +223 @@
     {
         /* Prepare tab-widget: */
-        m_pTabWidget->setTabIcon(0, UIIconPool::iconSet(":/session_info_details_16px.png"));
-        m_pTabWidget->setTabIcon(1, UIIconPool::iconSet(":/session_info_runtime_16px.png"));
+        m_pTabWidget->setTabIcon(Tabs_ConfigurationDetails, UIIconPool::iconSet(":/session_info_details_16px.png"));
+        m_pTabWidget->setTabIcon(Tabs_RuntimeInformation, UIIconPool::iconSet(":/session_info_runtime_16px.png"));
 
         /* Create Configuration Details tab: */
@@ -213 +231 @@
         if (pInformationConfigurationWidget)
         {
-            m_tabs.insert(0, pInformationConfigurationWidget);
-            m_pTabWidget->addTab(m_tabs.value(0), QString());
+            m_tabs.insert(Tabs_ConfigurationDetails, pInformationConfigurationWidget);
+            m_pTabWidget->addTab(m_tabs.value(Tabs_ConfigurationDetails), QString());
         }
 
@@ -222 +240 @@
         if (pInformationRuntimeWidget)
         {
-            m_tabs.insert(1, pInformationRuntimeWidget);
-            m_pTabWidget->addTab(m_tabs.value(1), QString());
+            m_tabs.insert(Tabs_RuntimeInformation, pInformationRuntimeWidget);
+            m_pTabWidget->addTab(m_tabs.value(Tabs_RuntimeInformation), QString());
         }
 
@@ -233 +251 @@
             connect(m_pMachineWindow->uisession(), &UISession::sigAdditionsStateChange,
                     pVMActivityMonitorWidget, &UIVMActivityMonitor::sltGuestAdditionsStateChange);
-            m_tabs.insert(2, pVMActivityMonitorWidget);
-            m_pTabWidget->addTab(m_tabs.value(2), QString());
+            m_tabs.insert(Tabs_ActivityMonitor, pVMActivityMonitorWidget);
+            m_pTabWidget->addTab(m_tabs.value(Tabs_ActivityMonitor), QString());
         }
 
@@ -254 +272 @@
         }
 
-        /* Set Runtime Information tab as default: */
-        m_pTabWidget->setCurrentIndex(2);
+        m_pTabWidget->setCurrentIndex(Tabs_ActivityMonitor);
 
         /* Assign tab-widget page change handler: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/information/UIVMInformationDialog.h

@@ -74 +74 @@
     /** Handles tab-widget page change. */
     void sltHandlePageChanged(int iIndex);
+    void sltMachineStateChange(const QUuid &uMachineId, const KMachineState state);
 
 private:
-
+    enum Tabs
+    {
+        Tabs_ConfigurationDetails = 0,
+        Tabs_RuntimeInformation,
+        Tabs_ActivityMonitor,
+        Tabs_GuestControl
+    };
     /** Prepares all. */
     void prepare();
@@ -105 +112 @@
     bool m_fCloseEmitted;
     int m_iGeometrySaveTimerId;
+    QUuid m_uMachineId;
 };