Changeset 93739 in vbox for trunk/src/VBox

Timestamp:

Feb 14, 2022 7:14:39 PM (3 years ago)

Author:

vboxsync

Message:

Devices/DevVGA-SVGA3d-win-dx: Fix possible call of RTMemFree(*ppvData) with uninitialized *ppvData

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win-dx.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win-dx.cpp

@@ -5087 +5087 @@
         return VERR_NO_MEMORY;
 
+    *ppvData = pvData;
+    *pcbData = Bytes;
+
     int rc = dxStagingBufferRealloc(pDevice, Bytes);
     if (RT_SUCCESS(rc))
@@ -5124 +5127 @@
     }
 
-    if (RT_SUCCESS(rc))
-    {
-        *ppvData = pvData;
-        *pcbData = Bytes;
-    }
-    else
+    if (RT_FAILURE(rc))
     {
         RTMemFree(*ppvData);