Changeset 93840 in vbox

Timestamp:

Feb 18, 2022 2:10:50 PM (3 years ago)

Author:

vboxsync

Message:

DevVGA: Changing blink enable or underline location needs to trigger a full screen redraw.

Location:

trunk/src/VBox/Devices/Graphics

Files:

• DevVGA.cpp (modified) (2 diffs)
• DevVGA.h (modified) (1 diff)

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -1742 +1742 @@
         full_update = true;
     }
+
+    /* Underline position */
+    uline_pos  = pThis->cr[0x14] & 0x1f;
+    if (uline_pos != pThis->last_uline) {
+        pThis->last_uline = uline_pos;
+        full_update = true;
+    }
+
+    blink_enabled = !!(pThis->ar[0x10] & 0x08); /* Attribute controller blink enable. */
+    if (blink_enabled != pThis->last_blink) {
+        pThis->last_blink = blink_enabled;
+        full_update = true;
+    }
+
     full_update |= vgaR3UpdateBasicParams(pThis, pThisCC);
 
@@ -1835 +1849 @@
         cur_blink_flip = true;
     }
-    blink_enabled = !!(pThis->ar[0x10] & 0x08); /* Attribute controller blink enable. */
-
-    /* Underline position */
-    uline_pos  = pThis->cr[0x14] & 0x1f;
 
     for(cy = 0; cy < (height - dscan); cy = cy + (1 << dscan)) {

trunk/src/VBox/Devices/Graphics/DevVGA.h

@@ -321 +321 @@
     uint32_t start_addr;
     uint32_t plane_updated;
-    uint8_t last_cw, last_ch, padding2[2];
+    uint8_t last_cw, last_ch;
+    uint8_t last_uline;                                                 \
+    bool last_blink;                                                    \
     uint32_t last_width, last_height; /* in chars or pixels */
     uint32_t last_scr_width, last_scr_height; /* in pixels */