Changeset 93915 in vbox for trunk/src/VBox/Devices/USB

Timestamp:

Feb 24, 2022 12:30:54 PM (3 years ago)

Author:

vboxsync

Message:

Devices/USB: Convert the HCI emulations to call into the roothub using the devices port instead of using the VUSBIDEVICE interface directly. This will avoid races when devices will get detached unexpectedly while being in use. Also move the device re-attach logic after a saved state operation down to the roothub in order to avoid code duplication, bugref:10196 [doxygen fixes]

File:

• trunk/src/VBox/Devices/USB/DrvVUSBRootHub.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/USB/DrvVUSBRootHub.cpp

@@ -1132 +1132 @@
 
 
-/** @interface_method_impl{VUSBIROOTHUBCONNECTOR,pfnIsSavedStateSupported} */
+/** @interface_method_impl{VUSBIROOTHUBCONNECTOR,pfnDevIsSavedStateSupported} */
 static DECLCALLBACK(bool) vusbR3RhDevIsSavedStateSupported(PVUSBIROOTHUBCONNECTOR pInterface, uint32_t uPort)
 {
@@ -1191 +1191 @@
 
 /**
- * @callback_method_impl{FNSSMDEVSAVEPREP, All URBs needs to be canceled.}
+ * @callback_method_impl{FNSSMDRVSAVEPREP, All URBs needs to be canceled.}
  */
 static DECLCALLBACK(int) vusbR3RhSavePrep(PPDMDRVINS pDrvIns, PSSMHANDLE pSSM)
@@ -1243 +1243 @@
 
 /**
- * @callback_method_impl{FNSSMDEVSAVEDONE}
+ * @callback_method_impl{FNSSMDRVSAVEDONE}
  */
 static DECLCALLBACK(int) vusbR3RhSaveDone(PPDMDRVINS pDrvIns, PSSMHANDLE pSSM)
@@ -1279 +1279 @@
 
 /**
- * @callback_method_impl{FNSSMDEVLOADPREP, This must detach the devices
+ * @callback_method_impl{FNSSMDRVLOADPREP, This must detach the devices
  * currently attached and save them for reconnect after the state load has been
  * completed.}
@@ -1357 +1357 @@
 
 /**
- * @callback_method_impl{FNSSMDEVLOADDONE}
+ * @callback_method_impl{FNSSMDRVLOADDONE}
  */
 static DECLCALLBACK(int) vusbR3RhLoadDone(PPDMDRVINS pDrvIns, PSSMHANDLE pSSM)