Changeset 94084 in vbox for trunk/src/VBox/Main

Timestamp:

Mar 3, 2022 10:22:30 PM (3 years ago)

Author:

vboxsync

Message:

Main/Machine: IMachine::mountMedium inadvertently works without
a session. bugref:5490

IMachine::mountMedium() and IMachine::unmountMedium() need to detect and
reject attempts to use an immutable Machine object rather than a mutable
session object from ISession::machine(). This is done by including a
call to i_checkStateDependency(MutableOrRunningStateDep) as is done
elsewhere for IMachine methods that modify a VM's configuration or
settings.

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -4516 +4516 @@
                                   this->lockHandle(),
                                   &mParent->i_getMediaTreeLockHandle() COMMA_LOCKVAL_SRC_POS);
+
+    HRESULT hrc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(hrc)) return hrc;
 
     ComObjPtr<MediumAttachment> pAttach = i_findAttachment(*mMediumAttachments.data(),