Changeset 94092 in vbox for trunk/src/VBox/Main

Timestamp:

Mar 4, 2022 10:09:02 PM (3 years ago)

Author:

vboxsync

Message:

Main/Machine: Additional IMachine methods need machine state check
enforcement. bugref:5490

All IMachine methods and attribute setters which modify a VM's settings
or configuration need to detect and reject attempts to use an immutable
Machine object rather than a mutable session object from
ISession::machine(). The following routines: setCPUExecutionCap(),
setMemoryBalloonSize(), setPageFusionEnabled(), setClipboardMode(),
setClipboardFileTransfersEnabled(), setDnDMode(), hotPlugCPU(), and
hotUnplugCPU() need updating to include a call to i_checkStateDependency()
to enforce this.

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (8 diffs)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -1600 +1600 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
+
     alock.release();
     rc = i_onCPUExecutionCapChange(aCPUExecutionCap);
@@ -1812 +1815 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
+    HRESULT rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
+
     i_setModified(IsModified_MachineData);
     mHWData.backup();
@@ -1835 +1841 @@
 #ifdef VBOX_WITH_PAGE_SHARING
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    HRESULT rc = i_checkStateDependency(MutableStateDep);
+    if (FAILED(rc)) return rc;
 
     /** @todo must support changes for running vms and keep this in sync with IGuest. */
@@ -2651 +2660 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
+
     alock.release();
     rc = i_onClipboardModeChange(aClipboardMode);
@@ -2682 +2694 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
+
     alock.release();
     rc = i_onClipboardFileTransferModeChange(aEnabled);
@@ -2712 +2727 @@
 
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
 
     alock.release();
@@ -6410 +6428 @@
         return setError(VBOX_E_OBJECT_IN_USE, tr("CPU %lu is already attached"), aCpu);
 
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
+
     alock.release();
     rc = i_onCPUChange(aCpu, false);
@@ -6446 +6467 @@
     if (aCpu == 0)
         return setError(E_INVALIDARG, tr("It is not possible to detach CPU 0"));
+
+    rc = i_checkStateDependency(MutableOrRunningStateDep);
+    if (FAILED(rc)) return rc;
 
     alock.release();