Changeset 94128 in vbox for trunk/src/VBox/ValidationKit/testmanager

Timestamp:

Mar 8, 2022 2:50:04 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

150377

Message:

TestManager: Use the fHasReasons parameter in _fetchResultTreeNodeExtras(). pylint 2.9.6 adjustments.

File:

• trunk/src/VBox/ValidationKit/testmanager/core/testresults.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/testresults.py

@@ -2155 +2155 @@
         self._fetchResultTreeNodeExtras(oRoot, aoRow[-4], aoRow[-3], aoRow[-2], aoRow[-1]);
 
-        # The chilren (if any).
+        # The children (if any).
         dLookup = { oRoot.idTestResult: oRoot };
         oParent = oRoot;
@@ -2233 +2233 @@
                 oCurNode.aoFiles.append(TestResultFileDataEx().initFromDbRow(aoRow));
 
-        if fHasReasons or True:
+        if fHasReasons:
             if self.oFailureReasonLogic is None:
                 self.oFailureReasonLogic = FailureReasonLogic(self._oDb);
@@ -2539 +2539 @@
                           , ( oTestResult.idTestResult, ));
         cMinErrors = self._oDb.fetchOne()[0] + oTestResult.cErrors;
-        if cErrors < cMinErrors:
-            cErrors = cMinErrors;
+        cErrors    = max(cErrors, cMinErrors);
         if cErrors > 0 and enmStatus == TestResultData.ksTestStatus_Success:
             enmStatus = TestResultData.ksTestStatus_Failure