Changeset 94244 in vbox

Timestamp:

Mar 15, 2022 11:59:37 AM (3 years ago)

Author:

vboxsync

Message:

Audio/Validation Kit: More code to handle host process execution in a separate thread to not block required event processing [build fix, forgot to commit stuff]. bugref:10008

Location:

trunk/src/VBox/ValidationKit

Files:

• common/utils.py (modified) (3 diffs)
• tests/audio/tdAudioTest.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/common/utils.py

@@ -675 +675 @@
     return subprocess.Popen(*aPositionalArgs, **dKeywordArgs);  # pylint: disable=consider-using-with
 
+def processStart(*aPositionalArgs, **dKeywordArgs):
+    """
+    Wrapper around subprocess.Popen to deal with its absence in older
+    python versions.
+    Returns process object on success which can be worked on.
+    """
+    _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
+    return processPopenSafe(*aPositionalArgs, **dKeywordArgs);
+
 def processCall(*aPositionalArgs, **dKeywordArgs):
     """
@@ -683 +692 @@
     assert dKeywordArgs.get('stdout') is None;
     assert dKeywordArgs.get('stderr') is None;
-    _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
-    oProcess = processPopenSafe(*aPositionalArgs, **dKeywordArgs);
+    oProcess = processStart(*aPositionalArgs, **dKeywordArgs);
     return oProcess.wait();
 
@@ -797 +805 @@
     return None;
 
+
+def sudoProcessStart(*aPositionalArgs, **dKeywordArgs):
+    """
+    sudo (or similar) + subprocess.Popen,
+    returning the process object on success.
+    """
+    _processFixPythonInterpreter(aPositionalArgs, dKeywordArgs);
+    _sudoFixArguments(aPositionalArgs, dKeywordArgs);
+    return processStart(*aPositionalArgs, **dKeywordArgs);
 
 def sudoProcessCall(*aPositionalArgs, **dKeywordArgs):

trunk/src/VBox/ValidationKit/tests/audio/tdAudioTest.py

@@ -315 +315 @@
 
             iPid = oProcess.pid;
-            self.pidFileAdd(iPid);
+            self.pidFileAdd(sWhat, iPid);
 
             iRc  = 0;
@@ -391 +391 @@
             reporter.log2('Thread returned exit code for "%s": %d' % (sWhat, self.iThreadHstProcRc));
         except:
-            self.logXcpt('Starting thread for "%s" failed' % (sWhat,));
+            reporter.logXcpt('Starting thread for "%s" failed' % (sWhat,));
 
         return self.iThreadHstProcRc == 0;