Changeset 94249 in vbox for trunk/src/VBox/Main

Timestamp:

Mar 15, 2022 4:16:42 PM (3 years ago)

Author:

vboxsync

Message:

Main: Guest Properties: ​bugref:10185 post-review fixes.

• VirtualBox::i_onGuestPropertyChanged: do not pass BOOL as a reference;
• VbglR3GuestPropWait: improve host buffer validation.

Location:

trunk/src/VBox/Main

Files:

• include/VirtualBoxImpl.h (modified) (1 diff)
• src-server/VirtualBoxImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/VirtualBoxImpl.h

@@ -176 +176 @@
 
     void i_onGuestPropertyChanged(const Guid &aMachineId, const Utf8Str &aName, const Utf8Str &aValue, const Utf8Str &aFlags,
-                                  const BOOL &fWasDeleted);
+                                  const BOOL fWasDeleted);
     void i_onNatRedirectChanged(const Guid &aMachineId, ULONG ulSlot, bool fRemove, const Utf8Str &aName,
                                 NATProtocol_T aProto, const Utf8Str &aHostIp, uint16_t aHostPort,

trunk/src/VBox/Main/src-server/VirtualBoxImpl.cpp

@@ -3609 +3609 @@
  */
 void VirtualBox::i_onGuestPropertyChanged(const Guid &aMachineId, const Utf8Str &aName, const Utf8Str &aValue,
-                                          const Utf8Str &aFlags, const BOOL &fWasDeleted)
+                                          const Utf8Str &aFlags, const BOOL fWasDeleted)
 {
     ComPtr<IEvent> ptrEvent;