Changeset 94277 in vbox

Timestamp:

Mar 17, 2022 1:32:55 AM (3 years ago)

Author:

vboxsync

Message:

IPRT/RTFileFlush: Shut up annoying VERR_INVALID_PARAMETER returns on posix systems when trying to flush a tty.

Location:

trunk

Files:

• include/iprt/file.h (modified) (1 diff)
• src/VBox/Runtime/r3/posix/fileio-posix.cpp (modified) (1 diff)

trunk/include/iprt/file.h

@@ -542 +542 @@
  *
  * @returns iprt status code.
+ * @retval  VINF_NOT_SUPPORTED if it is a special file that does not support
+ *          flushing.  This is reported as a informational status since in most
+ *          cases this is entirely harmless (e.g. tty) and simplifies the usage.
  * @param   File        Handle to the file.
  */

trunk/src/VBox/Runtime/r3/posix/fileio-posix.cpp

@@ -833 +833 @@
 
 
-RTR3DECL(int)  RTFileFlush(RTFILE hFile)
-{
-    if (fsync(RTFileToNative(hFile)))
-        return RTErrConvertFromErrno(errno);
-    return VINF_SUCCESS;
+RTR3DECL(int) RTFileFlush(RTFILE hFile)
+{
+    if (!fsync(RTFileToNative(hFile)))
+        return VINF_SUCCESS;
+    /* Ignore EINVAL here as that's what returned for pseudo ttys
+       and other odd handles. */
+    if (errno == EINVAL)
+        return VINF_NOT_SUPPORTED;
+    return RTErrConvertFromErrno(errno);
 }