Changeset 94388 in vbox

Timestamp:

Mar 29, 2022 7:06:06 AM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

150699

Message:

VBoxNetAdpCtl: Some harmless leak fixes

File:

• trunk/src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp (modified) (3 diffs)

trunk/src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp

@@ -457 +457 @@
     }
     if (dry_run)
+    {
+        free((void *)argv);
         return EXIT_SUCCESS;
+    }
 
     int rc = EXIT_FAILURE; /* o/~ hope for the best, expect the worst */
@@ -512 +515 @@
     int rc = EXIT_SUCCESS;
     int fds[2];
-    char * const * argv = allocArgv(getShowCommand(pcszAdapter));
-    char * const envp[] = { (char*)"LC_ALL=C", NULL };
 
     memset(aszAddresses, 0, sizeof(aszAddresses));
@@ -532 +533 @@
         rc = dup2(fds[1], STDOUT_FILENO);
         if (rc >= 0)
+        {
+            char * const * argv = allocArgv(getShowCommand(pcszAdapter));
+            char * const envp[] = { (char*)"LC_ALL=C", NULL };
+
             if (execve(argv[0], argv, envp) == -1)
+            {
+                free((void *)argv);
                 return errno;
+            }
+
+            free((void *)argv);
+        }
         return rc;
     }