Changeset 94395 in vbox

Timestamp:

Mar 29, 2022 4:29:26 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

150711

Message:

FE/Qt/Ds: bugref:6899: Large properties/settings editors cleanup; Lots of excessive code removed and some coding-style fixes.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors

Files:

• UIAudioControllerEditor.cpp (modified) (5 diffs)
• UIAudioControllerEditor.h (modified) (2 diffs)
• UIAudioHostDriverEditor.cpp (modified) (5 diffs)
• UIAudioHostDriverEditor.h (modified) (2 diffs)
• UIAutoCaptureKeyboardEditor.cpp (modified) (3 diffs)
• UIAutoCaptureKeyboardEditor.h (modified) (1 diff)
• UIBaseMemoryEditor.cpp (modified) (9 diffs)
• UIBaseMemoryEditor.h (modified) (2 diffs)
• UIBootOrderEditor.cpp (modified) (3 diffs)
• UIBootOrderEditor.h (modified) (5 diffs)
• UIColorThemeEditor.cpp (modified) (5 diffs)
• UIColorThemeEditor.h (modified) (3 diffs)
• UIDefaultMachineFolderEditor.cpp (modified) (4 diffs)
• UIDefaultMachineFolderEditor.h (modified) (2 diffs)
• UIGlobalDisplayFeaturesEditor.cpp (modified) (4 diffs)
• UIGlobalDisplayFeaturesEditor.h (modified) (2 diffs)
• UIGlobalProxyFeaturesEditor.cpp (modified) (1 diff)
• UIGlobalProxyFeaturesEditor.h (modified) (2 diffs)
• UIGraphicsControllerEditor.cpp (modified) (3 diffs)
• UIGraphicsControllerEditor.h (modified) (1 diff)
• UIHostComboEditor.h (modified) (3 diffs)
• UIHotKeyEditor.h (modified) (1 diff)
• UILanguageSettingsEditor.cpp (modified) (3 diffs)
• UILanguageSettingsEditor.h (modified) (2 diffs)
• UIMachineAudioFeaturesEditor.cpp (modified) (3 diffs)
• UIMachineAudioFeaturesEditor.h (modified) (2 diffs)
• UIMachineDisplayScreenFeaturesEditor.cpp (modified) (2 diffs)
• UIMachineDisplayScreenFeaturesEditor.h (modified) (2 diffs)
• UIMaximumGuestScreenSizeEditor.cpp (modified) (6 diffs)
• UIMaximumGuestScreenSizeEditor.h (modified) (3 diffs)
• UIMonitorCountEditor.cpp (modified) (1 diff)
• UIMonitorCountEditor.h (modified) (2 diffs)
• UINameAndSystemEditor.h (modified) (2 diffs)
• UINetworkAttachmentEditor.h (modified) (1 diff)
• UIScaleFactorEditor.h (modified) (1 diff)
• UIShortcutConfigurationEditor.h (modified) (4 diffs)
• UIUpdateSettingsEditor.cpp (modified) (4 diffs)
• UIUpdateSettingsEditor.h (modified) (1 diff)
• UIVRDEAuthLibraryEditor.cpp (modified) (4 diffs)
• UIVRDEAuthLibraryEditor.h (modified) (2 diffs)
• UIVRDESettingsEditor.cpp (modified) (8 diffs)
• UIVRDESettingsEditor.h (modified) (3 diffs)
• UIVideoMemoryEditor.cpp (modified) (6 diffs)
• UIVideoMemoryEditor.h (modified) (2 diffs)
• UIVirtualCPUEditor.h (modified) (1 diff)
• UIVisualStateEditor.cpp (modified) (5 diffs)
• UIVisualStateEditor.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAudioControllerEditor.cpp ¶

@@ -42 +42 @@
 void UIAudioControllerEditor::setValue(KAudioControllerType enmValue)
 {
-    if (m_pCombo)
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_enmValue != enmValue)
     {
-        /* Update cached value and
-         * combo if value has changed: */
-        if (m_enmValue != enmValue)
-        {
-            m_enmValue = enmValue;
-            populateCombo();
-        }
-
-        /* Look for proper index to choose: */
-        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
-        if (iIndex != -1)
-            m_pCombo->setCurrentIndex(iIndex);
+        m_enmValue = enmValue;
+        populateCombo();
     }
 }
@@ -66 +58 @@
 int UIAudioControllerEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -89 +81 @@
                                 "VirtualBox will provide different audio hardware to the virtual machine."));
     }
-}
-
-void UIAudioControllerEditor::sltHandleCurrentIndexChanged()
-{
-    if (m_pCombo)
-        emit sigValueChanged(m_pCombo->itemData(m_pCombo->currentIndex()).value<KAudioControllerType>());
 }
 
@@ -125 +111 @@
                 if (m_pLabel)
                     m_pLabel->setBuddy(m_pCombo);
-                connect(m_pCombo, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
-                        this, &UIAudioControllerEditor::sltHandleCurrentIndexChanged);
                 pComboLayout->addWidget(m_pCombo);
             }
@@ -165 +149 @@
             m_pCombo->addItem(QString(), QVariant::fromValue(enmType));
 
+        /* Look for proper index to choose: */
+        const int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
+        if (iIndex != -1)
+            m_pCombo->setCurrentIndex(iIndex);
+
         /* Retranslate finally: */
         retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAudioControllerEditor.h ¶

@@ -42 +42 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(KAudioControllerType enmValue);
-
 public:
 
-    /** Constructs audio controller editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIAudioControllerEditor(QWidget *pParent = 0);
 
@@ -69 +64 @@
     /** Handles translation event. */
     virtual void retranslateUi() RT_OVERRIDE;
-
-private slots:
-
-    /** Handles current index change. */
-    void sltHandleCurrentIndexChanged();
 
 private:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAudioHostDriverEditor.cpp ¶

@@ -42 +42 @@
 void UIAudioHostDriverEditor::setValue(KAudioDriverType enmValue)
 {
-    if (m_pCombo)
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_enmValue != enmValue)
     {
-        /* Update cached value and
-         * combo if value has changed: */
-        if (m_enmValue != enmValue)
-        {
-            m_enmValue = enmValue;
-            populateCombo();
-        }
-
-        /* Look for proper index to choose: */
-        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
-        if (iIndex != -1)
-            m_pCombo->setCurrentIndex(iIndex);
+        m_enmValue = enmValue;
+        populateCombo();
     }
 }
@@ -66 +58 @@
 int UIAudioHostDriverEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -89 +81 @@
                                 "see an audio card, however every access to it will be ignored."));
     }
-}
-
-void UIAudioHostDriverEditor::sltHandleCurrentIndexChanged()
-{
-    if (m_pCombo)
-        emit sigValueChanged(m_pCombo->itemData(m_pCombo->currentIndex()).value<KAudioDriverType>());
 }
 
@@ -125 +111 @@
                 if (m_pLabel)
                     m_pLabel->setBuddy(m_pCombo);
-                connect(m_pCombo, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
-                        this, &UIAudioHostDriverEditor::sltHandleCurrentIndexChanged);
                 pComboLayout->addWidget(m_pCombo);
             }
@@ -165 +149 @@
             m_pCombo->addItem(QString(), QVariant::fromValue(enmType));
 
+        /* Look for proper index to choose: */
+        const int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
+        if (iIndex != -1)
+            m_pCombo->setCurrentIndex(iIndex);
+
         /* Retranslate finally: */
         retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAudioHostDriverEditor.h ¶

@@ -42 +42 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(KAudioDriverType enmValue);
-
 public:
 
-    /** Constructs audio host driver editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIAudioHostDriverEditor(QWidget *pParent = 0);
 
@@ -69 +64 @@
     /** Handles translation event. */
     virtual void retranslateUi() RT_OVERRIDE;
-
-private slots:
-
-    /** Handles current index change. */
-    void sltHandleCurrentIndexChanged();
 
 private:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAutoCaptureKeyboardEditor.cpp ¶

@@ -36 +36 @@
 void UIAutoCaptureKeyboardEditor::setValue(bool fValue)
 {
-    if (m_pCheckBox)
+    /* Update cached value and
+     * check-box if value has changed: */
+    if (m_fValue != fValue)
     {
-        /* Update cached value and
-         * check-box if value has changed: */
-        if (m_fValue != fValue)
-        {
-            m_fValue = fValue;
-            m_pCheckBox->setCheckState(fValue ? Qt::Checked : Qt::Unchecked);
-        }
+        m_fValue = fValue;
+        if (m_pCheckBox)
+            m_pCheckBox->setCheckState(m_fValue ? Qt::Checked : Qt::Unchecked);
     }
 }
@@ -59 +57 @@
     if (m_pCheckBox)
     {
+        m_pCheckBox->setText(tr("&Auto Capture Keyboard"));
         m_pCheckBox->setToolTip(tr("When checked, the keyboard is automatically captured every time the VM window is "
                                    "activated. When the keyboard is captured, all keystrokes (including system ones like "
                                    "Alt-Tab) are directed to the VM."));
-        m_pCheckBox->setText(tr("&Auto Capture Keyboard"));
     }
 }
@@ -69 +67 @@
 {
     /* Prepare main layout: */
-    QGridLayout *pLayoutMain = new QGridLayout(this);
-    if (pLayoutMain)
+    QGridLayout *pLayout = new QGridLayout(this);
+    if (pLayout)
     {
-        pLayoutMain->setContentsMargins(0, 0, 0, 0);
-        pLayoutMain->setColumnStretch(1, 1);
+        pLayout->setContentsMargins(0, 0, 0, 0);
+        pLayout->setColumnStretch(1, 1);
 
         /* Prepare label: */
         m_pLabel = new QLabel(this);
         if (m_pLabel)
-            pLayoutMain->addWidget(m_pLabel, 0, 0);
+            pLayout->addWidget(m_pLabel, 0, 0);
         /* Prepare check-box: */
         m_pCheckBox = new QCheckBox(this);
         if (m_pCheckBox)
-            pLayoutMain->addWidget(m_pCheckBox, 0, 1);
+            pLayout->addWidget(m_pCheckBox, 0, 1);
     }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIAutoCaptureKeyboardEditor.h ¶

@@ -36 +36 @@
 public:
 
-    /** Constructs auto capture keyboard editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIAutoCaptureKeyboardEditor(QWidget *pParent = 0);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIBaseMemoryEditor.cpp ¶

@@ -62 +62 @@
 
     /** Holds the minimum RAM. */
-    uint m_uMinRAM;
+    uint  m_uMinRAM;
     /** Holds the maximum optimal RAM. */
-    uint m_uMaxRAMOpt;
+    uint  m_uMaxRAMOpt;
     /** Holds the maximum allowed RAM. */
-    uint m_uMaxRAMAlw;
+    uint  m_uMaxRAMAlw;
     /** Holds the maximum possible RAM. */
-    uint m_uMaxRAM;
+    uint  m_uMaxRAM;
 };
 
@@ -83 +83 @@
   , m_uMaxRAM(0)
 {
-    /* Prepare: */
     prepare();
 }
@@ -94 +93 @@
   , m_uMaxRAM(0)
 {
-    /* Prepare: */
     prepare();
 }
@@ -243 +241 @@
     : QIWithRetranslateUI<QWidget>(pParent)
     , m_fWithLabel(fWithLabel)
+    , m_iValue(0)
     , m_pLabelMemory(0)
     , m_pSlider(0)
@@ -254 +253 @@
 void UIBaseMemoryEditor::setValue(int iValue)
 {
-    if (m_pSlider)
-        m_pSlider->setValue(iValue);
+    /* Update cached value and
+     * slider if value has changed: */
+    if (m_iValue != iValue)
+    {
+        m_iValue = iValue;
+        if (m_pSlider)
+            m_pSlider->setValue(m_iValue);
+    }
 }
 
 int UIBaseMemoryEditor::value() const
 {
-    return m_pSlider ? m_pSlider->value() : 0;
+    return m_pSlider ? m_pSlider->value() : m_iValue;
 }
 
@@ -324 +329 @@
 {
     /* Create main layout: */
-    QGridLayout *pMainLayout = new QGridLayout(this);
-    if (pMainLayout)
-    {
-        pMainLayout->setContentsMargins(0, 0, 0, 0);
+    QGridLayout *pLayout = new QGridLayout(this);
+    if (pLayout)
+    {
+        pLayout->setContentsMargins(0, 0, 0, 0);
         int iRow = 0;
 
@@ -334 +339 @@
             m_pLabelMemory = new QLabel(this);
         if (m_pLabelMemory)
-            pMainLayout->addWidget(m_pLabelMemory, 0, iRow++, 1, 1);
+            pLayout->addWidget(m_pLabelMemory, 0, iRow++, 1, 1);
 
         /* Create slider layout: */
@@ -376 +381 @@
 
             /* Add slider layout to main layout: */
-            pMainLayout->addLayout(pSliderLayout, 0, iRow++, 2, 1);
+            pLayout->addLayout(pSliderLayout, 0, iRow++, 2, 1);
         }
 
@@ -390 +395 @@
             connect(m_pSpinBox, static_cast<void(QSpinBox::*)(int)>(&QSpinBox::valueChanged),
                     this, &UIBaseMemoryEditor::sltHandleSpinBoxChange);
-            pMainLayout->addWidget(m_pSpinBox, 0, iRow++, 1, 1);
+            pLayout->addWidget(m_pSpinBox, 0, iRow++, 1, 1);
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIBaseMemoryEditor.h ¶

@@ -43 +43 @@
     /** Notifies listeners about value has became @a fValid. */
     void sigValidChanged(bool fValid);
+    /** Notifies listeners about @a iValue has changed. */
     void sigValueChanged(int iValue);
 
 public:
 
-    /** Constructs base-memory editor passing @a pParent to the base-class.
+    /** Constructs editor passing @a pParent to the base-class.
       * @param  fWithLabel  Brings whether we should add label ourselves. */
     UIBaseMemoryEditor(QWidget *pParent = 0, bool fWithLabel = false);
@@ -84 +85 @@
     bool  m_fWithLabel;
 
-    /** Holds the memory label instance. */
-    QLabel             *m_pLabelMemory;
-    /** Holds the memory slider instance. */
-    UIBaseMemorySlider *m_pSlider;
-    /** Holds minimum memory label instance. */
-    QLabel             *m_pLabelMemoryMin;
-    /** Holds maximum memory label instance. */
-    QLabel             *m_pLabelMemoryMax;
-    /** Holds the memory spin-box instance. */
-    QSpinBox           *m_pSpinBox;
+    /** Holds the value to be selected. */
+    int  m_iValue;
+
+    /** @name Widgets
+     * @{ */
+        /** Holds the memory label instance. */
+        QLabel             *m_pLabelMemory;
+        /** Holds the memory slider instance. */
+        UIBaseMemorySlider *m_pSlider;
+        /** Holds minimum memory label instance. */
+        QLabel             *m_pLabelMemoryMin;
+        /** Holds maximum memory label instance. */
+        QLabel             *m_pLabelMemoryMax;
+        /** Holds the memory spin-box instance. */
+        QSpinBox           *m_pSpinBox;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIBootOrderEditor.cpp ¶

@@ -486 +486 @@
 {
     /* Create main layout: */
-    QGridLayout *pMainLayout = new QGridLayout(this);
-    if (pMainLayout)
-    {
-        pMainLayout->setContentsMargins(0, 0, 0, 0);
+    QGridLayout *pLayout = new QGridLayout(this);
+    if (pLayout)
+    {
+        pLayout->setContentsMargins(0, 0, 0, 0);
         int iRow = 0;
 
@@ -496 +496 @@
             m_pLabel = new QLabel(this);
         if (m_pLabel)
-            pMainLayout->addWidget(m_pLabel, 0, iRow++, 1, 1);
+            pLayout->addWidget(m_pLabel, 0, iRow++, 1, 1);
 
         /* Create table layout: */
@@ -541 +541 @@
 
             /* Add table layout to main layout: */
-            pMainLayout->addLayout(pTableLayout, 0, iRow++, 3, 1);
+            pLayout->addLayout(pTableLayout, 0, iRow++, 3, 1);
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIBootOrderEditor.h ¶

@@ -42 +42 @@
 struct UIBootItemData
 {
-    /** Constructs boot item data. */
+    /** Constructs item data. */
     UIBootItemData()
         : m_enmType(KDeviceType_Null)
@@ -57 +57 @@
     }
 
-    /** Holds the boot device type. */
+    /** Holds the device type. */
     KDeviceType  m_enmType;
-    /** Holds whether the boot device enabled. */
+    /** Holds whether the device enabled. */
     bool         m_fEnabled;
 };
@@ -69 +69 @@
 namespace UIBootDataTools
 {
-    /** Loads boot item list for passed @a comMachine. */
+    /** Loads item list for passed @a comMachine. */
     SHARED_LIBRARY_STUFF UIBootItemDataList loadBootItems(const CMachine &comMachine);
     /** Saves @a bootItems list to passed @a comMachine. */
@@ -92 +92 @@
 public:
 
-    /** Constructs boot order editor passing @a pParent to the base-class.
+    /** Constructs editor passing @a pParent to the base-class.
       * @param  fWithLabel  Brings whether we should add label ourselves. */
     UIBootOrderEditor(QWidget *pParent = 0, bool fWithLabel = false);
@@ -111 +111 @@
 private slots:
 
-    /** Handles current boot item change. */
+    /** Handles current item change. */
     void sltHandleCurrentBootItemChange();
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIColorThemeEditor.cpp ¶

@@ -38 +38 @@
 void UIColorThemeEditor::setValue(UIColorThemeType enmValue)
 {
-    if (m_pCombo)
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_enmValue != enmValue)
     {
-        /* Update cached value and
-         * combo if value has changed: */
-        if (m_enmValue != enmValue)
-        {
-            m_enmValue = enmValue;
-            populateCombo();
-        }
-
-        /* Look for proper index to choose: */
-        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
-        if (iIndex != -1)
-            m_pCombo->setCurrentIndex(iIndex);
+        m_enmValue = enmValue;
+        populateCombo();
     }
 }
@@ -75 +67 @@
 }
 
-void UIColorThemeEditor::sltHandleCurrentIndexChanged()
-{
-    if (m_pCombo)
-        emit sigValueChanged(m_pCombo->itemData(m_pCombo->currentIndex()).value<UIColorThemeType>());
-}
-
 void UIColorThemeEditor::prepare()
 {
     /* Create main layout: */
-    QGridLayout *pMainLayout = new QGridLayout(this);
-    if (pMainLayout)
+    QGridLayout *pLayout = new QGridLayout(this);
+    if (pLayout)
     {
-        pMainLayout->setContentsMargins(0, 0, 0, 0);
+        pLayout->setContentsMargins(0, 0, 0, 0);
 
         /* Create label: */
         m_pLabel = new QLabel(this);
         if (m_pLabel)
-            pMainLayout->addWidget(m_pLabel, 0, 0);
+            pLayout->addWidget(m_pLabel, 0, 0);
 
         /* Create combo layout: */
@@ -106 +92 @@
                 if (m_pLabel)
                     m_pLabel->setBuddy(m_pCombo);
-                connect(m_pCombo, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
-                        this, &UIColorThemeEditor::sltHandleCurrentIndexChanged);
                 pComboLayout->addWidget(m_pCombo);
             }
@@ -115 +99 @@
 
             /* Add combo-layout into main-layout: */
-            pMainLayout->addLayout(pComboLayout, 0, 1);
+            pLayout->addLayout(pComboLayout, 0, 1);
         }
     }
@@ -143 +127 @@
             m_pCombo->addItem(QString(), QVariant::fromValue(enmType));
 
+        /* Look for proper index to choose: */
+        const int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
+        if (iIndex != -1)
+            m_pCombo->setCurrentIndex(iIndex);
+
         /* Retranslate finally: */
         retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIColorThemeEditor.h ¶

@@ -39 +39 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(UIColorThemeType enmValue);
-
 public:
 
-    /** Constructs color theme editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIColorThemeEditor(QWidget *pParent = 0);
 
@@ -59 +54 @@
     virtual void retranslateUi() RT_OVERRIDE;
 
-private slots:
-
-    /** Handles current index change. */
-    void sltHandleCurrentIndexChanged();
-
 private:
 
@@ -70 +60 @@
     /** Populates combo. */
     void populateCombo();
-
-    /** Holds whether descriptive label should be created. */
-    bool  m_fWithLabel;
 
     /** Holds the value to be selected. */

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIDefaultMachineFolderEditor.cpp ¶

@@ -38 +38 @@
 void UIDefaultMachineFolderEditor::setValue(const QString &strValue)
 {
-    if (m_pSelector)
+    /* Update cached value and editor
+     * if value has changed: */
+    if (m_strValue != strValue)
     {
-        /* Update cached value and editor
-         * if value has changed: */
-        if (m_strValue != strValue)
-        {
-            m_strValue = strValue;
-            m_pSelector->setPath(strValue);
-        }
+        m_strValue = strValue;
+        if (m_pSelector)
+            m_pSelector->setPath(m_strValue);
     }
 }
@@ -57 +55 @@
 int UIDefaultMachineFolderEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -73 +71 @@
         m_pSelector->setToolTip(tr("Holds the path to the default virtual machine folder. This folder is used, "
                                    "if not explicitly specified otherwise, when creating new virtual machines."));
-}
-
-void UIDefaultMachineFolderEditor::sltHandleSelectorPathChanged()
-{
-    if (m_pSelector)
-        emit sigValueChanged(m_pSelector->path());
 }
 
@@ -105 +97 @@
                 m_pLabel->setBuddy(m_pSelector);
             m_pSelector->setInitialPath(uiCommon().homeFolder());
-            connect(m_pSelector, &UIFilePathSelector::pathChanged,
-                    this, &UIDefaultMachineFolderEditor::sltHandleSelectorPathChanged);
 
             m_pLayout->addWidget(m_pSelector, 0, 1);

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIDefaultMachineFolderEditor.h ¶

@@ -39 +39 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(const QString &strValue);
-
 public:
 
@@ -64 +59 @@
     virtual void retranslateUi() RT_OVERRIDE;
 
-private slots:
-
-    /** Handles selector path change. */
-    void sltHandleSelectorPathChanged();
-
 private:
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGlobalDisplayFeaturesEditor.cpp ¶

@@ -41 +41 @@
 void UIGlobalDisplayFeaturesEditor::setActivateOnMouseHover(bool fOn)
 {
-    if (m_pCheckBoxActivateOnMouseHover)
+    /* Update cached value and
+     * check-box if value has changed: */
+    if (m_fActivateOnMouseHover != fOn)
     {
-        /* Update cached value and
-         * check-box if value has changed: */
-        if (m_fActivateOnMouseHover != fOn)
-        {
-            m_fActivateOnMouseHover = fOn;
-            m_pCheckBoxActivateOnMouseHover->setCheckState(fOn ? Qt::Checked : Qt::Unchecked);
-        }
+        m_fActivateOnMouseHover = fOn;
+        if (m_pCheckBoxActivateOnMouseHover)
+            m_pCheckBoxActivateOnMouseHover->setCheckState(m_fActivateOnMouseHover ? Qt::Checked : Qt::Unchecked);
     }
 }
@@ -62 +60 @@
 void UIGlobalDisplayFeaturesEditor::setDisableHostScreenSaver(bool fOn)
 {
-    if (m_pCheckBoxDisableHostScreenSaver)
+    /* Update cached value and
+     * check-box if value has changed: */
+    if (m_fDisableHostScreenSaver != fOn)
     {
-        /* Update cached value and
-         * check-box if value has changed: */
-        if (m_fDisableHostScreenSaver != fOn)
-        {
-            m_fDisableHostScreenSaver = fOn;
-            m_pCheckBoxDisableHostScreenSaver->setCheckState(fOn ? Qt::Checked : Qt::Unchecked);
-        }
+        m_fDisableHostScreenSaver = fOn;
+        if (m_pCheckBoxDisableHostScreenSaver)
+            m_pCheckBoxDisableHostScreenSaver->setCheckState(m_fDisableHostScreenSaver ? Qt::Checked : Qt::Unchecked);
     }
 }
@@ -83 +79 @@
 int UIGlobalDisplayFeaturesEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -96 +92 @@
     if (m_pLabel)
         m_pLabel->setText(tr("Extended Features:"));
+
     if (m_pCheckBoxActivateOnMouseHover)
     {
+        m_pCheckBoxActivateOnMouseHover->setText(tr("&Raise Window Under Mouse Pointer"));
         m_pCheckBoxActivateOnMouseHover->setToolTip(tr("When checked, machine windows will be raised "
                                                        "when the mouse pointer moves over them."));
-        m_pCheckBoxActivateOnMouseHover->setText(tr("&Raise Window Under Mouse Pointer"));
     }
+
     if (m_pCheckBoxDisableHostScreenSaver)
     {
+        m_pCheckBoxDisableHostScreenSaver->setText(tr("&Disable Host Screen Saver"));
         m_pCheckBoxDisableHostScreenSaver->setToolTip(tr("When checked, screen saver of "
                                                          "the host OS is disabled."));
-        m_pCheckBoxDisableHostScreenSaver->setText(tr("&Disable Host Screen Saver"));
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGlobalDisplayFeaturesEditor.h ¶

@@ -37 +37 @@
 public:
 
-    /** Constructs global display features editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIGlobalDisplayFeaturesEditor(QWidget *pParent = 0);
 
@@ -65 +65 @@
     void prepare();
 
-    /** Holds the 'activate on mouse hover' feature value. */
-    bool  m_fActivateOnMouseHover;
-    /** Holds the 'disable host screen-saver' feature value. */
-    bool  m_fDisableHostScreenSaver;
+    /** @name Values
+     * @{ */
+        /** Holds the 'activate on mouse hover' feature value. */
+        bool  m_fActivateOnMouseHover;
+        /** Holds the 'disable host screen-saver' feature value. */
+        bool  m_fDisableHostScreenSaver;
+    /** @} */
 
-    /** Holds the main layout instance. */
-    QGridLayout *m_pLayout;
-    /** Holds the label instance. */
-    QLabel      *m_pLabel;
-    /** Holds the check-box instance. */
-    QCheckBox   *m_pCheckBoxActivateOnMouseHover;
-    /** Holds the check-box instance. */
-    QCheckBox   *m_pCheckBoxDisableHostScreenSaver;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout *m_pLayout;
+        /** Holds the label instance. */
+        QLabel      *m_pLabel;
+        /** Holds the check-box instance. */
+        QCheckBox   *m_pCheckBoxActivateOnMouseHover;
+        /** Holds the check-box instance. */
+        QCheckBox   *m_pCheckBoxDisableHostScreenSaver;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGlobalProxyFeaturesEditor.cpp ¶

@@ -105 +105 @@
     if (m_pRadioButtonProxyAuto)
     {
+        m_pRadioButtonProxyAuto->setText(tr("&Auto-detect Host Proxy Settings"));
         m_pRadioButtonProxyAuto->setToolTip(tr("When chosen, VirtualBox will try to auto-detect host proxy settings for tasks "
                                                "like downloading Guest Additions from the network or checking for updates."));
-        m_pRadioButtonProxyAuto->setText(tr("&Auto-detect Host Proxy Settings"));
     }
     if (m_pRadioButtonProxyDisabled)
     {
+        m_pRadioButtonProxyDisabled->setText(tr("&Direct Connection to the Internet"));
         m_pRadioButtonProxyDisabled->setToolTip(tr("When chosen, VirtualBox will use direct Internet connection for tasks like "
                                                    "downloading Guest Additions from the network or checking for updates."));
-        m_pRadioButtonProxyDisabled->setText(tr("&Direct Connection to the Internet"));
     }
     if (m_pRadioButtonProxyEnabled)
     {
+        m_pRadioButtonProxyEnabled->setText(tr("&Manual Proxy Configuration"));
         m_pRadioButtonProxyEnabled->setToolTip(tr("When chosen, VirtualBox will use the proxy settings supplied for tasks like "
                                                   "downloading Guest Additions from the network or checking for updates."));
-        m_pRadioButtonProxyEnabled->setText(tr("&Manual Proxy Configuration"));
     }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGlobalProxyFeaturesEditor.h ¶

@@ -48 +48 @@
 public:
 
-    /** Constructs global proxy features editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIGlobalProxyFeaturesEditor(QWidget *pParent = 0);
 
@@ -76 +76 @@
     void prepare();
 
-    /** Holds the proxy mode. */
-    KProxyMode  m_enmProxyMode;
-    /** Holds the proxy host. */
-    QString     m_strProxyHost;
+    /** @name Values
+     * @{ */
+        /** Holds the proxy mode. */
+        KProxyMode  m_enmProxyMode;
+        /** Holds the proxy host. */
+        QString     m_strProxyHost;
+    /** @} */
 
-    /** Holds the button-group instance. */
-    QButtonGroup *m_pButtonGroup;
-    /** Holds the 'proxy auto' radio-button instance. */
-    QRadioButton *m_pRadioButtonProxyAuto;
-    /** Holds the 'proxy disabled' radio-button instance. */
-    QRadioButton *m_pRadioButtonProxyDisabled;
-    /** Holds the 'proxy enabled' radio-button instance. */
-    QRadioButton *m_pRadioButtonProxyEnabled;
-    /** Holds the settings widget instance. */
-    QWidget      *m_pWidgetSettings;
-    /** Holds the host label instance. */
-    QLabel       *m_pLabelHost;
-    /** Holds the host editor instance. */
-    QILineEdit   *m_pEditorHost;
+    /** @name Widgets
+     * @{ */
+        /** Holds the button-group instance. */
+        QButtonGroup *m_pButtonGroup;
+        /** Holds the 'proxy auto' radio-button instance. */
+        QRadioButton *m_pRadioButtonProxyAuto;
+        /** Holds the 'proxy disabled' radio-button instance. */
+        QRadioButton *m_pRadioButtonProxyDisabled;
+        /** Holds the 'proxy enabled' radio-button instance. */
+        QRadioButton *m_pRadioButtonProxyEnabled;
+        /** Holds the settings widget instance. */
+        QWidget      *m_pWidgetSettings;
+        /** Holds the host label instance. */
+        QLabel       *m_pLabelHost;
+        /** Holds the host editor instance. */
+        QILineEdit   *m_pEditorHost;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGraphicsControllerEditor.cpp ¶

@@ -43 +43 @@
 void UIGraphicsControllerEditor::setValue(KGraphicsControllerType enmValue)
 {
-    if (m_pCombo)
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_enmValue != enmValue)
     {
-        /* Update cached value and
-         * combo if value has changed: */
-        if (m_enmValue != enmValue)
-        {
-            m_enmValue = enmValue;
-            populateCombo();
-        }
-
-        /* Look for proper index to choose: */
-        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
-        if (iIndex != -1)
-            m_pCombo->setCurrentIndex(iIndex);
+        m_enmValue = enmValue;
+        populateCombo();
     }
 }
@@ -67 +59 @@
 int UIGraphicsControllerEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -166 +158 @@
             m_pCombo->addItem(QString(), QVariant::fromValue(enmType));
 
+        /* Look for proper index to choose: */
+        const int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
+        if (iIndex != -1)
+            m_pCombo->setCurrentIndex(iIndex);
+
         /* Retranslate finally: */
         retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIGraphicsControllerEditor.h ¶

@@ -49 +49 @@
 public:
 
-    /** Constructs graphics controller editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIGraphicsControllerEditor(QWidget *pParent = 0);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIHostComboEditor.h ¶

@@ -100 +100 @@
 public:
 
-    /** Constructs host-combo wrapper on the basis of passed @a strHostCombo. */
+    /** Constructs wrapper on the basis of passed @a strHostCombo. */
     UIHostComboWrapper(const QString &strHostCombo = QString())
         : m_strHostCombo(strHostCombo)
@@ -129 +129 @@
 public:
 
-    /** Constructs host-combo editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIHostComboEditor(QWidget *pParent);
 
@@ -171 +171 @@
 public:
 
-    /** Constructs host-combo editor private part. */
+    /** Constructs editor private part. */
     UIHostComboEditorPrivate();
-    /** Destructs host-combo editor private part. */
+    /** Destructs editor private part. */
     ~UIHostComboEditorPrivate();
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIHotKeyEditor.h ¶

@@ -111 +111 @@
 public:
 
-    /** Constructs hot-key editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIHotKeyEditor(QWidget *pParent);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UILanguageSettingsEditor.cpp ¶

@@ -212 +212 @@
 void UILanguageSettingsEditor::setValue(const QString &strValue)
 {
-    /* Update value if changed: */
+    /* Update cached value and
+     * tree-widget if value has changed: */
     if (m_strValue != strValue)
     {
-        /* Update value itself: */
         m_strValue = strValue;
-
-        /* Update tree-widget if present: */
         if (m_pTreeWidget)
             reloadLanguageTree(m_strValue);
@@ -321 +319 @@
 
 void UILanguageSettingsEditor::prepare()
-{
-    /* Prepare everything: */
-    prepareWidgets();
-    prepareConnections();
-
-    /* Apply language settings: */
-    retranslateUi();
-}
-
-void UILanguageSettingsEditor::prepareWidgets()
 {
     /* Prepare main layout: */
@@ -369 +357 @@
         }
     }
-}
-
-void UILanguageSettingsEditor::prepareConnections()
-{
+
+    /* Prepare connections: */
     connect(m_pTreeWidget, &QITreeWidget::painted, this, &UILanguageSettingsEditor::sltHandleItemPainting);
     connect(m_pTreeWidget, &QITreeWidget::currentItemChanged, this, &UILanguageSettingsEditor::sltHandleCurrentItemChange);
+
+    /* Apply language settings: */
+    retranslateUi();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UILanguageSettingsEditor.h ¶

@@ -38 +38 @@
 public:
 
-    /** Constructs language settings editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UILanguageSettingsEditor(QWidget *pParent = 0);
 
@@ -68 +68 @@
     /** Prepares all. */
     void prepare();
-    /** Prepares widgets. */
-    void prepareWidgets();
-    /** Prepares connections. */
-    void prepareConnections();
     /** Cleanups all. */
     void cleanup();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMachineAudioFeaturesEditor.cpp ¶

@@ -41 +41 @@
 void UIMachineAudioFeaturesEditor::setEnableOutput(bool fOn)
 {
-    if (m_pCheckBoxEnableOutput)
+    /* Update cached value and
+     * check-box if value has changed: */
+    if (m_fEnableOutput != fOn)
     {
-        /* Update cached value and
-         * check-box if value has changed: */
-        if (m_fEnableOutput != fOn)
-        {
-            m_fEnableOutput = fOn;
-            m_pCheckBoxEnableOutput->setCheckState(fOn ? Qt::Checked : Qt::Unchecked);
-        }
+        m_fEnableOutput = fOn;
+        if (m_pCheckBoxEnableOutput)
+            m_pCheckBoxEnableOutput->setCheckState(m_fEnableOutput ? Qt::Checked : Qt::Unchecked);
     }
 }
@@ -62 +60 @@
 void UIMachineAudioFeaturesEditor::setEnableInput(bool fOn)
 {
-    if (m_pCheckBoxEnableInput)
+    /* Update cached value and
+     * check-box if value has changed: */
+    if (m_fEnableInput != fOn)
     {
-        /* Update cached value and
-         * check-box if value has changed: */
-        if (m_fEnableInput != fOn)
-        {
-            m_fEnableInput = fOn;
-            m_pCheckBoxEnableInput->setCheckState(fOn ? Qt::Checked : Qt::Unchecked);
-        }
+        m_fEnableInput = fOn;
+        if (m_pCheckBoxEnableInput)
+            m_pCheckBoxEnableInput->setCheckState(m_fEnableInput ? Qt::Checked : Qt::Unchecked);
     }
 }
@@ -83 +79 @@
 int UIMachineAudioFeaturesEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMachineAudioFeaturesEditor.h ¶

@@ -37 +37 @@
 public:
 
-    /** Constructs machine audio features editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIMachineAudioFeaturesEditor(QWidget *pParent = 0);
 
@@ -65 +65 @@
     void prepare();
 
-    /** Holds the 'enable output' feature value. */
-    bool  m_fEnableOutput;
-    /** Holds the 'enable input' feature value. */
-    bool  m_fEnableInput;
+    /** @name Values
+     * @{ */
+        /** Holds the 'enable output' feature value. */
+        bool  m_fEnableOutput;
+        /** Holds the 'enable input' feature value. */
+        bool  m_fEnableInput;
+    /** @} */
 
-    /** Holds the main layout instance. */
-    QGridLayout *m_pLayout;
-    /** Holds the label instance. */
-    QLabel      *m_pLabel;
-    /** Holds the 'enable output' check-box instance. */
-    QCheckBox   *m_pCheckBoxEnableOutput;
-    /** Holds the 'enable input' check-box instance. */
-    QCheckBox   *m_pCheckBoxEnableInput;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout *m_pLayout;
+        /** Holds the label instance. */
+        QLabel      *m_pLabel;
+        /** Holds the 'enable output' check-box instance. */
+        QCheckBox   *m_pCheckBoxEnableOutput;
+        /** Holds the 'enable input' check-box instance. */
+        QCheckBox   *m_pCheckBoxEnableInput;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMachineDisplayScreenFeaturesEditor.cpp ¶

@@ -43 +43 @@
         {
             m_fEnable3DAcceleration = fOn;
-            m_pCheckBoxEnable3DAcceleration->setCheckState(fOn ? Qt::Checked : Qt::Unchecked);
+            m_pCheckBoxEnable3DAcceleration->setCheckState(m_fEnable3DAcceleration ? Qt::Checked : Qt::Unchecked);
         }
     }
@@ -57 +57 @@
 int UIMachineDisplayScreenFeaturesEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMachineDisplayScreenFeaturesEditor.h ¶

@@ -42 +42 @@
 public:
 
-    /** Constructs machine display screen features editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIMachineDisplayScreenFeaturesEditor(QWidget *pParent = 0);
 
@@ -65 +65 @@
     void prepare();
 
-    /** Holds the 'enable 3D acceleration' feature value. */
-    bool  m_fEnable3DAcceleration;
+    /** @name Values
+     * @{ */
+        /** Holds the 'enable 3D acceleration' feature value. */
+        bool  m_fEnable3DAcceleration;
+    /** @} */
 
-    /** Holds the main layout instance. */
-    QGridLayout *m_pLayout;
-    /** Holds the label instance. */
-    QLabel      *m_pLabel;
-    /** Holds the 'enable 3D acceleration' check-box instance. */
-    QCheckBox   *m_pCheckBoxEnable3DAcceleration;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout *m_pLayout;
+        /** Holds the label instance. */
+        QLabel      *m_pLabel;
+        /** Holds the 'enable 3D acceleration' check-box instance. */
+        QCheckBox   *m_pCheckBoxEnable3DAcceleration;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMaximumGuestScreenSizeEditor.cpp ¶

@@ -75 +75 @@
     if (m_pComboPolicy)
     {
-        const int iIndex = m_pComboPolicy->findData(QVariant::fromValue(guiValue.m_enmPolicy));
+        const int iIndex = m_pComboPolicy->findData(QVariant::fromValue(m_guiValue.m_enmPolicy));
         if (iIndex != -1)
         {
@@ -85 +85 @@
     if (m_pSpinboxMaxWidth && m_pSpinboxMaxHeight)
     {
-        if (guiValue.m_enmPolicy == MaximumGuestScreenSizePolicy_Fixed)
-        {
-            m_pSpinboxMaxWidth->setValue(guiValue.m_size.width());
-            m_pSpinboxMaxHeight->setValue(guiValue.m_size.height());
+        if (m_guiValue.m_enmPolicy == MaximumGuestScreenSizePolicy_Fixed)
+        {
+            m_pSpinboxMaxWidth->setValue(m_guiValue.m_size.width());
+            m_pSpinboxMaxHeight->setValue(m_guiValue.m_size.height());
         }
     }
@@ -161 +161 @@
         if (m_pSpinboxMaxHeight)
             m_pSpinboxMaxHeight->setEnabled(fComboLevelWidgetsEnabled);
-
-        /* Notify listeners: */
-        emit sigValueChanged(value());
-    }
-}
-
-void UIMaximumGuestScreenSizeEditor::sltHandleSizeChanged()
-{
-    if (m_pSpinboxMaxWidth && m_pSpinboxMaxHeight)
-    {
-        /* Notify listeners: */
-        emit sigValueChanged(value());
     }
 }
@@ -223 +211 @@
             m_pSpinboxMaxWidth->setMinimum(iMinWidth);
             m_pSpinboxMaxWidth->setMaximum(iMaxSize);
-            connect(m_pSpinboxMaxWidth, static_cast<void(QSpinBox::*)(int)>(&QSpinBox::valueChanged),
-                    this, &UIMaximumGuestScreenSizeEditor::sltHandleSizeChanged);
 
             m_pLayout->addWidget(m_pSpinboxMaxWidth, 1, 1);
@@ -244 +230 @@
             m_pSpinboxMaxHeight->setMinimum(iMinHeight);
             m_pSpinboxMaxHeight->setMaximum(iMaxSize);
-            connect(m_pSpinboxMaxHeight, static_cast<void(QSpinBox::*)(int)>(&QSpinBox::valueChanged),
-                    this, &UIMaximumGuestScreenSizeEditor::sltHandleSizeChanged);
 
             m_pLayout->addWidget(m_pSpinboxMaxHeight, 2, 1);
@@ -266 +250 @@
 
         /* Init currently supported maximum guest size policy types: */
-        QList<MaximumGuestScreenSizePolicy> supportedValues = QList<MaximumGuestScreenSizePolicy>()
-                                                          << MaximumGuestScreenSizePolicy_Automatic
-                                                          << MaximumGuestScreenSizePolicy_Any
-                                                          << MaximumGuestScreenSizePolicy_Fixed;
+        const QList<MaximumGuestScreenSizePolicy> supportedValues  = QList<MaximumGuestScreenSizePolicy>()
+                                                                  << MaximumGuestScreenSizePolicy_Automatic
+                                                                  << MaximumGuestScreenSizePolicy_Any
+                                                                  << MaximumGuestScreenSizePolicy_Fixed;
 
         /* Update combo with all the supported values: */

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMaximumGuestScreenSizeEditor.h ¶

@@ -64 +64 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a guiValue change. */
-    void sigValueChanged(const UIMaximumGuestScreenSizeValue &guiValue);
-
 public:
 
-    /** Constructs maximum guest screen size editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIMaximumGuestScreenSizeEditor(QWidget *pParent = 0);
 
@@ -93 +88 @@
     /** Handles current policy index change. */
     void sltHandleCurrentPolicyIndexChanged();
-    /** Handles size change. */
-    void sltHandleSizeChanged();
 
 private:
@@ -106 +99 @@
     UIMaximumGuestScreenSizeValue  m_guiValue;
 
-    /** Holds the main layout: */
-    QGridLayout *m_pLayout;
-    /** Holds the policy label instance. */
-    QLabel      *m_pLabelPolicy;
-    /** Holds the policy combo instance. */
-    QComboBox   *m_pComboPolicy;
-    /** Holds the max width label instance. */
-    QLabel      *m_pLabelMaxWidth;
-    /** Holds the max width spinbox instance. */
-    QSpinBox    *m_pSpinboxMaxWidth;
-    /** Holds the max height label instance. */
-    QLabel      *m_pLabelMaxHeight;
-    /** Holds the max height spinbox instance. */
-    QSpinBox    *m_pSpinboxMaxHeight;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout: */
+        QGridLayout *m_pLayout;
+        /** Holds the policy label instance. */
+        QLabel      *m_pLabelPolicy;
+        /** Holds the policy combo instance. */
+        QComboBox   *m_pComboPolicy;
+        /** Holds the max width label instance. */
+        QLabel      *m_pLabelMaxWidth;
+        /** Holds the max width spinbox instance. */
+        QSpinBox    *m_pSpinboxMaxWidth;
+        /** Holds the max height label instance. */
+        QLabel      *m_pLabelMaxHeight;
+        /** Holds the max height spinbox instance. */
+        QSpinBox    *m_pSpinboxMaxHeight;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMonitorCountEditor.cpp ¶

@@ -64 +64 @@
 int UIMonitorCountEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMonitorCountEditor.h ¶

@@ -47 +47 @@
 public:
 
-    /** Constructs monitor count editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIMonitorCountEditor(QWidget *pParent = 0);
 
@@ -83 +83 @@
     int  m_iValue;
 
-    /** Holds the main layout instance. */
-    QGridLayout      *m_pLayout;
-    /** Holds the main label instance. */
-    QLabel           *m_pLabel;
-    /** Holds the slider instance. */
-    QIAdvancedSlider *m_pSlider;
-    /** Holds the spin-box instance. */
-    QSpinBox         *m_pSpinBox;
-    /** Holds minimum label instance. */
-    QLabel           *m_pLabelMin;
-    /** Holds maximum label instance. */
-    QLabel           *m_pLabelMax;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout      *m_pLayout;
+        /** Holds the main label instance. */
+        QLabel           *m_pLabel;
+        /** Holds the slider instance. */
+        QIAdvancedSlider *m_pSlider;
+        /** Holds the spin-box instance. */
+        QSpinBox         *m_pSpinBox;
+        /** Holds minimum label instance. */
+        QLabel           *m_pLabelMin;
+        /** Holds maximum label instance. */
+        QLabel           *m_pLabelMax;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UINameAndSystemEditor.h ¶

@@ -76 +76 @@
 public:
 
-    /** Constructs VM parameters editor passing @a pParent to the base-class.
+    /** Constructs editor passing @a pParent to the base-class.
      * @param  fChooseName    Controls whether we should propose to choose name.
      * @param  fChoosePath    Controls whether we should propose to choose path.
@@ -173 +173 @@
     ulong selectedEditionIndex() const;
 
-    /** Holds the current family ID list. */
-    QStringList  m_familyIDs;
-
-    /** Holds the current type cache. */
-    QMap<QString, QList<UIGuestOSType> >  m_types;
-
-    /** Holds the VM OS type ID. */
-    QString  m_strTypeId;
-    /** Holds the VM OS family ID. */
-    QString  m_strFamilyId;
-
-    /** Holds the currently chosen OS type IDs on per-family basis. */
-    QMap<QString, QString>  m_currentIds;
-
-    /** Holds whether we should propose to choose a name. */
-    bool  m_fChooseName;
-    /** Holds whether we should propose to choose a path. */
-    bool  m_fChoosePath;
-    /** Holds whether we should propose to choose an image. */
-    bool  m_fChooseImage;
-    /** Holds whether we should propose to choose an edition. */
-    bool  m_fChooseEdition;
-    /** Holds whether we should propose to choose a type. */
-    bool  m_fChooseType;
-    /** Holds whether host supports hardware virtualization. */
-    bool  m_fSupportsHWVirtEx;
-    /** Holds whether host supports long mode. */
-    bool  m_fSupportsLongMode;
-
-    /** Holds the main layout instance. */
-    QGridLayout *m_pLayout;
-
-    /** Holds the VM name label instance. */
-    QLabel *m_pLabelName;
-    /** Holds the VM path label instance. */
-    QLabel *m_pLabelPath;
-    /** Holds the ISO image label instance. */
-    QLabel *m_pLabelImage;
-    /** Holds the edition label instance. */
-    QLabel *m_pLabelEdition;
-    /** Holds the VM OS family label instance. */
-    QLabel *m_pLabelFamily;
-    /** Holds the VM OS type label instance. */
-    QLabel *m_pLabelType;
-    /** Holds the VM OS type icon instance. */
-    QLabel *m_pIconType;
-
-    /** Holds the VM name editor instance. */
-    QILineEdit         *m_pEditorName;
-    /** Holds the VM path editor instance. */
-    UIFilePathSelector *m_pSelectorPath;
-    /** Holds the file selector for ISO image (either for unattended install or to be attached to vm). */
-    UIFilePathSelector *m_pSelectorImage;
-    /** Holds the VM OS edition combo (currently only Windows ISO have this). */
-    QComboBox          *m_pComboEdition;
-    /** Holds the VM OS family combo instance. */
-    QComboBox          *m_pComboFamily;
-    /** Holds the VM OS type combo instance. */
-    QComboBox          *m_pComboType;
+    /** @name Arguments
+     * @{ */
+        /** Holds whether we should propose to choose a name. */
+        bool  m_fChooseName;
+        /** Holds whether we should propose to choose a path. */
+        bool  m_fChoosePath;
+        /** Holds whether we should propose to choose an image. */
+        bool  m_fChooseImage;
+        /** Holds whether we should propose to choose an edition. */
+        bool  m_fChooseEdition;
+        /** Holds whether we should propose to choose a type. */
+        bool  m_fChooseType;
+    /** @} */
+
+    /** @name Options
+     * @{ */
+        /** Holds whether host supports hardware virtualization. */
+        bool  m_fSupportsHWVirtEx;
+        /** Holds whether host supports long mode. */
+        bool  m_fSupportsLongMode;
+    /** @} */
+
+    /** @name Values
+     * @{ */
+        /** Holds the current family ID list. */
+        QStringList  m_familyIDs;
+
+        /** Holds the current type cache. */
+        QMap<QString, QList<UIGuestOSType> >  m_types;
+
+        /** Holds the VM OS type ID. */
+        QString  m_strTypeId;
+        /** Holds the VM OS family ID. */
+        QString  m_strFamilyId;
+
+        /** Holds the currently chosen OS type IDs on per-family basis. */
+        QMap<QString, QString>  m_currentIds;
+    /** @} */
+
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout *m_pLayout;
+
+        /** Holds the VM name label instance. */
+        QLabel *m_pLabelName;
+        /** Holds the VM path label instance. */
+        QLabel *m_pLabelPath;
+        /** Holds the ISO image label instance. */
+        QLabel *m_pLabelImage;
+        /** Holds the edition label instance. */
+        QLabel *m_pLabelEdition;
+        /** Holds the VM OS family label instance. */
+        QLabel *m_pLabelFamily;
+        /** Holds the VM OS type label instance. */
+        QLabel *m_pLabelType;
+        /** Holds the VM OS type icon instance. */
+        QLabel *m_pIconType;
+
+        /** Holds the VM name editor instance. */
+        QILineEdit         *m_pEditorName;
+        /** Holds the VM path editor instance. */
+        UIFilePathSelector *m_pSelectorPath;
+        /** Holds the file selector for ISO image (either for unattended install or to be attached to vm). */
+        UIFilePathSelector *m_pSelectorImage;
+        /** Holds the VM OS edition combo (currently only Windows ISO have this). */
+        QComboBox          *m_pComboEdition;
+        /** Holds the VM OS family combo instance. */
+        QComboBox          *m_pComboFamily;
+        /** Holds the VM OS type combo instance. */
+        QComboBox          *m_pComboType;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UINetworkAttachmentEditor.h ¶

@@ -54 +54 @@
 public:
 
-    /** Constructs network attachment editor passing @a pParent to the base-class.
+    /** Constructs editor passing @a pParent to the base-class.
       * @param  fWithLabels  Brings whether we should add labels ourselves. */
     UINetworkAttachmentEditor(QWidget *pParent = 0, bool fWithLabels = false);

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIScaleFactorEditor.h ¶

@@ -43 +43 @@
 public:
 
-    /** Creates scale factor editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIScaleFactorEditor(QWidget *pParent);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIShortcutConfigurationEditor.h ¶

@@ -37 +37 @@
 public:
 
-    /** Constructs shortcut search functor. */
+    /** Constructs search functor. */
     UIShortcutSearchFunctor() {}
 
@@ -59 +59 @@
 public:
 
-    /** Constructs shortcut configuration item on the basis of passed arguments.
+    /** Constructs item on the basis of passed arguments.
       * @param  strKey              Brings the unique key identifying held sequence.
       * @param  strScope            Brings the scope of the held sequence.
@@ -77 +77 @@
     {}
 
-    /** Constructs shortcut configuration item on the basis of @a another one. */
+    /** Constructs item on the basis of @a another one. */
     UIShortcutConfigurationItem(const UIShortcutConfigurationItem &another)
         : m_strKey(another.key())
@@ -157 +157 @@
 public:
 
-    /** Constructs shortcut configuration editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIShortcutConfigurationEditor(QWidget *pParent = 0);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIUpdateSettingsEditor.cpp ¶

@@ -44 +44 @@
 void UIUpdateSettingsEditor::setValue(const VBoxUpdateData &guiValue)
 {
-    /* Update value if changed: */
+    /* Update cached value and
+     * widgets if value has changed: */
     if (m_guiValue != guiValue)
     {
-        /* Update value itself: */
         m_guiValue = guiValue;
 
-        /* Update check-box if present: */
         if (m_pCheckBox)
         {
@@ -57 +56 @@
             if (m_pCheckBox->isChecked())
             {
-                /* Update period combo if present: */
                 if (m_pComboUpdatePeriod)
                     m_pComboUpdatePeriod->setCurrentIndex(m_guiValue.periodIndex());
-
-                /* Update branch radio-buttons if present: */
                 if (m_mapRadioButtons.value(m_guiValue.branchIndex()))
                     m_mapRadioButtons.value(m_guiValue.branchIndex())->setChecked(true);
             }
 
-            /* Update other related widgets: */
             sltHandleUpdateToggle(m_pCheckBox->isChecked());
         }
@@ -162 +157 @@
 {
     /* Prepare main layout: */
-    QGridLayout *pLayoutMain = new QGridLayout(this);
-    if (pLayoutMain)
-    {
-        pLayoutMain->setContentsMargins(0, 0, 0, 0);
-        pLayoutMain->setRowStretch(2, 1);
+    QGridLayout *pLayout = new QGridLayout(this);
+    if (pLayout)
+    {
+        pLayout->setContentsMargins(0, 0, 0, 0);
+        pLayout->setRowStretch(2, 1);
 
         /* Prepare update check-box: */
         m_pCheckBox = new QCheckBox(this);
         if (m_pCheckBox)
-            pLayoutMain->addWidget(m_pCheckBox, 0, 0, 1, 2);
+            pLayout->addWidget(m_pCheckBox, 0, 0, 1, 2);
 
         /* Prepare 20-px shifting spacer: */
         QSpacerItem *pSpacerItem = new QSpacerItem(20, 0, QSizePolicy::Fixed, QSizePolicy::Minimum);
         if (pSpacerItem)
-            pLayoutMain->addItem(pSpacerItem, 1, 0);
+            pLayout->addItem(pSpacerItem, 1, 0);
 
         /* Prepare update settings widget: */
@@ -256 +251 @@
             }
 
-            pLayoutMain->addWidget(m_pWidgetUpdateSettings, 1, 1);
+            pLayout->addWidget(m_pWidgetUpdateSettings, 1, 1);
         }
     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIUpdateSettingsEditor.h ¶

@@ -43 +43 @@
 public:
 
-    /** Constructs update settings editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIUpdateSettingsEditor(QWidget *pParent = 0);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVRDEAuthLibraryEditor.cpp ¶

@@ -37 +37 @@
 void UIVRDEAuthLibraryEditor::setValue(const QString &strValue)
 {
-    if (m_pSelector)
+    /* Update cached value and
+     * editor if value has changed: */
+    if (m_strValue != strValue)
     {
-        /* Update cached value and editor
-         * if value has changed: */
-        if (m_strValue != strValue)
-        {
-            m_strValue = strValue;
+        m_strValue = strValue;
+        if (m_pSelector)
             m_pSelector->setPath(strValue);
-        }
     }
 }
@@ -56 +54 @@
 int UIVRDEAuthLibraryEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -72 +70 @@
         m_pSelector->setToolTip(tr("Holds the path to the library that provides "
                                    "authentication for Remote Display (VRDP) clients."));
-}
-
-void UIVRDEAuthLibraryEditor::sltHandleSelectorPathChanged()
-{
-    if (m_pSelector)
-        emit sigValueChanged(m_pSelector->path());
 }
 
@@ -105 +97 @@
             m_pSelector->setInitialPath(uiCommon().homeFolder());
             m_pSelector->setMode(UIFilePathSelector::Mode_File_Open);
-            connect(m_pSelector, &UIFilePathSelector::pathChanged,
-                    this, &UIVRDEAuthLibraryEditor::sltHandleSelectorPathChanged);
 
             m_pLayout->addWidget(m_pSelector, 0, 1);

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVRDEAuthLibraryEditor.h ¶

@@ -39 +39 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(const QString &strValue);
-
 public:
 
@@ -64 +59 @@
     virtual void retranslateUi() RT_OVERRIDE;
 
-private slots:
-
-    /** Handles selector path change. */
-    void sltHandleSelectorPathChanged();
-
 private:
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVRDESettingsEditor.cpp ¶

@@ -49 +49 @@
 void UIVRDESettingsEditor::setFeatureEnabled(bool fEnabled)
 {
+    /* Update cached value and
+     * check-box if value has changed: */
     if (m_fFeatureEnabled != fEnabled)
     {
@@ -75 +77 @@
 void UIVRDESettingsEditor::setPort(const QString &strPort)
 {
+    /* Update cached value and
+     * line-edit if value has changed: */
     if (m_strPort != strPort)
     {
@@ -90 +94 @@
 void UIVRDESettingsEditor::setAuthType(const KAuthType &enmType)
 {
+    /* Update cached value and
+     * combo if value has changed: */
     if (m_enmAuthType != enmType)
     {
         m_enmAuthType = enmType;
-        if (m_pComboAuthType)
-        {
-            /* We are doing that *now* because this combo have
-             * dynamical content which depends on cashed value: */
-            repopulateComboAuthType();
-
-            const int iAuthTypePosition = m_pComboAuthType->findData(enmType);
-            m_pComboAuthType->setCurrentIndex(iAuthTypePosition == -1 ? 0 : iAuthTypePosition);
-        }
+        repopulateComboAuthType();
     }
 }
@@ -112 +110 @@
 void UIVRDESettingsEditor::setTimeout(const QString &strTimeout)
 {
+    /* Update cached value and
+     * line-edit if value has changed: */
     if (m_strTimeout != strTimeout)
     {
@@ -127 +127 @@
 void UIVRDESettingsEditor::setMultipleConnectionsAllowed(bool fAllowed)
 {
+    /* Update cached value and
+     * check-box if value has changed: */
     if (m_fMultipleConnectionsAllowed != fAllowed)
     {
@@ -226 +228 @@
         if (m_pWidgetSettings)
         {
-            /* Update widget availability: */
-            sltHandleFeatureToggled(m_pCheckboxFeature->isChecked());
-
             /* Prepare 'settings' layout: */
             QGridLayout *pLayoutRemoteDisplaySettings = new QGridLayout(m_pWidgetSettings);
@@ -307 +306 @@
         }
     }
+
+    /* Update widget availability: */
+    if (m_pCheckboxFeature)
+        sltHandleFeatureToggled(m_pCheckboxFeature->isChecked());
 }
 
@@ -338 +341 @@
         foreach (const KAuthType &enmType, authTypes)
             m_pComboAuthType->addItem(gpConverter->toString(enmType), QVariant::fromValue(enmType));
-    }
-}
+
+        /* Look for proper index to choose: */
+        const int iIndex = m_pComboAuthType->findData(QVariant::fromValue(m_enmAuthType));
+        if (iIndex != -1)
+            m_pComboAuthType->setCurrentIndex(iIndex);
+    }
+}

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVRDESettingsEditor.h ¶

@@ -21 +21 @@
 # pragma once
 #endif
-
-/* Qt includes: */
-#include <QMap>
 
 /* GUI includes: */
@@ -50 +47 @@
 public:
 
-    /** Constructs VRDE settings editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIVRDESettingsEditor(QWidget *pParent = 0);
 
@@ -103 +100 @@
     void repopulateComboAuthType();
 
-    /** @name Variables
+    /** @name Values
      * @{ */
         /** Holds whether feature is enabled. */

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVideoMemoryEditor.cpp ¶

@@ -34 +34 @@
 UIVideoMemoryEditor::UIVideoMemoryEditor(QWidget *pParent /* = 0 */)
     : QIWithRetranslateUI<QWidget>(pParent)
+    , m_iValue(0)
     , m_comGuestOSType(CGuestOSType())
     , m_cGuestScreenCount(1)
@@ -44 +45 @@
     , m_iMaxVRAM(0)
     , m_iMaxVRAMVisible(0)
-    , m_iInitialVRAM(0)
     , m_pLayout(0)
     , m_pLabelMemory(0)
@@ -57 +57 @@
 void UIVideoMemoryEditor::setValue(int iValue)
 {
-    if (m_pSlider)
-    {
-        m_iInitialVRAM = RT_MIN(iValue, m_iMaxVRAM);
-        m_pSlider->setValue(m_iInitialVRAM);
+    /* Update cached value and
+     * slider if value has changed: */
+    if (m_iValue != iValue)
+    {
+        m_iValue = RT_MIN(iValue, m_iMaxVRAM);
+        if (m_pSlider)
+            m_pSlider->setValue(m_iValue);
+
+        /* Update requirements: */
+        updateRequirements();
     }
 }
@@ -66 +72 @@
 int UIVideoMemoryEditor::value() const
 {
-    return m_pSlider ? m_pSlider->value() : 0;
+    return m_pSlider ? m_pSlider->value() : m_iValue;
 }
 
 void UIVideoMemoryEditor::setGuestOSType(const CGuestOSType &comGuestOSType)
 {
-    /* Check if guest OS type really changed: */
-    if (m_comGuestOSType == comGuestOSType)
-        return;
-
-    /* Remember new guest OS type: */
-    m_comGuestOSType = comGuestOSType;
-
-    /* Update requirements: */
-    updateRequirements();
+    /* Update cached value and
+     * requirements if value has changed: */
+    if (m_comGuestOSType != comGuestOSType)
+    {
+        /* Remember new guest OS type: */
+        m_comGuestOSType = comGuestOSType;
+
+        /* Update requirements: */
+        updateRequirements();
+    }
 }
 
 void UIVideoMemoryEditor::setGuestScreenCount(int cGuestScreenCount)
 {
-    /* Check if guest screen count really changed: */
-    if (m_cGuestScreenCount == cGuestScreenCount)
-        return;
-
-    /* Remember new guest screen count: */
-    m_cGuestScreenCount = cGuestScreenCount;
-
-    /* Update requirements: */
-    updateRequirements();
+    /* Update cached value and
+     * requirements if value has changed: */
+    if (m_cGuestScreenCount != cGuestScreenCount)
+    {
+        /* Remember new guest screen count: */
+        m_cGuestScreenCount = cGuestScreenCount;
+
+        /* Update requirements: */
+        updateRequirements();
+    }
 }
 
 void UIVideoMemoryEditor::setGraphicsControllerType(const KGraphicsControllerType &enmGraphicsControllerType)
 {
-    /* Check if graphics controller type really changed: */
-    if (m_enmGraphicsControllerType == enmGraphicsControllerType)
-        return;
-
-    /* Remember new graphics controller type: */
-    m_enmGraphicsControllerType = enmGraphicsControllerType;
-
-    /* Update requirements: */
-    updateRequirements();
+    /* Update cached value and
+     * requirements if value has changed: */
+    if (m_enmGraphicsControllerType != enmGraphicsControllerType)
+    {
+        /* Remember new graphics controller type: */
+        m_enmGraphicsControllerType = enmGraphicsControllerType;
+
+        /* Update requirements: */
+        updateRequirements();
+    }
 }
 
@@ -111 +120 @@
 void UIVideoMemoryEditor::set3DAccelerationSupported(bool fSupported)
 {
-    /* Check if 3D acceleration really changed: */
-    if (m_f3DAccelerationSupported == fSupported)
-        return;
-
-    /* Remember new 3D acceleration: */
-    m_f3DAccelerationSupported = fSupported;
-
-    /* Update requirements: */
-    updateRequirements();
+    /* Update cached value and
+     * requirements if value has changed: */
+    if (m_f3DAccelerationSupported != fSupported)
+    {
+        /* Remember new 3D acceleration: */
+        m_f3DAccelerationSupported = fSupported;
+
+        /* Update requirements: */
+        updateRequirements();
+    }
 }
 
 void UIVideoMemoryEditor::set3DAccelerationEnabled(bool fEnabled)
 {
-    /* Check if 3D acceleration really changed: */
-    if (m_f3DAccelerationEnabled == fEnabled)
-        return;
-
-    /* Remember new 3D acceleration: */
-    m_f3DAccelerationEnabled = fEnabled;
-
-    /* Update requirements: */
-    updateRequirements();
+    /* Update cached value and
+     * requirements if value has changed: */
+    if (m_f3DAccelerationEnabled != fEnabled)
+    {
+        /* Remember new 3D acceleration: */
+        m_f3DAccelerationEnabled = fEnabled;
+
+        /* Update requirements: */
+        updateRequirements();
+    }
 }
 #endif /* VBOX_WITH_3D_ACCELERATION */
@@ -315 +326 @@
             m_iMaxVRAMVisible = 256;
     }
-#endif
+#endif /* VBOX_WITH_3D_ACCELERATION */
 
     /* Adjust visible maximum VRAM to be no less than initial VRAM: */
-    m_iMaxVRAMVisible = qMax(m_iMaxVRAMVisible, m_iInitialVRAM);
+    m_iMaxVRAMVisible = qMax(m_iMaxVRAMVisible, m_iValue);
     /* Adjust visible maximum VRAM to be no less than recommended VRAM: */
     m_iMaxVRAMVisible = qMax(m_iMaxVRAMVisible, iNeedMBytes);

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVideoMemoryEditor.h ¶

@@ -51 +51 @@
 public:
 
-    /** Constructs video-memory editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIVideoMemoryEditor(QWidget *pParent = 0);
 
@@ -106 +106 @@
     static int calculatePageStep(int iMax);
 
-    /** Holds the guest OS type ID. */
-    CGuestOSType             m_comGuestOSType;
-    /** Holds the guest screen count. */
-    int                      m_cGuestScreenCount;
-    /** Holds the graphics controller type. */
-    KGraphicsControllerType  m_enmGraphicsControllerType;
+    /** Holds the value to be selected. */
+    int  m_iValue;
+
+    /** @name Options
+     * @{ */
+        /** Holds the guest OS type ID. */
+        CGuestOSType             m_comGuestOSType;
+        /** Holds the guest screen count. */
+        int                      m_cGuestScreenCount;
+        /** Holds the graphics controller type. */
+        KGraphicsControllerType  m_enmGraphicsControllerType;
 #ifdef VBOX_WITH_3D_ACCELERATION
-    /** Holds whether 3D acceleration is supported. */
-    bool                     m_f3DAccelerationSupported;
-    /** Holds whether 3D acceleration is enabled. */
-    bool                     m_f3DAccelerationEnabled;
+        /** Holds whether 3D acceleration is supported. */
+        bool                     m_f3DAccelerationSupported;
+        /** Holds whether 3D acceleration is enabled. */
+        bool                     m_f3DAccelerationEnabled;
 #endif
 
-    /** Holds the minimum lower limit of VRAM (MiB). */
-    int  m_iMinVRAM;
-    /** Holds the maximum upper limit of VRAM (MiB). */
-    int  m_iMaxVRAM;
-    /** Holds the upper limit of VRAM (MiB) for this dialog.
-      * @note This value is lower than m_iMaxVRAM to save
-      *       careless users from setting useless big values. */
-    int  m_iMaxVRAMVisible;
-    /** Holds the initial VRAM value when the dialog is opened. */
-    int  m_iInitialVRAM;
+        /** Holds the minimum lower limit of VRAM (MiB). */
+        int  m_iMinVRAM;
+        /** Holds the maximum upper limit of VRAM (MiB). */
+        int  m_iMaxVRAM;
+        /** Holds the upper limit of VRAM (MiB) for this dialog.
+          * @note This value is lower than m_iMaxVRAM to save
+          *       careless users from setting useless big values. */
+        int  m_iMaxVRAMVisible;
+    /** @} */
 
-    /** Holds the main layout instance. */
-    QGridLayout      *m_pLayout;
-    /** Holds the memory label instance. */
-    QLabel           *m_pLabelMemory;
-    /** Holds the memory slider instance. */
-    QIAdvancedSlider *m_pSlider;
-    /** Holds minimum memory label instance. */
-    QLabel           *m_pLabelMemoryMin;
-    /** Holds maximum memory label instance. */
-    QLabel           *m_pLabelMemoryMax;
-    /** Holds the memory spin-box instance. */
-    QSpinBox         *m_pSpinBox;
+    /** @name Widgets
+     * @{ */
+        /** Holds the main layout instance. */
+        QGridLayout      *m_pLayout;
+        /** Holds the memory label instance. */
+        QLabel           *m_pLabelMemory;
+        /** Holds the memory slider instance. */
+        QIAdvancedSlider *m_pSlider;
+        /** Holds minimum memory label instance. */
+        QLabel           *m_pLabelMemoryMin;
+        /** Holds maximum memory label instance. */
+        QLabel           *m_pLabelMemoryMax;
+        /** Holds the memory spin-box instance. */
+        QSpinBox         *m_pSpinBox;
+    /** @} */
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVirtualCPUEditor.h ¶

@@ -46 +46 @@
 public:
 
-    /** @param  fWithLabel  Determines whether we should add label ourselves. */
+    /** Constructs editor passing @a pParent to the base-class.
+      * @param  fWithLabel  Determines whether we should add label ourselves. */
     UIVirtualCPUEditor(QWidget *pParent = 0, bool fWithLabel = false);
 

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVisualStateEditor.cpp ¶

@@ -41 +41 @@
 void UIVisualStateEditor::setMachineId(const QUuid &uMachineId)
 {
-    m_uMachineId = uMachineId;
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_uMachineId != uMachineId)
+    {
+        m_uMachineId = uMachineId;
+        populateCombo();
+    }
 }
 
 void UIVisualStateEditor::setValue(UIVisualStateType enmValue)
 {
-    if (m_pCombo)
+    /* Update cached value and
+     * combo if value has changed: */
+    if (m_enmValue != enmValue)
     {
-        /* Update cached value and
-         * combo if value has changed: */
-        if (m_enmValue != enmValue)
-        {
-            m_enmValue = enmValue;
-            populateCombo();
-        }
-
-        /* Look for proper index to choose: */
-        int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
-        if (iIndex != -1)
-            m_pCombo->setCurrentIndex(iIndex);
+        m_enmValue = enmValue;
+        populateCombo();
     }
 }
@@ -70 +68 @@
 int UIVisualStateEditor::minimumLabelHorizontalHint() const
 {
-    return m_pLabel->minimumSizeHint().width();
+    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
 }
 
@@ -93 +91 @@
                                 "as soon as possible, otherwise desired one will be defined."));
     }
-}
-
-void UIVisualStateEditor::sltHandleCurrentIndexChanged()
-{
-    if (m_pCombo)
-        emit sigValueChanged(m_pCombo->itemData(m_pCombo->currentIndex()).value<UIVisualStateType>());
 }
 
@@ -129 +121 @@
                 if (m_pLabel)
                     m_pLabel->setBuddy(m_pCombo);
-                connect(m_pCombo, static_cast<void(QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
-                        this, &UIVisualStateEditor::sltHandleCurrentIndexChanged);
                 pComboLayout->addWidget(m_pCombo);
             }
@@ -181 +171 @@
             m_pCombo->addItem(QString(), QVariant::fromValue(enmType));
 
+        /* Look for proper index to choose: */
+        const int iIndex = m_pCombo->findData(QVariant::fromValue(m_enmValue));
+        if (iIndex != -1)
+            m_pCombo->setCurrentIndex(iIndex);
+
         /* Retranslate finally: */
         retranslateUi();

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIVisualStateEditor.h ¶

@@ -41 +41 @@
     Q_OBJECT;
 
-signals:
-
-    /** Notifies listeners about @a enmValue change. */
-    void sigValueChanged(UIVisualStateType enmValue);
-
 public:
 
-    /** Constructs visual state editor passing @a pParent to the base-class. */
+    /** Constructs editor passing @a pParent to the base-class. */
     UIVisualStateEditor(QWidget *pParent = 0);
 
@@ -71 +66 @@
     /** Handles translation event. */
     virtual void retranslateUi() RT_OVERRIDE;
-
-private slots:
-
-    /** Handles current index change. */
-    void sltHandleCurrentIndexChanged();
 
 private: