Changeset 94516 in vbox

Timestamp:

Apr 7, 2022 2:22:14 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

150861

Message:

FE/Qt: bugref:10205. Parametrize version checker to supress notification center messages when there are no new versions (during manager UI startup)

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• networking/UIUpdateManager.cpp (modified) (3 diffs)
• notificationcenter/UINotificationObjects.cpp (modified) (2 diffs)
• notificationcenter/UINotificationObjects.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/networking/UIUpdateManager.cpp

@@ -51 +51 @@
 
 private:
-#if 0
+
     /** Holds whether this customer has forced privelegies. */
     bool  m_fForcedCall;
-#endif
+
 };
 
@@ -88 +88 @@
 
 UIUpdateStepVirtualBox::UIUpdateStepVirtualBox(bool fForcedCall)
-#if 0
     : m_fForcedCall(fForcedCall)
-#endif
 {
     Q_UNUSED(fForcedCall);
@@ -121 +119 @@
 #else
     UINotificationProgressNewVersionChecker *pNotification =
-        new UINotificationProgressNewVersionChecker();
+        new UINotificationProgressNewVersionChecker(m_fForcedCall);
     connect(pNotification, &UINotificationProgressNewVersionChecker::sigProgressFinished,
             this, &UIUpdateStepVirtualBox::sigStepFinished);

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.cpp

@@ -4311 +4311 @@
 *********************************************************************************************************************************/
 
-UINotificationProgressNewVersionChecker::UINotificationProgressNewVersionChecker()
+UINotificationProgressNewVersionChecker::UINotificationProgressNewVersionChecker(bool fForcedCall)
+    : m_fForcedCall(fForcedCall)
 {
     connect(this, &UINotificationProgress::sigProgressFinished,
@@ -4363 +4364 @@
     }
     else
-        UINotificationMessage::showUpdateNotFound();
+    {
+        if (m_fForcedCall)
+            UINotificationMessage::showUpdateNotFound();
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/notificationcenter/UINotificationObjects.h

@@ -2692 +2692 @@
 public:
 
-    UINotificationProgressNewVersionChecker();
+    UINotificationProgressNewVersionChecker(bool fForcedCall);
 
 protected:
@@ -2710 +2710 @@
 
     CHostUpdate m_comUpdateChecker;
+    /** Holds whether this customer has forced privelegies. */
+    bool        m_fForcedCall;
 };