Changeset 94736 in vbox

Timestamp:

Apr 28, 2022 1:26:10 PM (3 years ago)

Author:

vboxsync

Message:

Main/Update check: Prevent overwriting the agent's default repo URL on loading settings when XML settings are empty. bugref:7983

File:

• trunk/src/VBox/Main/src-server/UpdateAgentImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/UpdateAgentImpl.cpp

@@ -651 +651 @@
     m->enmChannel        = data.enmChannel;
     m->uCheckFreqSeconds = data.uCheckFreqSeconds;
-    m->strRepoUrl        = data.strRepoUrl;
+    if (data.strRepoUrl.isNotEmpty()) /* Prevent overwriting the agent's default URL when XML settings are empty. */
+        m->strRepoUrl    = data.strRepoUrl;
     m->enmProxyMode      = data.enmProxyMode;
     m->strProxyUrl       = data.strProxyUrl;
@@ -867 +868 @@
 {
     RT_NOREF(pTask);
+
+    AssertReturn(m->strRepoUrl.isNotEmpty(), E_INVALIDARG);
 
     // Following the sequence of steps in UIUpdateStepVirtualBox::sltStartStep()