Changeset 94993 in vbox for trunk/src/VBox/Devices/Audio/testcase

Timestamp:

May 12, 2022 1:57:54 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

151418

Message:

Audio: Resolved @todos regarding PDMAudioPropsAreValid() / AudioHlpPcmPropsAreValid():

• Renamed AudioHlpPcmPropsAreValid() -> AudioHlpPcmPropsAreValidAndSupported().
• Don't assert when not supported or invalid (i.e. not set) but just return false. The caller now is responsible for asserting now, if needed.
• Also added unsigned samples support to AudioHlpPcmPropsAreValidAndSupported().

File:

• trunk/src/VBox/Devices/Audio/testcase/tstAudioMixBuffer.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/testcase/tstAudioMixBuffer.cpp

@@ -78 +78 @@
     RTTESTI_CHECK(PDMAudioPropsGetBitrate(&Cfg441StereoU32) == 44100*8*8);
 
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&Cfg441StereoS16));
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&Cfg441StereoU16) == false); /* go figure */
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&Cfg441StereoU32) == false); /* go figure */
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&Cfg441StereoS16));
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&Cfg441StereoU16) == false); /* go figure */
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&Cfg441StereoU32) == false); /* go figure */
 
 
@@ -210 +210 @@
     );
 
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&config));
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&config));
 
     uint32_t cBufSize = _1K;
@@ -658 +658 @@
     uint32_t const         cFrames = RTRandU32Ex(16, RT_ELEMENTS(aSrcFrames));
     PDMAUDIOPCMPROPS const CfgSrc  = PDMAUDIOPCMPROPS_INITIALIZER(2 /*cbSample*/, true /*fSigned*/, 2 /*ch*/, uFromHz, false /*fSwap*/);
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&CfgSrc));
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&CfgSrc));
     AUDIOMIXBUF MixBuf;
     RTTESTI_CHECK_RC_OK_RETV(AudioMixBufInit(&MixBuf, "NewPeekMixBuf", &CfgSrc, cFrames));
@@ -668 +668 @@
     /* Peek state (destination) is uToHz 2ch S16 */
     PDMAUDIOPCMPROPS const CfgDst = PDMAUDIOPCMPROPS_INITIALIZER(2 /*cbSample*/, true /*fSigned*/, 2 /*ch*/, uToHz, false /*fSwap*/);
-    RTTESTI_CHECK(AudioHlpPcmPropsAreValid(&CfgDst));
+    RTTESTI_CHECK(AudioHlpPcmPropsAreValidAndSupported(&CfgDst));
     AUDIOMIXBUFPEEKSTATE PeekState;
     RTTESTI_CHECK_RC_OK_RETV(AudioMixBufInitPeekState(&MixBuf, &PeekState, &CfgDst));