Changeset 95000 in vbox

Timestamp:

May 13, 2022 9:39:42 AM (3 years ago)

Author:

vboxsync

Message:

IPRT/testcase: Made tstFile more flexible by querying file system properties (free space, ++) before we actually perform any tests and clamp accordingly, plus making it more random (for beyond 2GB writes). This is needed because we have test VMs which have less disk space configured than 2GB.

File:

• trunk/src/VBox/Runtime/testcase/tstFile.cpp (modified) (11 diffs)

trunk/src/VBox/Runtime/testcase/tstFile.cpp

@@ -31 +31 @@
 #include <iprt/test.h>
 #include <iprt/file.h>
-#include <iprt/errcore.h>
+#include <iprt/err.h>
+#include <iprt/path.h>
+#include <iprt/rand.h>
 #include <iprt/string.h>
 #include <iprt/stream.h>
@@ -55 +57 @@
 "habitasse platea dictumst.\n";
 
+/**
+ * Structure holding queried file system properties we're performing our tests on.
+ */
+typedef struct FsProps
+{
+    RTFOFF   cbTotal;
+    RTFOFF   cbFree;
+    uint32_t cbBlock;
+    uint32_t cbSector;
+} FsProps;
+/** Queried file system properties we're performing our tests on. */
+static FsProps s_FsProps;
+
 
 static void tstAppend(RTFILE hFile)
@@ -112 +127 @@
     }
 
-    /* grow file beyond 2G */
-    rc = RTFileSetSize(hFile, _2G + _1M);
+    uint64_t cbFileSize = _2G + RTRandU32Ex(_1K, _1M); /* Try growing file beyond 2G by default. */
+    if ((uint64_t)s_FsProps.cbFree <= cbFileSize)
+    {
+        RTTestIPrintf(RTTESTLVL_ALWAYS, "Warning: Free disk space less than testcase file size (%RTfoff vs. %RU64), limiting\n",
+                      s_FsProps.cbFree, cbFileSize);
+        cbFileSize = s_FsProps.cbFree -  _1M; /* Leave a bit of space on the fs. */
+    }
+    /** @todo Also check and clamp for fs max file size limits? */
+    RTTESTI_CHECK_MSG_RETV(cbFileSize, ("No space left on file system (disk full)"));
+
+    rc = RTFileSetSize(hFile, cbFileSize);
     if (RT_FAILURE(rc))
-        RTTestIFailed("Failed to grow file #1 to 2.001GB. rc=%Rrc", rc);
+        RTTestIFailed("Failed to grow file #1 to %RU64. rc=%Rrc", cbFileSize, rc);
     else
     {
         uint64_t cb;
         RTTESTI_CHECK_RC(RTFileQuerySize(hFile, &cb), VINF_SUCCESS);
-        RTTESTI_CHECK_MSG(cb == _2G + _1M, ("RTFileQuerySize return %RX64 bytes, expected %RX64.", cb, _2G + _1M));
+        RTTESTI_CHECK_MSG(cb == cbFileSize, ("RTFileQuerySize return %RX64 bytes, expected %RX64.", cb, cbFileSize));
 
         /*
@@ -172 +196 @@
          * Try some writes at the end of the file.
          */
-        rc = RTFileSeek(hFile, _2G + _1M, RTFILE_SEEK_BEGIN, NULL);
-        if (RT_FAILURE(rc))
-            RTTestIFailed("Failed to seek to _2G + _1M in file #1. rc=%Rrc\n", rc);
+        rc = RTFileSeek(hFile, cbFileSize, RTFILE_SEEK_BEGIN, NULL);
+        if (RT_FAILURE(rc))
+            RTTestIFailed("Failed to seek to %RU64 in file #1. rc=%Rrc\n", cbFileSize, rc);
         else
         {
             offFile = RTFileTell(hFile);
-            if (offFile != _2G + _1M)
-                RTTestIFailed("RTFileTell -> %#llx, expected %#llx (#2)\n", offFile, _2G + _1M);
+            if (offFile != cbFileSize)
+                RTTestIFailed("RTFileTell -> %#llx, expected %#llx (#2)\n", offFile, cbFileSize);
             else
             {
@@ -192 +216 @@
                 }
                 if (RT_FAILURE(rc))
-                    RTTestIFailed("Failed to write to file #1 at offset 2G + 1M.  rc=%Rrc\n", rc);
+                    RTTestIFailed("Failed to write to file #1 at offset %RU64.  rc=%Rrc\n", cbFileSize, rc);
                 else
                 {
@@ -211 +235 @@
                         }
                         if (RT_FAILURE(rc))
-                            RTTestIFailed("Failed to read from file #1 at offset 2G + 1M.  rc=%Rrc\n", rc);
+                            RTTestIFailed("Failed to read from file #1 at offset %RU64. rc=%Rrc\n", cbFileSize, rc);
                         else
                         {
@@ -217 +241 @@
                                 RTPrintf("tstFile: tail write ok\n");
                             else
-                                RTTestIFailed("Data read from file #1 at offset 2G + 1M differs from what we wrote there.\n");
+                                RTTestIFailed("Data read from file #1 at offset %RU64 differs from what we wrote there.\n",
+                                              cbFileSize);
                         }
                     }
@@ -227 +252 @@
          * Some general seeking around.
          */
-        rc = RTFileSeek(hFile, _2G + 1, RTFILE_SEEK_BEGIN, NULL);
-        if (RT_FAILURE(rc))
-            RTTestIFailed("Failed to seek to _2G + 1 in file #1. rc=%Rrc\n", rc);
+        RTFOFF offSeek = RTRandS64Ex(0, cbFileSize);
+        rc = RTFileSeek(hFile, offSeek, RTFILE_SEEK_BEGIN, NULL);
+        if (RT_FAILURE(rc))
+            RTTestIFailed("Failed to seek to %RTfoff in file #1. rc=%Rrc\n", offSeek, rc);
         else
         {
             offFile = RTFileTell(hFile);
-            if (offFile != _2G + 1)
-                RTTestIFailed("RTFileTell -> %#llx, expected %#llx (#3)\n", offFile, _2G + 1);
+            if (offFile != (uint64_t)offSeek)
+                RTTestIFailed("RTFileTell -> %#RTfoff, expected %RTfoff (#3)\n", offFile, offSeek);
         }
 
@@ -244 +270 @@
         {
             offFile = RTFileTell(hFile);
-            if (offFile != _2G + _1M + sizeof(g_szTestStr)) /* assuming tail write was ok. */
-                RTTestIFailed("RTFileTell -> %#RX64, expected %#RX64 (#4)\n", offFile, _2G + _1M + sizeof(g_szTestStr));
+            if (offFile != cbFileSize + sizeof(g_szTestStr)) /* assuming tail write was ok. */
+                RTTestIFailed("RTFileTell -> %RTfoff, expected %#RX64 (#4)\n", offFile, cbFileSize + sizeof(g_szTestStr));
         }
 
@@ -256 +282 @@
             offFile = RTFileTell(hFile);
             if (offFile != 0)
-                RTTestIFailed("RTFileTell -> %#llx, expected 0 (#5)\n", offFile);
+                RTTestIFailed("RTFileTell -> %RTfoff, expected 0 (#5)\n", offFile);
         }
     }
@@ -270 +296 @@
 
     /*
+     * Query file system sizes first.
+     * This is needed beforehand, so that we don't perform tests which cannot succeed because of known limitations
+     * (too little space, file system maximum file size restrictions, ++).
+     */
+    char szCWD[RTPATH_MAX];
+    int rc = RTPathGetCurrent(szCWD, sizeof(szCWD));
+    RTTESTI_CHECK_MSG(RT_SUCCESS(rc), ("Unable to query current directory, rc=%Rrc", rc));
+    rc = RTFsQuerySizes(szCWD, &s_FsProps.cbTotal, &s_FsProps.cbFree, &s_FsProps.cbBlock, &s_FsProps.cbSector);
+    RTTESTI_CHECK_MSG(RT_SUCCESS(rc), ("Unable to query file system sizes of '%s', rc=%Rrc", szCWD, rc));
+
+    /*
      * Some basic tests.
      */
     RTTestSub(hTest, "Basics");
-    int rc = -1;
     RTFILE hFile = NIL_RTFILE;
     RTTESTI_CHECK_RC(rc = RTFileOpen(&hFile, "tstFile#1.tst", RTFILE_O_READWRITE | RTFILE_O_CREATE_REPLACE | RTFILE_O_DENY_NONE),