Changeset 95084 in vbox

Timestamp:

May 24, 2022 8:49:36 PM (3 years ago)

Author:

vboxsync

Message:

IPRT/pipe/win: Added workaround to RTPipeQueryReadable for XP and older where PeekNamedPipe could return a too high value for what's available to read. Seems this issue was addressed in some XP service pack (1?). [comment adjust]

File:

• trunk/src/VBox/Runtime/r3/win/pipe-win.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/pipe-win.cpp

@@ -1213 +1213 @@
          *
          * Prior to XP SP1 (?), the returned cbAvailable value was not adjusted
-         * by read position in the current message/buffer, so it could
-         * potentially be too high.  This could cause the caller to try read
-         * more data than what's actually available, which may cause the read
-         * to block when the caller thought it wouldn't.
+         * by the read position in the current message/buffer, so it could
+         * potentially be too high.  This may cause the caller to try read more
+         * data than what's actually available, which may cause the read to
+         * block when the caller thought it wouldn't.
          *
-         * To get the accurate size, we have to provide and output buffer
-         * and see how much we actually get back in it, as the data peeking
-         * works correctly (as you would expect).
+         * To get an accurate readable size, we have to provide an output
+         * buffer and see how much we actually get back in it, as the data
+         * peeking works correctly (as you would expect).
          */
         if (cbAvailable == 0 || g_enmWinVer >= kRTWinOSType_XP64)