Changeset 95115 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

May 25, 2022 8:53:28 PM (3 years ago)

Author:

vboxsync

Message:

Main/ExtPackManagerImpl: Don't make an extra copy of the llInstalledExtPacks, use std::copy to do the copying instead (c++17).

File:

• trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp

@@ -45 +45 @@
 #include <VBox/sup.h>
 #include <VBox/version.h>
+
+#include <algorithm>
+
 #include "AutoCaller.h"
 #include "Global.h"
@@ -2464 +2467 @@
     AutoReadLock autoLock(this COMMA_LOCKVAL_SRC_POS);
 
-
-    SafeIfaceArray<IExtPack> SaExtPacks(m->llInstalledExtPacks);
-    aInstalledExtPacks.resize(SaExtPacks.size());
-    for(size_t i = 0; i < SaExtPacks.size(); ++i)
-        aInstalledExtPacks[i] = SaExtPacks[i];
+    aInstalledExtPacks.resize(m->llInstalledExtPacks.size());
+    std::copy(m->llInstalledExtPacks.begin(), m->llInstalledExtPacks.end(), aInstalledExtPacks.begin());
 
     return S_OK;