VirtualBox

Changeset 95162 in vbox for trunk/src/VBox


Ignore:
Timestamp:
Jun 1, 2022 1:06:45 PM (3 years ago)
Author:
vboxsync
Message:

FE/Qt/Ds: bugref:6899: Machine settings: System page accessibility improvements (part 3); Moving extended motherboard features stuff into separate UIMotherboardFeaturesEditor widget.

Location:
trunk/src/VBox/Frontends/VirtualBox
Files:
3 edited
2 copied

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Frontends/VirtualBox/Makefile.kmk

    r95160 r95162  
    916916        src/settings/editors/UIMiniToolbarSettingsEditor.h \
    917917        src/settings/editors/UIMonitorCountEditor.h \
     918        src/settings/editors/UIMotherboardFeaturesEditor.h \
    918919        src/settings/editors/UINameAndSystemEditor.h \
    919920        src/settings/editors/UINetworkAttachmentEditor.h \
     
    14881489        src/settings/editors/UIMiniToolbarSettingsEditor.cpp \
    14891490        src/settings/editors/UIMonitorCountEditor.cpp \
     1491        src/settings/editors/UIMotherboardFeaturesEditor.cpp \
    14901492        src/settings/editors/UINameAndSystemEditor.cpp \
    14911493        src/settings/editors/UINetworkAttachmentEditor.cpp \
  • trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMotherboardFeaturesEditor.cpp

    r95161 r95162  
    11/* $Id$ */
    22/** @file
    3  * VBox Qt GUI - UIAudioFeaturesEditor class implementation.
     3 * VBox Qt GUI - UIMotherboardFeaturesEditor class implementation.
    44 */
    55
     
    2222
    2323/* GUI includes: */
    24 #include "UIAudioFeaturesEditor.h"
     24#include "UIMotherboardFeaturesEditor.h"
    2525
    2626
    27 UIAudioFeaturesEditor::UIAudioFeaturesEditor(QWidget *pParent /* = 0 */)
     27UIMotherboardFeaturesEditor::UIMotherboardFeaturesEditor(QWidget *pParent /* = 0 */)
    2828    : QIWithRetranslateUI<QWidget>(pParent)
    29     , m_fEnableOutput(false)
    30     , m_fEnableInput(false)
     29    , m_fEnableIoApic(false)
     30    , m_fEnableEfi(false)
     31    , m_fEnableUtcTime(false)
    3132    , m_pLabel(0)
    32     , m_pCheckBoxEnableOutput(0)
    33     , m_pCheckBoxEnableInput(0)
     33    , m_pCheckBoxEnableIoApic(0)
     34    , m_pCheckBoxEnableEfi(0)
     35    , m_pCheckBoxEnableUtcTime(0)
    3436{
    3537    prepare();
    3638}
    3739
    38 void UIAudioFeaturesEditor::setEnableOutput(bool fOn)
     40void UIMotherboardFeaturesEditor::setEnableIoApic(bool fOn)
    3941{
    4042    /* Update cached value and
    4143     * check-box if value has changed: */
    42     if (m_fEnableOutput != fOn)
     44    if (m_fEnableIoApic != fOn)
    4345    {
    44         m_fEnableOutput = fOn;
    45         if (m_pCheckBoxEnableOutput)
    46             m_pCheckBoxEnableOutput->setCheckState(m_fEnableOutput ? Qt::Checked : Qt::Unchecked);
     46        m_fEnableIoApic = fOn;
     47        if (m_pCheckBoxEnableIoApic)
     48            m_pCheckBoxEnableIoApic->setCheckState(m_fEnableIoApic ? Qt::Checked : Qt::Unchecked);
    4749    }
    4850}
    4951
    50 bool UIAudioFeaturesEditor::outputEnabled() const
     52bool UIMotherboardFeaturesEditor::isEnabledIoApic() const
    5153{
    52     return   m_pCheckBoxEnableOutput
    53            ? m_pCheckBoxEnableOutput->checkState() == Qt::Checked
    54            : m_fEnableOutput;
     54    return   m_pCheckBoxEnableIoApic
     55           ? m_pCheckBoxEnableIoApic->checkState() == Qt::Checked
     56           : m_fEnableIoApic;
    5557}
    5658
    57 void UIAudioFeaturesEditor::setEnableInput(bool fOn)
     59void UIMotherboardFeaturesEditor::setEnableEfi(bool fOn)
    5860{
    5961    /* Update cached value and
    6062     * check-box if value has changed: */
    61     if (m_fEnableInput != fOn)
     63    if (m_fEnableEfi != fOn)
    6264    {
    63         m_fEnableInput = fOn;
    64         if (m_pCheckBoxEnableInput)
    65             m_pCheckBoxEnableInput->setCheckState(m_fEnableInput ? Qt::Checked : Qt::Unchecked);
     65        m_fEnableEfi = fOn;
     66        if (m_pCheckBoxEnableEfi)
     67            m_pCheckBoxEnableEfi->setCheckState(m_fEnableEfi ? Qt::Checked : Qt::Unchecked);
    6668    }
    6769}
    6870
    69 bool UIAudioFeaturesEditor::inputEnabled() const
     71bool UIMotherboardFeaturesEditor::isEnabledEfi() const
    7072{
    71     return   m_pCheckBoxEnableInput
    72            ? m_pCheckBoxEnableInput->checkState() == Qt::Checked
    73            : m_fEnableInput;
     73    return   m_pCheckBoxEnableEfi
     74           ? m_pCheckBoxEnableEfi->checkState() == Qt::Checked
     75           : m_fEnableEfi;
    7476}
    7577
    76 int UIAudioFeaturesEditor::minimumLabelHorizontalHint() const
     78void UIMotherboardFeaturesEditor::setEnableUtcTime(bool fOn)
     79{
     80    /* Update cached value and
     81     * check-box if value has changed: */
     82    if (m_fEnableUtcTime != fOn)
     83    {
     84        m_fEnableUtcTime = fOn;
     85        if (m_pCheckBoxEnableUtcTime)
     86            m_pCheckBoxEnableUtcTime->setCheckState(m_fEnableUtcTime ? Qt::Checked : Qt::Unchecked);
     87    }
     88}
     89
     90bool UIMotherboardFeaturesEditor::isEnabledUtcTime() const
     91{
     92    return   m_pCheckBoxEnableUtcTime
     93           ? m_pCheckBoxEnableUtcTime->checkState() == Qt::Checked
     94           : m_fEnableUtcTime;
     95}
     96
     97int UIMotherboardFeaturesEditor::minimumLabelHorizontalHint() const
    7798{
    7899    return m_pLabel ? m_pLabel->minimumSizeHint().width() : 0;
    79100}
    80101
    81 void UIAudioFeaturesEditor::setMinimumLayoutIndent(int iIndent)
     102void UIMotherboardFeaturesEditor::setMinimumLayoutIndent(int iIndent)
    82103{
    83104    if (m_pLayout)
     
    85106}
    86107
    87 void UIAudioFeaturesEditor::retranslateUi()
     108void UIMotherboardFeaturesEditor::retranslateUi()
    88109{
    89110    if (m_pLabel)
    90111        m_pLabel->setText(tr("Extended Features:"));
    91     if (m_pCheckBoxEnableOutput)
     112    if (m_pCheckBoxEnableIoApic)
    92113    {
    93         m_pCheckBoxEnableOutput->setText(tr("Enable Audio &Output"));
    94         m_pCheckBoxEnableOutput->setToolTip(tr("When checked, output to the virtual audio device will reach the host. "
    95                                                "Otherwise the guest is muted."));
     114        m_pCheckBoxEnableIoApic->setText(tr("Enable &I/O APIC"));
     115        m_pCheckBoxEnableIoApic->setToolTip(tr("When checked, the virtual machine will support the Input Output APIC (I/O APIC), "
     116                                               "which may slightly decrease performance. <b>Note:</b> don't disable this feature "
     117                                               "after having installed a Windows guest operating system!"));
    96118    }
    97     if (m_pCheckBoxEnableInput)
     119    if (m_pCheckBoxEnableEfi)
    98120    {
    99         m_pCheckBoxEnableInput->setText(tr("Enable Audio &Input"));
    100         m_pCheckBoxEnableInput->setToolTip(tr("When checked, the guest will be able to capture audio input from the host. "
    101                                               "Otherwise the guest will capture only silence."));
     121        m_pCheckBoxEnableEfi->setText(tr("Enable &EFI (special OSes only)"));
     122        m_pCheckBoxEnableEfi->setToolTip(tr("When checked, the guest will support the Extended Firmware Interface (EFI), "
     123                                            "which is required to boot certain guest OSes. Non-EFI aware OSes will not be able "
     124                                            "to boot if this option is activated."));
     125    }
     126    if (m_pCheckBoxEnableUtcTime)
     127    {
     128        m_pCheckBoxEnableUtcTime->setText(tr("Hardware Clock in &UTC Time"));
     129        m_pCheckBoxEnableUtcTime->setToolTip(tr("When checked, the RTC device will report the time in UTC, otherwise in local "
     130                                                "(host) time. Unix usually expects the hardware clock to be set to UTC."));
    102131    }
    103132}
    104133
    105 void UIAudioFeaturesEditor::prepare()
     134void UIMotherboardFeaturesEditor::prepare()
    106135{
    107136    /* Prepare main layout: */
     
    119148            m_pLayout->addWidget(m_pLabel, 0, 0);
    120149        }
    121         /* Prepare 'enable output' check-box: */
    122         m_pCheckBoxEnableOutput = new QCheckBox(this);
    123         if (m_pCheckBoxEnableOutput)
    124             m_pLayout->addWidget(m_pCheckBoxEnableOutput, 0, 1);
    125         /* Prepare 'enable input' check-box: */
    126         m_pCheckBoxEnableInput = new QCheckBox(this);
    127         if (m_pCheckBoxEnableInput)
    128             m_pLayout->addWidget(m_pCheckBoxEnableInput, 1, 1);
     150        /* Prepare 'enable IO APIC' check-box: */
     151        m_pCheckBoxEnableIoApic = new QCheckBox(this);
     152        if (m_pCheckBoxEnableIoApic)
     153        {
     154            connect(m_pCheckBoxEnableIoApic, &QCheckBox::stateChanged,
     155                    this, &UIMotherboardFeaturesEditor::sigChangedIoApic);
     156            m_pLayout->addWidget(m_pCheckBoxEnableIoApic, 0, 1);
     157        }
     158        /* Prepare 'enable EFI' check-box: */
     159        m_pCheckBoxEnableEfi = new QCheckBox(this);
     160        if (m_pCheckBoxEnableEfi)
     161        {
     162            connect(m_pCheckBoxEnableEfi, &QCheckBox::stateChanged,
     163                    this, &UIMotherboardFeaturesEditor::sigChangedEfi);
     164            m_pLayout->addWidget(m_pCheckBoxEnableEfi, 1, 1);
     165        }
     166        /* Prepare 'enable UTC time' check-box: */
     167        m_pCheckBoxEnableUtcTime = new QCheckBox(this);
     168        if (m_pCheckBoxEnableUtcTime)
     169        {
     170            connect(m_pCheckBoxEnableUtcTime, &QCheckBox::stateChanged,
     171                    this, &UIMotherboardFeaturesEditor::sigChangedUtcTime);
     172            m_pLayout->addWidget(m_pCheckBoxEnableUtcTime, 2, 1);
     173        }
    129174    }
    130175
  • trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIMotherboardFeaturesEditor.h

    r95161 r95162  
    11/* $Id$ */
    22/** @file
    3  * VBox Qt GUI - UIAudioFeaturesEditor class declaration.
     3 * VBox Qt GUI - UIMotherboardFeaturesEditor class declaration.
    44 */
    55
     
    1616 */
    1717
    18 #ifndef FEQT_INCLUDED_SRC_settings_editors_UIAudioFeaturesEditor_h
    19 #define FEQT_INCLUDED_SRC_settings_editors_UIAudioFeaturesEditor_h
     18#ifndef FEQT_INCLUDED_SRC_settings_editors_UIMotherboardFeaturesEditor_h
     19#define FEQT_INCLUDED_SRC_settings_editors_UIMotherboardFeaturesEditor_h
    2020#ifndef RT_WITHOUT_PRAGMA_ONCE
    2121# pragma once
     
    3030class QLabel;
    3131
    32 /** QWidget subclass used as audio features editor. */
    33 class SHARED_LIBRARY_STUFF UIAudioFeaturesEditor : public QIWithRetranslateUI<QWidget>
     32/** QWidget subclass used as motherboard features editor. */
     33class SHARED_LIBRARY_STUFF UIMotherboardFeaturesEditor : public QIWithRetranslateUI<QWidget>
    3434{
    3535    Q_OBJECT;
     36
     37signals:
     38
     39    /** Notifies listeners about IO APIC change. */
     40    void sigChangedIoApic();
     41    /** Notifies listeners about EFI change. */
     42    void sigChangedEfi();
     43    /** Notifies listeners about UTC time change. */
     44    void sigChangedUtcTime();
    3645
    3746public:
    3847
    3948    /** Constructs editor passing @a pParent to the base-class. */
    40     UIAudioFeaturesEditor(QWidget *pParent = 0);
     49    UIMotherboardFeaturesEditor(QWidget *pParent = 0);
    4150
    42     /** Defines whether 'enable output' feature in @a fOn. */
    43     void setEnableOutput(bool fOn);
    44     /** Returns 'enable output' feature value. */
    45     bool outputEnabled() const;
     51    /** Defines whether 'enable IO APIC' feature in @a fOn. */
     52    void setEnableIoApic(bool fOn);
     53    /** Returns 'enable IO APIC' feature value. */
     54    bool isEnabledIoApic() const;
    4655
    47     /** Defines whether 'enable input' feature in @a fOn. */
    48     void setEnableInput(bool fOn);
    49     /** Returns 'enable input' feature value. */
    50     bool inputEnabled() const;
     56    /** Defines whether 'enable EFI' feature in @a fOn. */
     57    void setEnableEfi(bool fOn);
     58    /** Returns 'enable EFI' feature value. */
     59    bool isEnabledEfi() const;
     60
     61    /** Defines whether 'enable UTC time' feature in @a fOn. */
     62    void setEnableUtcTime(bool fOn);
     63    /** Returns 'enable UTC time' feature value. */
     64    bool isEnabledUtcTime() const;
    5165
    5266    /** Returns minimum layout hint. */
     
    6781    /** @name Values
    6882     * @{ */
    69         /** Holds the 'enable output' feature value. */
    70         bool  m_fEnableOutput;
    71         /** Holds the 'enable input' feature value. */
    72         bool  m_fEnableInput;
     83        /** Holds the 'enable IO APIC' feature value. */
     84        bool  m_fEnableIoApic;
     85        /** Holds the 'enable EFI' feature value. */
     86        bool  m_fEnableEfi;
     87        /** Holds the 'enable UTC time' feature value. */
     88        bool  m_fEnableUtcTime;
    7389    /** @} */
    7490
     
    7995        /** Holds the label instance. */
    8096        QLabel      *m_pLabel;
    81         /** Holds the 'enable output' check-box instance. */
    82         QCheckBox   *m_pCheckBoxEnableOutput;
    83         /** Holds the 'enable input' check-box instance. */
    84         QCheckBox   *m_pCheckBoxEnableInput;
     97        /** Holds the 'enable IO APIC' check-box instance. */
     98        QCheckBox   *m_pCheckBoxEnableIoApic;
     99        /** Holds the 'enable EFI' check-box instance. */
     100        QCheckBox   *m_pCheckBoxEnableEfi;
     101        /** Holds the 'enable UTC time' check-box instance. */
     102        QCheckBox   *m_pCheckBoxEnableUtcTime;
    85103    /** @} */
    86104};
    87105
    88 #endif /* !FEQT_INCLUDED_SRC_settings_editors_UIAudioFeaturesEditor_h */
     106#endif /* !FEQT_INCLUDED_SRC_settings_editors_UIMotherboardFeaturesEditor_h */
  • trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

    r95160 r95162  
    3636#include "UIIconPool.h"
    3737#include "UIMachineSettingsSystem.h"
     38#include "UIMotherboardFeaturesEditor.h"
    3839#include "UIPointingHIDEditor.h"
    3940#include "UITranslator.h"
     
    164165    , m_pEditorChipset(0)
    165166    , m_pEditorPointingHID(0)
    166     , m_pLabelExtendedMotherboard(0)
    167     , m_pCheckBoxAPIC(0)
    168     , m_pCheckBoxEFI(0)
    169     , m_pCheckBoxUTC(0)
     167    , m_pEditorMotherboardFeatures(0)
    170168    , m_pTabProcessor(0)
    171169    , m_pLabelProcessorCount(0)
     
    330328    if (m_pEditorPointingHID)
    331329        m_pEditorPointingHID->setValue(oldSystemData.m_pointingHIDType);
    332     if (m_pCheckBoxAPIC)
    333         m_pCheckBoxAPIC->setChecked(oldSystemData.m_fEnabledIoApic);
    334     if (m_pCheckBoxEFI)
    335         m_pCheckBoxEFI->setChecked(oldSystemData.m_fEnabledEFI);
    336     if (m_pCheckBoxUTC)
    337         m_pCheckBoxUTC->setChecked(oldSystemData.m_fEnabledUTC);
     330    if (m_pEditorMotherboardFeatures)
     331    {
     332        m_pEditorMotherboardFeatures->setEnableIoApic(oldSystemData.m_fEnabledIoApic);
     333        m_pEditorMotherboardFeatures->setEnableEfi(oldSystemData.m_fEnabledEFI);
     334        m_pEditorMotherboardFeatures->setEnableUtcTime(oldSystemData.m_fEnabledUTC);
     335    }
    338336
    339337    /* Load old 'Processor' data from cache: */
     
    389387    if (m_pEditorPointingHID)
    390388        newSystemData.m_pointingHIDType = m_pEditorPointingHID->value();
    391     if (   m_pCheckBoxAPIC
     389    if (   m_pEditorMotherboardFeatures
    392390        && m_pSliderProcessorCount
    393391        && m_pEditorChipset)
    394         newSystemData.m_fEnabledIoApic =    m_pCheckBoxAPIC->isChecked()
     392        newSystemData.m_fEnabledIoApic =    m_pEditorMotherboardFeatures->isEnabledIoApic()
    395393                                         || m_pSliderProcessorCount->value() > 1
    396394                                         || m_pEditorChipset->value() == KChipsetType_ICH9;
    397     if (m_pCheckBoxEFI)
    398         newSystemData.m_fEnabledEFI = m_pCheckBoxEFI->isChecked();
    399     if (m_pCheckBoxUTC)
    400         newSystemData.m_fEnabledUTC = m_pCheckBoxUTC->isChecked();
     395    if (m_pEditorMotherboardFeatures)
     396        newSystemData.m_fEnabledEFI = m_pEditorMotherboardFeatures->isEnabledEfi();
     397    if (m_pEditorMotherboardFeatures)
     398        newSystemData.m_fEnabledUTC = m_pEditorMotherboardFeatures->isEnabledUtcTime();
    401399
    402400    /* Gather 'Processor' data: */
     
    474472
    475473        /* Chipset type vs IO-APIC test: */
    476         if (m_pEditorChipset->value() == KChipsetType_ICH9 && !m_pCheckBoxAPIC->isChecked())
     474        if (m_pEditorChipset->value() == KChipsetType_ICH9 && !m_pEditorMotherboardFeatures->isEnabledIoApic())
    477475        {
    478476            message.second << tr(
     
    521519
    522520        /* VCPU vs IO-APIC test: */
    523         if (m_pSliderProcessorCount->value() > 1 && !m_pCheckBoxAPIC->isChecked())
     521        if (m_pSliderProcessorCount->value() > 1 && !m_pEditorMotherboardFeatures->isEnabledIoApic())
    524522        {
    525523            message.second << tr(
     
    626624    setTabOrder(m_pEditorBootOrder, m_pEditorChipset);
    627625    setTabOrder(m_pEditorChipset, m_pEditorPointingHID);
    628     setTabOrder(m_pEditorPointingHID, m_pCheckBoxAPIC);
    629     setTabOrder(m_pCheckBoxAPIC, m_pCheckBoxEFI);
    630     setTabOrder(m_pCheckBoxEFI, m_pCheckBoxUTC);
     626    setTabOrder(m_pEditorPointingHID, m_pEditorMotherboardFeatures);
     627    setTabOrder(m_pEditorMotherboardFeatures, m_pSliderProcessorCount);
    631628
    632629    /* Configure navigation for 'processor' tab: */
    633     setTabOrder(m_pCheckBoxUTC, m_pSliderProcessorCount);
    634630    setTabOrder(m_pSliderProcessorCount, m_pSpinboxProcessorCount);
    635631    setTabOrder(m_pSpinboxProcessorCount, m_pSliderProcessorExecCap);
     
    653649                                        "checkboxes on the left to enable or disable individual boot devices. "
    654650                                        "Move items up and down to change the device order."));
    655     m_pLabelExtendedMotherboard->setText(tr("Extended Features:"));
    656     m_pCheckBoxAPIC->setToolTip(tr("When checked, the virtual machine will support the Input Output APIC (I/O APIC), "
    657                                    "which may slightly decrease performance. <b>Note:</b> don't disable this feature after "
    658                                    "having installed a Windows guest operating system!"));
    659     m_pCheckBoxAPIC->setText(tr("Enable &I/O APIC"));
    660     m_pCheckBoxEFI->setToolTip(tr("When checked, the guest will support the Extended Firmware Interface (EFI), "
    661                                   "which is required to boot certain guest OSes. Non-EFI aware OSes will not be able to boot "
    662                                   "if this option is activated."));
    663     m_pCheckBoxEFI->setText(tr("Enable &EFI (special OSes only)"));
    664     m_pCheckBoxUTC->setToolTip(tr("When checked, the RTC device will report the time in UTC, otherwise in local (host) time. "
    665                                   "Unix usually expects the hardware clock to be set to UTC."));
    666     m_pCheckBoxUTC->setText(tr("Hardware Clock in &UTC Time"));
    667651    m_pTabWidget->setTabText(m_pTabWidget->indexOf(m_pTabMotherboard), tr("&Motherboard"));
    668652    m_pLabelProcessorCount->setText(tr("&Processor(s):"));
     
    718702    iMinimumLayoutHint = qMax(iMinimumLayoutHint, m_pEditorChipset->minimumLabelHorizontalHint());
    719703    iMinimumLayoutHint = qMax(iMinimumLayoutHint, m_pEditorPointingHID->minimumLabelHorizontalHint());
    720     iMinimumLayoutHint = qMax(iMinimumLayoutHint, m_pLabelExtendedMotherboard->minimumSizeHint().width());
     704    iMinimumLayoutHint = qMax(iMinimumLayoutHint, m_pEditorMotherboardFeatures->minimumLabelHorizontalHint());
    721705    m_pEditorChipset->setMinimumLayoutIndent(iMinimumLayoutHint);
    722706    m_pEditorPointingHID->setMinimumLayoutIndent(iMinimumLayoutHint);
     707    m_pEditorMotherboardFeatures->setMinimumLayoutIndent(iMinimumLayoutHint);
    723708}
    724709
     
    735720    m_pEditorChipset->setEnabled(isMachineOffline());
    736721    m_pEditorPointingHID->setEnabled(isMachineOffline());
    737     m_pLabelExtendedMotherboard->setEnabled(isMachineOffline());
    738     m_pCheckBoxAPIC->setEnabled(isMachineOffline());
    739     m_pCheckBoxEFI->setEnabled(isMachineOffline());
    740     m_pCheckBoxUTC->setEnabled(isMachineOffline());
     722    m_pEditorMotherboardFeatures->setEnabled(isMachineOffline());
    741723
    742724    /* Polish 'Processor' availability: */
     
    916898                pLayoutMotherboard->addWidget(m_pEditorPointingHID, 5, 0, 1, 3);
    917899
    918             /* Prepare extended motherboard label: */
    919             m_pLabelExtendedMotherboard = new QLabel(m_pTabMotherboard);
    920             if (m_pLabelExtendedMotherboard)
    921             {
    922                 m_pLabelExtendedMotherboard->setAlignment(Qt::AlignRight | Qt::AlignVCenter);
    923                 pLayoutMotherboard->addWidget(m_pLabelExtendedMotherboard, 6, 0);
    924             }
    925             /* Prepare APIC check-box: */
    926             m_pCheckBoxAPIC = new QCheckBox(m_pTabMotherboard);
    927             if (m_pCheckBoxAPIC)
    928             {
    929                 m_pCheckBoxAPIC->setObjectName(QStringLiteral("m_pCheckBoxAPIC"));
    930                 pLayoutMotherboard->addWidget(m_pCheckBoxAPIC, 6, 1, 1, 3);
    931             }
    932             /* Prepare EFI check-box: */
    933             m_pCheckBoxEFI = new QCheckBox(m_pTabMotherboard);
    934             if (m_pCheckBoxEFI)
    935             {
    936                 m_pCheckBoxEFI->setObjectName(QStringLiteral("m_pCheckBoxEFI"));
    937                 pLayoutMotherboard->addWidget(m_pCheckBoxEFI, 7, 1, 1, 3);
    938             }
    939             /* Prepare UTC check-box: */
    940             m_pCheckBoxUTC = new QCheckBox(m_pTabMotherboard);
    941             if (m_pCheckBoxUTC)
    942             {
    943                 m_pCheckBoxUTC->setObjectName(QStringLiteral("m_pCheckBoxUTC"));
    944                 pLayoutMotherboard->addWidget(m_pCheckBoxUTC, 8, 1, 1, 3);
    945             }
     900            /* Prepare motherboard features editor: */
     901            m_pEditorMotherboardFeatures = new UIMotherboardFeaturesEditor(m_pTabMotherboard);
     902            if (m_pEditorMotherboardFeatures)
     903                pLayoutMotherboard->addWidget(m_pEditorMotherboardFeatures, 6, 0, 1, 3);
    946904        }
    947905
     
    12051163    connect(m_pEditorPointingHID, &UIPointingHIDEditor::sigValueChanged,
    12061164            this, &UIMachineSettingsSystem::revalidate);
    1207     connect(m_pEditorBaseMemory, &UIBaseMemoryEditor::sigValidChanged, this, &UIMachineSettingsSystem::revalidate);
    1208     connect(m_pCheckBoxAPIC, &QCheckBox::stateChanged, this, &UIMachineSettingsSystem::revalidate);
     1165    connect(m_pEditorBaseMemory, &UIBaseMemoryEditor::sigValidChanged,
     1166            this, &UIMachineSettingsSystem::revalidate);
     1167    connect(m_pEditorMotherboardFeatures, &UIMotherboardFeaturesEditor::sigChangedIoApic,
     1168            this, &UIMachineSettingsSystem::revalidate);
    12091169
    12101170    /* Configure 'Processor' connections: */
  • trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.h

    r95160 r95162  
    2828struct UIDataSettingsMachineSystem;
    2929typedef UISettingsCache<UIDataSettingsMachineSystem> UISettingsCacheMachineSystem;
    30 class CMachine;
    3130class QCheckBox;
    3231class QComboBox;
     
    3837class UIBootOrderEditor;
    3938class UIChipsetEditor;
     39class UIMotherboardFeaturesEditor;
    4040class UIPointingHIDEditor;
     41class CMachine;
    4142
    4243/** Machine settings: System page. */
     
    176177
    177178        /** Holds the 'Motherboard' tab instance. */
    178         QWidget             *m_pTabMotherboard;
     179        QWidget                     *m_pTabMotherboard;
    179180        /** Holds the base memory label instance. */
    180         QLabel              *m_pLabelBaseMemory;
     181        QLabel                      *m_pLabelBaseMemory;
    181182        /** Holds the base memory editor instance. */
    182         UIBaseMemoryEditor  *m_pEditorBaseMemory;
     183        UIBaseMemoryEditor          *m_pEditorBaseMemory;
    183184        /** Holds the boot order label instance. */
    184         QLabel              *m_pLabelBootOrder;
     185        QLabel                      *m_pLabelBootOrder;
    185186        /** Holds the boot order editor instance. */
    186         UIBootOrderEditor   *m_pEditorBootOrder;
     187        UIBootOrderEditor           *m_pEditorBootOrder;
    187188        /** Holds the chipset editor instance. */
    188         UIChipsetEditor     *m_pEditorChipset;
    189         /** Holds the pointing HID combo instance. */
    190         UIPointingHIDEditor *m_pEditorPointingHID;
    191         /** Holds the extended motherboard label instance. */
    192         QLabel              *m_pLabelExtendedMotherboard;
    193         /** Holds the APIC check-box instance. */
    194         QCheckBox           *m_pCheckBoxAPIC;
    195         /** Holds the EFI check-box instance. */
    196         QCheckBox           *m_pCheckBoxEFI;
    197         /** Holds the UTC check-box instance. */
    198         QCheckBox           *m_pCheckBoxUTC;
     189        UIChipsetEditor             *m_pEditorChipset;
     190        /** Holds the pointing HID editor instance. */
     191        UIPointingHIDEditor         *m_pEditorPointingHID;
     192        /** Holds the motherboard features editor instance. */
     193        UIMotherboardFeaturesEditor *m_pEditorMotherboardFeatures;
    199194
    200195        /** Holds the 'Processor' tab instance. */
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette