Changeset 95191 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video

Timestamp:

Jun 3, 2022 6:49:41 PM (3 years ago)

Author:

vboxsync

Message:

WDDM: render should output all patch locations; when allocation is deleted then detach it from VidPN source if necessary. bugref:9845

Location:

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm

Files:

• VBoxMPTypes.h (modified) (1 diff)
• VBoxMPWddm.cpp (modified) (3 diffs)
• VBoxMPWddm.h (modified) (2 diffs)
• gallium/VBoxMPDX.cpp (modified) (8 diffs)
• gallium/VBoxMPGaWddm.cpp (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPTypes.h

@@ -202 +202 @@
 #endif
     VBOXUHGSMI_BUFFER_TYPE_FLAGS fUhgsmiType;
+    int                         CurVidPnSourceId;              /* Source index if used for a source, otherwise -1. */
 #ifdef VBOX_WITH_VMSVGA3D_DX
     /* Direct3D driver data for .enmType == VBOXWDDM_ALLOC_TYPE_D3D. */

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPWddm.cpp

@@ -2140 +2140 @@
             KeInitializeSpinLock(&pAllocation->OpenLock);
             InitializeListHead(&pAllocation->OpenList);
+            pAllocation->CurVidPnSourceId = -1;
 
             switch (pAllocInfo->enmType)
@@ -2395 +2396 @@
     vboxVDbgBreakFv();
 
+    PVBOXMP_DEVEXT pDevExt = (PVBOXMP_DEVEXT)hAdapter;
+
+    for (UINT i = 0; i < pDestroyAllocation->NumAllocations; ++i)
+    {
+        PVBOXWDDM_ALLOCATION pAllocation = (PVBOXWDDM_ALLOCATION)pDestroyAllocation->pAllocationList[0];
+        if (pAllocation->CurVidPnSourceId != -1)
+        {
+            VBOXWDDM_SOURCE *pSource = &pDevExt->aSources[pAllocation->CurVidPnSourceId];
+            vboxWddmAssignPrimary(pSource, NULL, pAllocation->CurVidPnSourceId);
+        }
+    }
+
 #ifdef VBOX_WITH_VMSVGA3D_DX
     /* Check if this is a request from the D3D driver. */
@@ -2408 +2421 @@
 
     PVBOXWDDM_RESOURCE pRc = (PVBOXWDDM_RESOURCE)pDestroyAllocation->hResource;
-    PVBOXMP_DEVEXT pDevExt = (PVBOXMP_DEVEXT)hAdapter;
-
     if (pRc)
     {

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPWddm.h

@@ -122 +122 @@
         pOldAlloc->bAssigned = FALSE;
         Assert(pOldAlloc->AllocData.SurfDesc.VidPnSourceId == srcId);
+        pOldAlloc->CurVidPnSourceId = -1;
     }
 
@@ -129 +130 @@
         pAllocation->bAssigned = TRUE;
         pAllocation->bVisible = pSource->bVisible;
+        pAllocation->CurVidPnSourceId = srcId;
 
         if (pSource->AllocData.hostID != pAllocation->AllocData.hostID)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/VBoxMPDX.cpp

@@ -215 +215 @@
         pAllocation->dx.SegmentId = 2;
     }
+    else
+        AssertFailedReturn(STATUS_INVALID_PARAMETER);
+
     pAllocationInfo->EvictionSegmentSet              = 0;
     pAllocationInfo->MaximumRenamingListLength       = 1;
@@ -343 +346 @@
     pAllocation->dx.pMDL = 0;
 
-    /* Legacy. Unused. */
     KeInitializeSpinLock(&pAllocation->OpenLock);
     InitializeListHead(&pAllocation->OpenList);
+    pAllocation->CurVidPnSourceId = -1;
 
     if (pAllocation->dx.desc.enmAllocationType == VBOXDXALLOCATIONTYPE_SURFACE)
@@ -372 +375 @@
     AssertReturn(pAllocation->enmType == VBOXWDDM_ALLOC_TYPE_D3D, STATUS_INVALID_PARAMETER);
 
+    Assert(pAllocation->cOpens == 0);
+
     if (pAllocation->dx.desc.enmAllocationType == VBOXDXALLOCATIONTYPE_SURFACE)
         Status = svgaDestroyAllocationSurface(pDevExt->pGa->hw.pSvga, pAllocation);
@@ -429 +434 @@
     for (unsigned i = 0; i < pRender->PatchLocationListInSize; ++i)
     {
+        if (cOut >= pRender->PatchLocationListOutSize)
+        {
+            /** @todo Merge generation of patches witht SvgaRenderCommandsD3D in order to correctly
+             * split a command buffer in case of STATUS_GRAPHICS_INSUFFICIENT_DMA_BUFFER?
+             */
+            DEBUG_BREAKPOINT_TEST();
+            Status = STATUS_GRAPHICS_INSUFFICIENT_DMA_BUFFER;
+            break;
+        }
+
         D3DDDI_PATCHLOCATIONLIST const *pIn = &pRender->pPatchLocationListIn[i];
         void * const pPatchAddress = (uint8_t *)pvDmaBuffer + pIn->PatchOffset;
         VBOXDXALLOCATIONTYPE const enmAllocationType = (VBOXDXALLOCATIONTYPE)pIn->DriverId;
+
+        /* "Even though the driver's DxgkDdiRender function pre-patches the DMA buffer, the driver
+         *  must still insert all of the references to allocations into the output patch-location list
+         *  that the pPatchLocationListOut member of DXGKARG_RENDER specifies."
+         */
+        pRender->pPatchLocationListOut[cOut] = *pIn;
 
         DXGK_ALLOCATIONLIST *pAllocationListEntry = &pRender->pAllocationList[pIn->AllocationIndex];
@@ -442 +463 @@
             if (enmAllocationType == VBOXDXALLOCATIONTYPE_SURFACE)
             {
-                /* Surfaces might also need a mobid. */
-                if (pAllocationListEntry->SegmentId == 3)
-                {
-                    /* DEFAULT resources only require the sid, because they exist outside the guest. */
-                    Assert(pAllocation->dx.sid != SVGA3D_INVALID_ID);
-                    Assert(pAllocation->dx.mobid != SVGA3D_INVALID_ID);
-                    Assert(pAllocation->dx.SegmentId == 3);
-
+                if (   pAllocation->dx.sid != SVGA3D_INVALID_ID
+                    && pAllocation->dx.mobid != SVGA3D_INVALID_ID)
                     *(uint32_t *)pPatchAddress = pAllocation->dx.sid;
-                    continue;
-                }
-                else
-                {
-                    /* For Aperture segment, the surface need a mob too, which must be created in BuildPagingBuffer. */
-                    if (   pAllocation->dx.sid != SVGA3D_INVALID_ID
-                        && pAllocation->dx.mobid != SVGA3D_INVALID_ID)
-                    {
-                        *(uint32_t *)pPatchAddress = pAllocation->dx.sid;
-                        continue;
-                    }
-                }
             }
             else if (   enmAllocationType == VBOXDXALLOCATIONTYPE_SHADERS
@@ -468 +471 @@
             {
                 if (pAllocation->dx.mobid != SVGA3D_INVALID_ID)
-                {
                     *(uint32_t *)pPatchAddress = pAllocation->dx.mobid;
-                    continue;
-                }
             }
         }
@@ -479 +479 @@
                 || enmAllocationType == VBOXDXALLOCATIONTYPE_SHADERS
                 || enmAllocationType == VBOXDXALLOCATIONTYPE_CO)
-            {
                 *(uint32_t *)pPatchAddress = SVGA3D_INVALID_ID;
-                continue;
-            }
-        }
-
-        pRender->pPatchLocationListOut[cOut++] = *pIn;
+        }
+
+        ++cOut;
     }
 
@@ -919 +916 @@
 NTSTATUS APIENTRY DxgkDdiDXPatch(PVBOXMP_DEVEXT pDevExt, const DXGKARG_PATCH *pPatch)
 {
-    GALOG(("pDmaBuffer = %p, cbDmaBuffer = %u, cPatches = %u\n",
-           pPatch->pDmaBuffer, pPatch->DmaBufferSubmissionEndOffset - pPatch->DmaBufferSubmissionStartOffset,
-           pPatch->PatchLocationListSubmissionLength));
-
     //DEBUG_BREAKPOINT_TEST();
 

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/VBoxMPGaWddm.cpp

@@ -1276 +1276 @@
     SvgaFlush(pDevExt->pGa->hw.pSvga);
 
-    GALOG(("pDmaBuffer = %p, cbDmaBuffer = %u, cPatches = %u\n",
+    GALOG(("pDmaBuffer %p, cbDmaBuffer %u, PatchStart %u, cPatches %u, Flags 0xx, context type %d\n",
            pPatch->pDmaBuffer, pPatch->DmaBufferSubmissionEndOffset - pPatch->DmaBufferSubmissionStartOffset,
-           pPatch->PatchLocationListSubmissionLength));
-
-    /* The driver does not need to modify paging and present commands here. */
-    if (pPatch->Flags.Paging || pPatch->Flags.Present)
+           pPatch->PatchLocationListSubmissionStart, pPatch->PatchLocationListSubmissionLength, pPatch->Flags.Value,
+           ((PVBOXWDDM_CONTEXT)pPatch->hContext)->enmType));
+
+    /* The driver does not need to modify paging commands. */
+    if (pPatch->Flags.Paging)
         return STATUS_SUCCESS;